- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix of custom properties
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix of custom properties ...................................................................... webadmin: Fix of custom properties This patch fixes two problems: * When user (not admin@internal) with VmCreator role tried to create new VM from snapshot (clone) it failed with "User is not authorized to perform this action." * When admin@internal tried to create new VM from snapshot (clone) and changed some custom properties in "Clone VM from Snapshot" dialog the new VM was anyway created without any custom properties. The cause was confusion between abandoned UnitVmModel#customProperties and UnitVmModel#customPropertySheet during model -> business entity serialization. #customPropertySheet is serialized in CoreUnitToVmBaseBuilder Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Bug-Url: https://bugzilla.redhat.com/1338943 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: frontend: Import VM dialog - architecture
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Import VM dialog - architecture ...................................................................... frontend: Import VM dialog - architecture * The split table of the dialog shows VMs with architecture: "Name (arch)". * The dialog prevents from continuing to the next page and shows error dialog if the selection * contains VM with multiple architectures (because they can't be imported in one Cluster) * contains VM with architecture for which there is no corresponding Cluster in selected Data Center Change-Id: Ife22ca52a9ba8308f5fce2d52318d182382b2337 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1294451 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java 4 files changed, 104 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife22ca52a9ba8308f5fce2d52318d182382b2337 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Set the vfsType glusterfs when importing HE domain
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Set the vfsType glusterfs when importing HE domain ...................................................................... engine: Set the vfsType glusterfs when importing HE domain In HE flow, when importing a gluster domain we must set explicitly the domain type otherwise the mount will fail. This problem discovered when non HE hosts where connecting to that domain. HE hosts have the right mount options in a configuration file (they are connecting before there is an engine live) Change-Id: Ic2383047d5033818ae2c2227e9fd6e756db10eaa Bug-Url: https://bugzilla.redhat.com/1317699 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2383047d5033818ae2c2227e9fd6e756db10eaa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix of custom properties
by tjelinek＠redhat.com 24 May '16

24 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix of custom properties ...................................................................... webadmin: Fix of custom properties This patch fixes two problems: * When user (not admin@internal) with VmCreator role tried to create new VM from snapshot (clone) it failed with "User is not authorized to perform this action." * When admin@internal tried to create new VM from snapshot (clone) and changed some custom properties in "Clone VM from Snapshot" dialog the new VM was anyway created without any custom properties. The cause was confusion between abandoned UnitVmModel#customProperties and UnitVmModel#customPropertySheet during model -> business entity serialization. #customPropertySheet is serialized in CoreUnitToVmBaseBuilder Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Bug-Url: https://bugzilla.redhat.com/1338943 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add audit log for register disk.
by mlipchuk＠redhat.com 23 May '16

23 May '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add audit log for register disk. ...................................................................... core: Add audit log for register disk. Add audit log for regsiter disk. Change-Id: Ieb4b705b353dbc6f789b0e45f34834889e24f950 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/57844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb4b705b353dbc6f789b0e45f34834889e24f950 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix broken test
by ahadas＠redhat.com 23 May '16

23 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix broken test ...................................................................... core: fix broken test Fix UpdateVmCommandTest#testCannotDisableVirtioScsi Change-Id: I148c0e6e2c80e5ca5ac2baefa3c80d934d37200f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 2 files changed, 14 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I148c0e6e2c80e5ca5ac2baefa3c80d934d37200f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused IrsProxyData#privateVersion
by laravot＠redhat.com 23 May '16

23 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Remove unused IrsProxyData#privateVersion ...................................................................... core: Remove unused IrsProxyData#privateVersion Change-Id: Ibcb36461a3b3122c8a27a4c37efe79ed56756870 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcb36461a3b3122c8a27a4c37efe79ed56756870 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6.6
by sbonazzo＠redhat.com 23 May '16

23 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6.6 ...................................................................... build: ovirt-live-3.6.6 Change-Id: Ica26978a6f0747430b0352031136956241a65f36 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica26978a6f0747430b0352031136956241a65f36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: pass mount options via answerfile
by stirabos＠redhat.com 23 May '16

23 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: storage: pass mount options via answerfile ...................................................................... storage: pass mount options via answerfile Some scenario could require custom mount options calling connectStorageServer on the hosted-engine storage domain. Adding an optional parameter to store it in the conf file if a value has been supplied via answerfile. Doing it interactively will require to propose a reasonable default and validate the user input so it will addressed in a future patch. Change-Id: I8fb6e6ff4cfd9b794c54b6a4c8e9de3ee2de9289 Bug-Url: https://bugzilla.redhat.com/1298693 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/conf.py M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M templates/hosted-engine.conf.in 5 files changed, 35 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb6e6ff4cfd9b794c54b6a4c8e9de3ee2de9289 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: storage: pass mount options via answerfile
by stirabos＠redhat.com 23 May '16

23 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: storage: pass mount options via answerfile ...................................................................... storage: pass mount options via answerfile Some scenario could require custom mount options calling connectStorageServer on the hosted-engine storage domain. Adding an optional parameter to store it in the conf file if a value has been supplied via answerfile. Doing it interactively will require to propose a reasonable default and validate the user input so it will addressed in a future patch. Change-Id: I8fb6e6ff4cfd9b794c54b6a4c8e9de3ee2de9289 Bug-Url: https://bugzilla.redhat.com/1298693 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-setup/core/conf.py M src/plugins/gr-he-setup/storage/blockd.py M src/plugins/gr-he-setup/storage/storage.py M templates/hosted-engine.conf.in 5 files changed, 36 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb6e6ff4cfd9b794c54b6a4c8e9de3ee2de9289 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0