- Engine-commits - oVirt List Archives

Change in ovirt-release[ovirt-3.6]: build: ovirt-release-3.6.6
by sbonazzo＠redhat.com 23 May '16

23 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release-3.6.6 ...................................................................... build: ovirt-release-3.6.6 Change-Id: I7a417a018b945e0ca7b58df9f3c9f60eb994634e --- M configure.ac M ovirt-release36.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a417a018b945e0ca7b58df9f3c9f60eb994634e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove notYetRemoved condition from removeTemplateImages.
by mlipchuk＠redhat.com 23 May '16

23 May '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove notYetRemoved condition from removeTemplateImages. ...................................................................... core: Remove notYetRemoved condition from removeTemplateImages. RemoveAllVmTemplateImageTemplatesCommand behaviour should be alligned with RemoveAllVmImagesCommand regarding the deletion of notYetRemoved flag which was introduced at commit 03abfef3798e026b5c4eb431b08724d5f46205de. RemoveAllVmTemplateImageTemplatesCommand shouldn't fail in case of failure to create a task for deletion. The engine should continue and try to delete the other images Change-Id: Iaa2051252cbc9a270102717787249e8885573290 Bug-Url: https://bugzilla.redhat.com/1328071 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa2051252cbc9a270102717787249e8885573290 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: RunVm - do not pass compensation context
by piotr.kliczewski＠gmail.com 23 May '16

23 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: RunVm - do not pass compensation context ...................................................................... core: RunVm - do not pass compensation context When running stateless vm, the RunVm command first creates a snapshot for the vm. When running the create snapshot command, the command context is passed to the child command - which means that the command compensation context is passed as well. The compensation in use is NoOp compensation context it causes the executed child command to use that compensation context as well, on case of failure the db changes won't be reverted which will leave us with inconsistent db state. Change-Id: I93a6035b3a0691a0b1640444e49ef92b128d1122 Bug-Url: https://bugzilla.redhat.com/1334105 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/57848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93a6035b3a0691a0b1640444e49ef92b128d1122 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Cell history graph doesn't overlap text
by tjelinek＠redhat.com 23 May '16

23 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Cell history graph doesn't overlap text ...................................................................... webadmin: Cell history graph doesn't overlap text It prevents overlapping of graph and text in columns Memory, CPU and Network in VM main tab. Space for text and column width were widened. Change-Id: Id00f77f35bed95863c86f0f60810624cb3c52341 Bug-Url: https://bugzilla.redhat.com/1296529 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/AbstractLineChartProgressBarColumn.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id00f77f35bed95863c86f0f60810624cb3c52341 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Sending interface and index as changeCD parameters
by ahadas＠redhat.com 23 May '16

23 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Sending interface and index as changeCD parameters ...................................................................... core: Sending interface and index as changeCD parameters Modified ChangeDiskVDSCommand to support extended format of changeCD VDSM command that accepts driveSpec (interface name, index, ISO path) in place of just ISO path. Change-Id: I303bea437f71c712982e751e01be86539ebc96af Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/ChangeDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ChangeDiskVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ChangeDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 10 files changed, 143 insertions(+), 34 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I303bea437f71c712982e751e01be86539ebc96af Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix edit-vm
by ahadas＠redhat.com 23 May '16

23 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix edit-vm ...................................................................... core: fix edit-vm Change I71725d3 broke update-VM flow. The disks returned by DiskDao#getAllForVm don't include the required VM-data for the validation of disabling virtio-scsi. This is a simple fix - to populate the required data when querying the disks in VmValidator#canDisableVirtioScsi. Change-Id: I83479c5bb7a7b4286fe1b1352cd1f01a649ec085 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83479c5bb7a7b4286fe1b1352cd1f01a649ec085 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: history:remove collection of vm_disk_interface
by Shirly Radco 23 May '16

23 May '16

Shirly Radco has submitted this change and it was merged. Change subject: history:remove collection of vm_disk_interface ...................................................................... history:remove collection of vm_disk_interface Remove collection of vm_disk_interface from vm_disk_configuration table. It was moved in the engine db to disk_vm_element table. Change-Id: Ie86d84c100fe1f41ec6f5bc14ae231085c65712b Bug-Url: https://bugzilla.redhat.com/1338495 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/main/java/ovirt_engine_dwh/configurationsync_4_0/ConfigurationSync.java M packaging/dbscripts/create_views_3_6.sql M packaging/dbscripts/create_views_4_0.sql M tos_project/process/ConfigurationSync_4.0.item M tos_project/process/ConfigurationSync_4.0.properties 5 files changed, 82 insertions(+), 270 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie86d84c100fe1f41ec6f5bc14ae231085c65712b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix leftovers of rename vds group to cluster
by mperina＠redhat.com 23 May '16

23 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: fix leftovers of rename vds group to cluster ...................................................................... core: fix leftovers of rename vds group to cluster This patch fixes some leftovers related to the renaming of vds group to cluster (commit 80c7d4d) Change-Id: I65013a2925b597ba6e04e628361c70e625be2bc2 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterDaoTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java 5 files changed, 73 insertions(+), 73 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65013a2925b597ba6e04e628361c70e625be2bc2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove VdcCommandBase#executeWithReturnValue
by masayag＠redhat.com 23 May '16

23 May '16

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove VdcCommandBase#executeWithReturnValue ...................................................................... core: Remove VdcCommandBase#executeWithReturnValue Removed the unused VdcCommandBase#executeWithReturnValue method. Change-Id: I02d3a65306eba69cdf7a66c48759cd184fb7b66b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcCommandBase.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02d3a65306eba69cdf7a66c48759cd184fb7b66b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tools: Add AlertOnNumberOfLVs to engine-config
by amureini＠redhat.com 23 May '16

23 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: tools: Add AlertOnNumberOfLVs to engine-config ...................................................................... tools: Add AlertOnNumberOfLVs to engine-config Add the ability to control this config value via engine-config.sh, as different storage arrays in different users' environments may be less or more susceptible to the slowness associated with a large number of LVs. This patch does not introduce a limitation on the maximal value for this config value (setting it to Integer.MAX_INT) as to not introduce any behavior changes in upgraded systems where a user may have set it to some arbitrary large value manually and would not be able to use the tool to achieve the same behavior. It does, however, impose a minimum value of 6. This is the number of special LVs created when a block storage domain is created, and setting the config value to anything lower than that would be pointless. Change-Id: I302d99dc09ba8fce81e8b6ff6bd040bfc14fd8d0 Bug-Url: https://bugzilla.redhat.com/1338545 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/57852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I302d99dc09ba8fce81e8b6ff6bd040bfc14fd8d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0