- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine : SSO Conf file should reference ENGINE_FQDN
by mperina＠redhat.com 20 May '16

20 May '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : SSO Conf file should reference ENGINE_FQDN ...................................................................... engine : SSO Conf file should reference ENGINE_FQDN The sso conf file should refernce the conf variable ENGINE_FQDN instead of the actual FQDN entered during setup. Change-Id: I6bc27cfb657956ef77547cf2ac4fb666e6d536cd Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py 1 file changed, 1 insertion(+), 10 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bc27cfb657956ef77547cf2ac4fb666e6d536cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Update to model 4.0.19 and metamodel 1.0.13
by omachace＠redhat.com 20 May '16

20 May '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.0.19 and metamodel 1.0.13 ...................................................................... Update to model 4.0.19 and metamodel 1.0.13 The more relevant changes in this new version of the model are the following: * Added new `diskattachments` collection to virtual machines. * Renamed the `Label` type to `NetworkLabel`. The new version of the metamodel isn't really needed, as the changes only affect the Java code generators, but it is anyhow convenient to use the same version that the other SDKs and the engine. Change-Id: Id04cc14343770c136230042a1bb2484aa58a066d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id04cc14343770c136230042a1bb2484aa58a066d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Update to model 4.0.19 and metamodel 1.0.13
by omachace＠redhat.com 20 May '16

20 May '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.0.19 and metamodel 1.0.13 ...................................................................... Update to model 4.0.19 and metamodel 1.0.13 The more relevant changes in this new version of the model are the following: * Added new `diskattachments` collection to virtual machines. * Renamed the `Label` type to `NetworkLabel`. The new version of the metamodel is needed in order to generate correctly the error messages produced when incorrect enum values are detected (currently it produces 'host-model', for example, when it should produce 'hotst_model'). Change-Id: Iccd2be2b88d7bce497a4c0b1745e955590105b61 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccd2be2b88d7bce497a4c0b1745e955590105b61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Use DiskMapper.map static method instead of constru...
by juan.hernandez＠redhat.com 20 May '16

20 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use DiskMapper.map static method instead of constructor ...................................................................... restapi: Use DiskMapper.map static method instead of constructor This is needed to avoid the following findbugs complaint: Return value of method without side effect is ignored This code calls a method and ignores the return value. However our analysis shows that the method (including its implementations in subclasses if any) does not produce any effect other than return value. Thus this call can be removed. We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. Common false-positive cases include: - The method is designed to be overridden and produce a side effect in other projects which are out of the scope of the analysis. - The method is called to trigger the class loading which may have a side effect. - The method is called just to get some exception. If you feel that our assumption is incorrect, you can use a @CheckReturnValue annotation to instruct FindBugs that ignoring the return value of this method is acceptable. Bug kind and pattern: RV - RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT Change-Id: Iaa35254aa8030baef4a3b7b48afeb699993ac606 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskAttachmentsResource.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa35254aa8030baef4a3b7b48afeb699993ac606 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Update to model 4.0.19 and metamodel 1.0.13
by juan.hernandez＠redhat.com 20 May '16

20 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update to model 4.0.19 and metamodel 1.0.13 ...................................................................... Update to model 4.0.19 and metamodel 1.0.13 The more relevant changes in this new version of the model are the following: * Added new `diskattachments` collection to virtual machines. * Renamed the `Label` type to `NetworkLabel`. The new version of the metamodel isn't really needed, as the changes only affect the Java code generators, but it is anyhow convenient to use the same version that the other SDKs and the engine. Change-Id: I482bec43d71d593cc21afefdd4d8413c4696db61 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I482bec43d71d593cc21afefdd4d8413c4696db61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to metamodel 1.0.13
by juan.hernandez＠redhat.com 20 May '16

20 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to metamodel 1.0.13 ...................................................................... restapi: Update to metamodel 1.0.13 This version of the metamodel includes a fix in the Java code generator needed to generate correctly the error messages returned to the user when an incorrect enum value is detected. Change-Id: I8d3797ec6e23ab70089d6e46b752e730959339fe Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/57766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d3797ec6e23ab70089d6e46b752e730959339fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: avoid NPE when the kernel cmd line params were not...
by tjelinek＠redhat.com 20 May '16

20 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: avoid NPE when the kernel cmd line params were not changed ...................................................................... webadmin: avoid NPE when the kernel cmd line params were not changed The problem was that the models were inited to null and than assigned to small boolean causing NPE. Change-Id: Id5a7d2bdc3738d4354947f5c90e8ead88fc4aa1c Bug-Url: https://bugzilla.redhat.com/1301104 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5a7d2bdc3738d4354947f5c90e8ead88fc4aa1c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[ovirt-4.0]: automation: Windows spec update to 1.0.12
by vfeenstr＠redhat.com 20 May '16

20 May '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: automation: Windows spec update to 1.0.12 ...................................................................... automation: Windows spec update to 1.0.12 This was missing from the version bump Change-Id: Ie325e7acb1d95237ef97f2181ae0fb69cfec24a2 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit d2c5dde976dae509acbb302a4f9a330918ce852a) --- M ovirt-guest-agent-windows.spec 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie325e7acb1d95237ef97f2181ae0fb69cfec24a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: automation: Windows spec update to 1.0.12
by vfeenstr＠redhat.com 20 May '16

20 May '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: automation: Windows spec update to 1.0.12 ...................................................................... automation: Windows spec update to 1.0.12 This was missing from the version bump Change-Id: Ie325e7acb1d95237ef97f2181ae0fb69cfec24a2 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent-windows.spec 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie325e7acb1d95237ef97f2181ae0fb69cfec24a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: UI plugins - add currentLocale API function
by awels＠redhat.com 19 May '16

19 May '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: UI plugins - add currentLocale API function ...................................................................... webadmin: UI plugins - add currentLocale API function This patch adds new API function that returns WebAdmin current locale string in the standard 'xx-YY' format, e.g. 'en-US'. var locale = api.currentLocale(); Change-Id: I0e0c76a10e949e79569c236d16c575410f87a9d6 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java 2 files changed, 24 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/57707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e0c76a10e949e79569c236d16c575410f87a9d6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0