- Engine-commits - oVirt List Archives

Change in jenkins[master]: Using lazy umount everywhere
by sbonazzo＠redhat.com 20 May '16

20 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Using lazy umount everywhere ...................................................................... Using lazy umount everywhere Change-Id: Icb9549678f7716bba03bab765ce2fa347d1f6110 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/groovy-scripts/cleanup_workspaces.groovy M jobs/confs/shell-scripts/build-local-ovirt-node-iso.sh M jobs/confs/shell-scripts/cleanup_slave.sh M jobs/confs/shell-scripts/mock_cleanup.sh M jobs/confs/shell-scripts/mock_setup.sh 5 files changed, 7 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Ready for merge Nir Soffer: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/57405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb9549678f7716bba03bab765ce2fa347d1f6110 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: storage: add the capability to optionally pass mount options
by msivak＠redhat.com 20 May '16

20 May '16

Martin Sivák has submitted this change and it was merged. Change subject: storage: add the capability to optionally pass mount options ...................................................................... storage: add the capability to optionally pass mount options Some scenario could require custom mount options calling connectStorageServer on the hosted-engine storage domain. Adding an optional parameter to store it in the conf file and, if present, pass it to connectStorageServer Change-Id: If7c0a0b5353ea55c6b0a1926db0866ba3a08c3a6 Bug-Url: https://bugzilla.redhat.com/1298693 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/env/config.py M ovirt_hosted_engine_ha/lib/storage_server.py 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57787 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7c0a0b5353ea55c6b0a1926db0866ba3a08c3a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: storage: add the capability to optionally pass mount options
by msivak＠redhat.com 20 May '16

20 May '16

Martin Sivák has submitted this change and it was merged. Change subject: storage: add the capability to optionally pass mount options ...................................................................... storage: add the capability to optionally pass mount options Some scenario could require custom mount options calling connectStorageServer on the hosted-engine storage domain. Adding an optional parameter to store it in the conf file and, if present, pass it to connectStorageServer Change-Id: If7c0a0b5353ea55c6b0a1926db0866ba3a08c3a6 Bug-Url: https://bugzilla.redhat.com/1298693 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/env/config.py M ovirt_hosted_engine_ha/lib/storage_server.py 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7c0a0b5353ea55c6b0a1926db0866ba3a08c3a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Kernel cmdline - host deploy 2
by mperina＠redhat.com 20 May '16

20 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Kernel cmdline - host deploy 2 ...................................................................... core: Kernel cmdline - host deploy 2 Second try after reverted aeb98b5, https://gerrit.ovirt.org/57052 This feature allows to customize kernel commandline (bootloader configuration) of hosts. New VdsDeployUnit setting two environment variables KernelEnv#CMDLINE_NEW and KernelEnv#CMDLINE_OLD to current and last applied kernel command line. After successful host deploy database column vds_static.last_stored_kernel_cmdline is updated. Change-Id: Ie396786ad97f9b62047b4cef7fc60daf8c1773e0 Bug-Url: https://bugzilla.redhat.com/1301104 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployKernelUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployUnit.java 3 files changed, 78 insertions(+), 15 deletions(-) Approvals: Jakub Niedermertl: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie396786ad97f9b62047b4cef7fc60daf8c1773e0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix permissions for profiles created for new domain
by piotr.kliczewski＠gmail.com 20 May '16

20 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix permissions for profiles created for new domain ...................................................................... core: Fix permissions for profiles created for new domain The AddDiskProfileCommand takes care of the permissions for newly added disk profiles and gives the users in Everyone group the DiskProfileUser role. AddStorageDomain command added the created disk profile directly to the DB without calling the command and so this role was not assigned. The fix was to call AddDiskProfileCommand directly from AddStorageDomain and also from AddStorageDomainToPoolCommand which creates a disk profile in case one doesn't exist for the storage domain. A new constructor was added to AddSTorageDomainCommand class, this constructor existed on the master branch and was required in order to enable calling that command internally. Change-Id: Ia6dd5483489b65285cbd5905865c07b9446f6459 Bug-Url: https://bugzilla.redhat.com/1209505 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DiskProfileParameters.java 7 files changed, 47 insertions(+), 30 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Maor Lipchuk: Looks good to me, but someone else must approve Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/57526 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6dd5483489b65285cbd5905865c07b9446f6459 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Publish version 3.6 of the Java SDK to master
by sbonazzo＠redhat.com 20 May '16

20 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Publish version 3.6 of the Java SDK to master ...................................................................... Publish version 3.6 of the Java SDK to master Version 4 of the engine will need version 3 and version 4 of the Java SDKs. This patch changes the master publisher job so that it publishes version 3 of the Java SDK. Change-Id: I1724bcc217ac95c7f3cf02367ebdbd01be7f188c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Juan Hernandez: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1724bcc217ac95c7f3cf02367ebdbd01be7f188c Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix of Import VMs dialog
by tjelinek＠redhat.com 20 May '16

20 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix of Import VMs dialog ...................................................................... webadmin: Fix of Import VMs dialog * Previously when there was no Data Center in state up, it was still possible to press "Load" button which caused FE exception. This patch binds enabled/disabled state of load button to enabled/disabled state of Data Center drop down to prevent that. * Load button to import VMs from external domain is now disabled when there is not external domain. Previously it was enabled all the time and clicking it without export domain caused frontend exception. * Error and warning panel shows relevant info right after opening the dialog. Previously there were no message after the dialog was opened and messages were updated when "Source" dropbox was changed. Change-Id: I168b4c24ae3c75d30366561d9ea61941c827eae6 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1336828 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/ImportVmsPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java 4 files changed, 109 insertions(+), 14 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57772 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I168b4c24ae3c75d30366561d9ea61941c827eae6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: update ovirt-host-deploy to 1.5.0-beta1
by sbonazzo＠redhat.com 20 May '16

20 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: update ovirt-host-deploy to 1.5.0-beta1 ...................................................................... packaging: update ovirt-host-deploy to 1.5.0-beta1 Require newest ovirt-host-deploy in order to get new VdsDeployUnit setting two environment variables KernelEnv#CMDLINE_NEW and KernelEnv#CMDLINE_OLD to current and last applied kernel command line. Change-Id: I7d8b26300a01f082830aabac7e7afeb9cb53e28f Related-To: https://bugzilla.redhat.com/1301104 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d8b26300a01f082830aabac7e7afeb9cb53e28f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: build: post ovirt-host-deploy-1.5.0_beta1
by sbonazzo＠redhat.com 20 May '16

20 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-host-deploy-1.5.0_beta1 ...................................................................... build: post ovirt-host-deploy-1.5.0_beta1 Change-Id: Ib6ff7762655fd617dc734666e1d144c1b40b7b4c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6ff7762655fd617dc734666e1d144c1b40b7b4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: build: ovirt-host-deploy-1.5.0_beta1
by sbonazzo＠redhat.com 20 May '16

20 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-host-deploy-1.5.0_beta1 ...................................................................... build: ovirt-host-deploy-1.5.0_beta1 Change-Id: I8cf11c2b54402c2d36f6b8b5d6b24d22085b4c9e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cf11c2b54402c2d36f6b8b5d6b24d22085b4c9e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0