- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Adapt UI code to SSO changes
by vszocs＠redhat.com 12 May '16

12 May '16

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Adapt UI code to SSO changes ...................................................................... webadmin,userportal: Adapt UI code to SSO changes This patch aligns UI code with recent SSO changes. In a nutshell, it completely removes code that creates and maintains REST webapp's HTTP session in favor of using SSO token. Dealing with REST HTTP session led us to many problems in the past, typically observed as "Auth Required" browser popups due to REST HTTP session vs. Engine user session [1] inconsistencies. [1] see CreateUserSessionCommand and SessionDataContainer classes This patch potentially breaks existing UI plugins by removing the "RestApiSessionAcquired" callback in favor of new API function that returns the SSO token: var xhr = new XMLHttpRequest(); xhr.open('GET', 'http://example.com/ovirt-engine/api'); xhr.setRequestHeader('Authorization', 'Bearer ' + api.ssoToken()); xhr.setRequestHeader('Accept', 'application/json'); xhr.addEventListener('load', function () { // response loaded OK, parse JSON data var data = JSON.parse(this.responseText); }); xhr.send(); In practice, UI plugins no longer need to rely on asynchronous API callback ("RestApiSessionAcquired") to be able to talk with Engine. UI plugins also no longer need to use session-specific request headers like "Prefer:persistent-auth" and "JSESSIONID:xxx", which simplifies their code. Since REST HTTP session mechanism relies on cookie ("JSESSIONID"), individual UI plugins should _not_ try to create a REST session on their own to avoid any clashes. (This might change once REST supports non-cookie session ID transport, e.g. use custom header). >From virt-viewer (VM console) integration perspective, this patch replaces "jsessionid" with "sso-token" within the vv file. Recent build of virt-viewer _should_ support "sso-token" (in addition to supporting "jsessionid" for backwards compatibility). Integration with the Reports portal is not affected; we're still using Engine user session ID for this purpose. In future, Reports portal should be adapted to accept the SSO token. As for backend changes: * removed 'OVIRT-SSO-TOKEN' HTTP response header [SSOLoginFilter] * removed 'JSESSIONID' HTTP response header [RestApiSessionMgmtFilter] Above headers are not needed since both SSO token and Engine user session ID are available the moment user requests GWT HTML page. Change-Id: I62f943ae5798f0f148d84019f1ef6bec4d5ebf6a Bug-Url: https://bugzilla.redhat.com/1236976 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SsoLoginFilter.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/FrontendLoginHandler.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/SsoTokenChange.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java M frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/AutoLoginData.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/SsoTokenData.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/restapi/EngineSessionTimeoutData.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/restapi/RestApiSessionAcquired.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/restapi/RestApiSessionManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/restapi/HasForeignMenuData.java M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 30 files changed, 99 insertions(+), 704 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/49278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62f943ae5798f0f148d84019f1ef6bec4d5ebf6a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use new method for max memory size in RunVmValidator.v...
by ahadas＠redhat.com 12 May '16

12 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Use new method for max memory size in RunVmValidator.validateMemorySize ...................................................................... core: Use new method for max memory size in RunVmValidator.validateMemorySize We introduced new method for determining maximum VM size. The method allows us to remove this piece of duplicate code. Change-Id: I35bda7bb837d491740f252ca674b61c54a9d1b7f Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 2 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/57257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35bda7bb837d491740f252ca674b61c54a9d1b7f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update getTotalMemorySizeInBytes
by ahadas＠redhat.com 12 May '16

12 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Update getTotalMemorySizeInBytes ...................................................................... core: Update getTotalMemorySizeInBytes VM.getTotalMemorySizeInBytes apparently uses outdated value for computing VM's video RAM. This patch retrieves video RAM size from the corresponding helper. We must move the method to modules/bll so that we are able to use the video RAM size helper. We also renamed the method to be more distinctive from the recently introduced getTotalRequiredMemoryInMb method. Change-Id: I2f0fd1ae3f1894b51ee8983725c8763dafbb0503 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 8 files changed, 32 insertions(+), 17 deletions(-) Approvals: Arik Hadas: Looks good to me, approved; Passed CI tests Milan Zamazal: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/56923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f0fd1ae3f1894b51ee8983725c8763dafbb0503 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: New method VmDeviceUtils.getTotalRequiredMemoryInMb
by ahadas＠redhat.com 12 May '16

12 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: New method VmDeviceUtils.getTotalRequiredMemoryInMb ...................................................................... core: New method VmDeviceUtils.getTotalRequiredMemoryInMb The method computes total RAM requirements of running a VM. It's intended to be used in planning. Change-Id: I5151b2326e1bfbfb5dbd8715e931d2438397f0bf Bug-Url: https://bugzilla.redhat.com/1304346 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VideoDeviceSettings.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCommonUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 4 files changed, 117 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/56921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5151b2326e1bfbfb5dbd8715e931d2438397f0bf Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: exception with UI plugin pages
by awels＠redhat.com 11 May '16

11 May '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: exception with UI plugin pages ...................................................................... webadmin: exception with UI plugin pages - When reloading the page while on a UI plugin main tab the console would contain an exception and possibly the exception popup would trigger too. This patch fixes the issue. Change-Id: I2cef1fb3c99e1748b45d8cc6a7701acb0edcd9a1 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/WebAdminPlaceManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/UiPluginsInitialized.java 3 files changed, 67 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57357 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cef1fb3c99e1748b45d8cc6a7701acb0edcd9a1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: renamed engine-log-collector to ovirt-log-collector
by sbonazzo＠redhat.com 11 May '16

11 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: renamed engine-log-collector to ovirt-log-collector ...................................................................... renamed engine-log-collector to ovirt-log-collector Change-Id: I6db36753cc3bb94b3a69fc6b81efcea3b301d3d2 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M .gitignore M configure.ac M ovirt-log-collector.spec.in M src/Makefile.am R src/ovirt-log-collector.8 R src/ovirt-log-collector.in 6 files changed, 26 insertions(+), 26 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/57355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6db36753cc3bb94b3a69fc6b81efcea3b301d3d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: jsonrpc: fix storage domains detection
by stirabos＠redhat.com 11 May '16

11 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: jsonrpc: fix storage domains detection ...................................................................... jsonrpc: fix storage domains detection The storage domain list is now called items in jsonrpc getStorageDomainsList response. Change-Id: I9e41f6d9f5cc64c687c49691801938fb0f969a74 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e41f6d9f5cc64c687c49691801938fb0f969a74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: engine-log-collector: warn users if collecting logs from all...
by sbonazzo＠redhat.com 11 May '16

11 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: engine-log-collector: warn users if collecting logs from all hosts ...................................................................... engine-log-collector: warn users if collecting logs from all hosts Change-Id: I0b4164789b18ed2107174932902d9ca4b6e3eaa3 Bug-Url: https://bugzilla.redhat.com/1294984 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M src/__main__.py 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/55668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b4164789b18ed2107174932902d9ca4b6e3eaa3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tools: made tests more resilient
by tjelinek＠redhat.com 11 May '16

11 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: tools: made tests more resilient ...................................................................... tools: made tests more resilient This way the listOfMigrationPoliciesIsValid will be using a non-hardcoded value making it much more resilient for future modifications. Change-Id: I4464352e55612ee5925dd1abe013da58018a997b Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MigrationPoliciesValueHelper.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MigrationPoliciesValueHelperTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4464352e55612ee5925dd1abe013da58018a997b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: added remaining params to migration policies
by tjelinek＠redhat.com 11 May '16

11 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: added remaining params to migration policies ...................................................................... core: added remaining params to migration policies The following parameters have been added to the migration policy: autoConvergence migrationCompression enableGuestEvents If a policy is selected, it overrides the values set on VM. The enable guest events can only be set in a policy. Change-Id: I91a541935c3901c21c874bfacc63d6d3dbd51694 Bug-Url: https://bugzilla.redhat.com/1252426 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/migration/MigrationPolicy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 6 files changed, 65 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91a541935c3901c21c874bfacc63d6d3dbd51694 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0