- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine : Add session info to jobs table
by mperina＠redhat.com 22 Apr '16

22 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : Add session info to jobs table ...................................................................... engine : Add session info to jobs table Engine may kill session for long running commands before the command completes. Add engine session id to job table so jobs can be tracked by session. If a session has jobs running it should not be purged from backend. Change-Id: Icc997e7a58fb5a42cf7eb990e01a06153bc97bd4 Bug-Url: https://bugzilla.redhat.com/1148514 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SSOSessionUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/JobDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/job_sp.sql A packaging/dbscripts/upgrade/04_00_0540_add_engine_session_seq_id_to_jobs.sql 9 files changed, 96 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc997e7a58fb5a42cf7eb990e01a06153bc97bd4 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add jobs to build and test the dashboard
by sbonazzo＠redhat.com 22 Apr '16

22 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add jobs to build and test the dashboard ...................................................................... Add jobs to build and test the dashboard This patcha adds two new jobs intended to build and check patches for the dashboard project. Change-Id: I8c8389a5a82c9ea133292b730191a8af5c0202b9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A jobs/confs/projects/ovirt-engine-dashboard/ovirt-engine-dashboard_build.yaml A jobs/confs/projects/ovirt-engine-dashboard/ovirt-engine-dashboard_checks.yaml A jobs/confs/yaml/scms/ovirt-engine-dashboard.yaml 3 files changed, 39 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c8389a5a82c9ea133292b730191a8af5c0202b9 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tools: improved helptag script to auto-generate
by sbonazzo＠redhat.com 22 Apr '16

22 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: tools: improved helptag script to auto-generate ...................................................................... tools: improved helptag script to auto-generate Improved the helptag.py script to do a better diff. It can now read in an existing file containing help URL mappings and write out a new, updated file while still preserving the URLs. This saves the team a lot of time. Removed the JSON format and '--format' option because JSON support was not actually used. Change-Id: I07a86ea74c884028cc7a65bd529898d698d64fa0 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M build/helptag.py 1 file changed, 120 insertions(+), 91 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/53320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07a86ea74c884028cc7a65bd529898d698d64fa0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Engine may kill session that is still in use
by mperina＠redhat.com 22 Apr '16

22 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: engine: Engine may kill session that is still in use ...................................................................... engine: Engine may kill session that is still in use Engine may kill session for restapi async task before the command gets a change to execute. Add session_id to command_entities table so commands can be tracked by engine session id. Only session that don't have an active command can be purged. Change-Id: Id538895f73dcc39c6940fc17dca6b602da075805 Bug-Url: https://bugzilla.redhat.com/1148514 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunAsyncActionCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SSOSessionUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractGetEntitiesWithPermittedActionParametersQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BaseCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunAsyncActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M packaging/dbscripts/command_entities_sp.sql A packaging/dbscripts/upgrade/04_00_0530_add_engine_session_seq_id_to_command_entities.sql 19 files changed, 235 insertions(+), 21 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55409 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id538895f73dcc39c6940fc17dca6b602da075805 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Host devices - driver column - frontend
by mbetak＠redhat.com 21 Apr '16

21 Apr '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Host devices - driver column - frontend ...................................................................... webadmin: Host devices - driver column - frontend Column 'Driver' added to Hosts tab > Host Devices subtab, VMs tab > Host Devices subtab and VMs tab > Host Devices subtab > Add device dialog Change-Id: Ifdf6a33edae7de4dbfe0edd0f388686a4da9a920 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/AddVmHostDevicePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/HostDeviceModelBaseTable.java 3 files changed, 24 insertions(+), 3 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdf6a33edae7de4dbfe0edd0f388686a4da9a920 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Rename "keyStorePath" to "trustStoreFile"
by juan.hernandez＠redhat.com 21 Apr '16

21 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Rename "keyStorePath" to "trustStoreFile" ...................................................................... Rename "keyStorePath" to "trustStoreFile" The parameter "keyStorePath" of the connection builder is used to specify the path of the file containing the trusted CA certificates, so we are renaming it to "trustStoreFile" to avoid confusion. Change-Id: I746fe94602fc9673e4bfe7002a91f5ff88974b5e Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/README.adoc M sdk/src/main/java/org/ovirt/engine/sdk4/ConnectionBuilder.java M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder42.java M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder45.java M sdk/src/test/java/org/ovirt/engine/sdk4/ServerTest.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddCluster.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddDataCenter.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddHost.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddNfsDataStorageDomain.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddNfsIsoStorageDomain.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVm.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVmDisk.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVmNic.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AttachNfsDataStorageDomain.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AttachNfsIsoStorageDomain.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/FollowVmLinks.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListVms.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/RemoveHost.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/RemoveVm.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/SearchVms.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/StartVm.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/StopVm.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/UpdateDataCenter.java 23 files changed, 44 insertions(+), 48 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I746fe94602fc9673e4bfe7002a91f5ff88974b5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine: drop 3.6.5 jobs
by sbonazzo＠redhat.com 21 Apr '16

21 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine: drop 3.6.5 jobs ...................................................................... ovirt-engine: drop 3.6.5 jobs 3.6.5 has been released, dropping jobs for it. Change-Id: I2dc511c92ae43e42b3cdd80e462f463db801517d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-db.yaml 2 files changed, 0 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dc511c92ae43e42b3cdd80e462f463db801517d Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix tests that use ParametersHelper
by juan.hernandez＠redhat.com 21 Apr '16

21 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix tests that use ParametersHelper ...................................................................... restapi: Fix tests that use ParametersHelper Commit 39cf33a introduced a failure in the tests that use directly or indirectly the ParametersHelper class, this patch fixes those failures adding the required expectations. Change-Id: Ic580ed297f1c434e338de6be3625b341489f6fa4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/QueryHelperTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromResourceTest.java 4 files changed, 4 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic580ed297f1c434e338de6be3625b341489f6fa4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: Added release notes
by Shirly Radco 21 Apr '16

21 Apr '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: Added release notes ...................................................................... packaging: Added release notes Change-Id: I6492e0c3b3e6868acd1541866963dd35c8ed1e18 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6492e0c3b3e6868acd1541866963dd35c8ed1e18 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: spec: Require java 8
by Shirly Radco 21 Apr '16

21 Apr '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: spec: Require java 8 ...................................................................... packaging: spec: Require java 8 Needed for talend open studio 6.1.1 . Bug-Url: https://bugzilla.redhat.com/1302611 Change-Id: I74df64637f0628c5db1d65e70466f2cdaf61b60e Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 2 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74df64637f0628c5db1d65e70466f2cdaf61b60e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0