- Engine-commits - oVirt List Archives

Change in jenkins[master]: moving the ng nodes job to 4 oclock to run after publishers
by tlitovsk＠redhat.com 21 Apr '16

21 Apr '16

Anatoly Litovsky has submitted this change and it was merged. Change subject: moving the ng nodes job to 4 oclock to run after publishers ...................................................................... moving the ng nodes job to 4 oclock to run after publishers Change-Id: I6ffe2ef6d018012c6dc802c3556bca68a65bb29e Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/projects/ovirt-node-ng/ovirt-node-ng.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests David Caro: Looks good to me Anatoly Litovsky: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/56456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ffe2ef6d018012c6dc802c3556bca68a65bb29e Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor cleanup in VmJobsMonitoring
by ahadas＠redhat.com 21 Apr '16

21 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup in VmJobsMonitoring ...................................................................... core: minor cleanup in VmJobsMonitoring 1. Break long chain of calls in getExistingJobsForVm to multiple lines. 2. Rename vmJobsToRemove and vmJobsToUpdate to jobsToRemove and jobsToUpdate as in this context it is clear that it is about VM-jobs. Change-Id: I182927c2b9a693564b9780caed9cf7912e9702a0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/56246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I182927c2b9a693564b9780caed9cf7912e9702a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add VDSM's setVolumeLegality support.
by mlipchuk＠redhat.com 21 Apr '16

21 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add VDSM's setVolumeLegality support. ...................................................................... core: Add VDSM's setVolumeLegality support. VDSM's API provides a procedure to set a volume legality in the storage, but no VDS command currently exists to call that procedure. This patch adds SetVolumeLegalityVDSCommand- which calls VDSM's setVolumeLegality. Change-Id: Ic5d15b13dca90592d1a829b9d16ea1d09da2a9f5 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVolumeLegalityVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SetVolumeLegalityVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 7 files changed, 82 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Amit Aviram: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5d15b13dca90592d1a829b9d16ea1d09da2a9f5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: support VDSM's prepare illegal image.
by mlipchuk＠redhat.com 21 Apr '16

21 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: support VDSM's prepare illegal image. ...................................................................... core: support VDSM's prepare illegal image. Allowing to prepare an illegal image is enabled in VDSM's API by adding the allowIllegal flag. However, the current VDS command does not provide that option. This patch extends PrepareImageVDSCommand to use VDSM's API correctly, adding the allowIllegal flag. Change-Id: I40c52a0b30e9b52224784aa8b0e5e27126b1c22a Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/PrepareImageVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PrepareImageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 7 files changed, 46 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Amit Aviram: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40c52a0b30e9b52224784aa8b0e5e27126b1c22a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add cinder call back for AddVmFromSnapshot.
by tnisan＠redhat.com 21 Apr '16

21 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add cinder call back for AddVmFromSnapshot. ...................................................................... core: Add cinder call back for AddVmFromSnapshot. When clonning a VM from Cinder snapshot the VM and the snapshot stay in lock status since AddVmFromSnapshot has no call back method. Adding the call back method should fix this issue. Change-Id: Ic4a41089fbf035ddd4b914885db5dc2a39f1a25c Bug-Url: https://bugzilla.redhat.com/1316853 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/56440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4a41089fbf035ddd4b914885db5dc2a39f1a25c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Disable Pass-Through Host CPU for PPC Arch
by rgolan＠redhat.com 21 Apr '16

21 Apr '16

Roy Golan has submitted this change and it was merged. Change subject: core: Disable Pass-Through Host CPU for PPC Arch ...................................................................... core: Disable Pass-Through Host CPU for PPC Arch Disable the checkbox for "Pass-through Host CPU" in the Add and Edit VM dialog popups and the ability to enable the setting via the REST API when on a cluster with a PPC-based architecture. As PPC doesn't allow for Host CPU pass-through, these options shouldn't be available. Change-Id: I76941ecf63988ff55380760765cb8a6bc12bb58f Bug-Url: https://bugzilla.redhat.com/1291063 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 111 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/54116 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76941ecf63988ff55380760765cb8a6bc12bb58f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Change GetEngineSessionIdForSSOToken to public query
by mperina＠redhat.com 21 Apr '16

21 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : Change GetEngineSessionIdForSSOToken to public query ...................................................................... engine : Change GetEngineSessionIdForSSOToken to public query GetEngineSessionIdForSSOTokenQuery fails resulting in bearer authentication requests creating new session on each api request. Change-Id: I59b2a23b849e1626452510473b05691109781481 Bug-Url: https://bugzilla.redhat.com/1092744 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SSORestApiAuthFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59b2a23b849e1626452510473b05691109781481 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update of HostNetworkQos on DataCenter must trigger up...
by alkaplan＠redhat.com 21 Apr '16

21 Apr '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: Update of HostNetworkQos on DataCenter must trigger update of network ...................................................................... core: Update of HostNetworkQos on DataCenter must trigger update of network before this update, if HostNetworkQos was updated on datacenter, and something other that name or description was changed, it rendered network out of sync, because on database records was updated, not network itself. Change-Id: I67882d1c68806b852ee655e46fff03aca87a04ce Bug-Url: https://bugzilla.redhat.com/1279771 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateHostNetworkQosCommand.java 1 file changed, 157 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67882d1c68806b852ee655e46fff03aca87a04ce Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix provider isReadOnlyAware flag
by derez＠redhat.com 21 Apr '16

21 Apr '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix provider isReadOnlyAware flag ...................................................................... webadmin: fix provider isReadOnlyAware flag ProviderType -> isReadOnlyAware method returns a wrong flag, which caused an exception when editing a non 'ExternalNetworkProvider', and the 'Read Only' checkbox was displays for all providers type. Fixed by returning the correct flag. Change-Id: Ie2c036548cb477abba617c01268eacec6af99ef3 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2c036548cb477abba617c01268eacec6af99ef3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: services as export for woorea in XML conf
by derez＠redhat.com 21 Apr '16

21 Apr '16

Daniel Erez has submitted this change and it was merged. Change subject: core: services as export for woorea in XML conf ...................................................................... core: services as export for woorea in XML conf Changed 'services' attribute to export for woorea module in XML config. This is required to allow the ServiceLoader in OpenStackClient to find the RESTEasyConnector class. Change-Id: I6711107e352d5e3e0a94a377f7e826596025d462 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M ear/src/main/application/META-INF/jboss-deployment-structure.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56436 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6711107e352d5e3e0a94a377f7e826596025d462 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0