- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: StorageHelperBase#filterConnectionsByStorageType
by amureini＠redhat.com 21 Apr '16

21 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageHelperBase#filterConnectionsByStorageType ...................................................................... core: StorageHelperBase#filterConnectionsByStorageType Used Java 8 streaming API to reduce boilerplate code. Change-Id: I27d3bef4c9b1a581d9416d64525a17be43ffea4b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27d3bef4c9b1a581d9416d64525a17be43ffea4b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove vm jobs in batch
by ahadas＠redhat.com 21 Apr '16

21 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove vm jobs in batch ...................................................................... core: remove vm jobs in batch VM jobs are typically (currently always) removed in groups as a result of aggregating the jobs reported from VMs that are running on the same host. Thus, it worth doing the remove in batch (like we do for updates). Change-Id: Id91f402f414c4df9dd41b36fbf232c8fe5a9788b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoringTest.java 2 files changed, 21 insertions(+), 38 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id91f402f414c4df9dd41b36fbf232c8fe5a9788b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add cinder call back for AddVmFromSnapshot.
by mlipchuk＠redhat.com 20 Apr '16

20 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add cinder call back for AddVmFromSnapshot. ...................................................................... core: Add cinder call back for AddVmFromSnapshot. When clonning a VM from Cinder snapshot the VM and the snapshot stay in lock status since AddVmFromSnapshot has no call back method. Adding the call back method should fix this issue. Change-Id: Ic4a41089fbf035ddd4b914885db5dc2a39f1a25c Bug-Url: https://bugzilla.redhat.com/1316853 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/56305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4a41089fbf035ddd4b914885db5dc2a39f1a25c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Use empty string as default value of parameters
by juan.hernandez＠redhat.com 20 Apr '16

20 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use empty string as default value of parameters ...................................................................... restapi: Use empty string as default value of parameters Currently matrix and query parameters that don't have a value are ignored. That is incorrect, we should use an empty string as the default value. Change-Id: I43fa2304cfc1aea406ff1f0da0da20f440346ecb Bug-Url: https://bugzilla.redhat.com/1328404 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/ParametersHelper.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43fa2304cfc1aea406ff1f0da0da20f440346ecb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundand action type from hot plug/unplug disk...
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundand action type from hot plug/unplug disk tests ...................................................................... core: Remove redundand action type from hot plug/unplug disk tests The getCommandActionType seems to be redundant thus removed Change-Id: I2d5f6482b0c88c6233e62ae5fc105f5de886b8e3 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotUnPlugDiskFromVmCommandTest.java 2 files changed, 0 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d5f6482b0c88c6233e62ae5fc105f5de886b8e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Avoid redundant VmDevice creation in HotPlugDiskToVmCo...
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Avoid redundant VmDevice creation in HotPlugDiskToVmCommandTest ...................................................................... core: Avoid redundant VmDevice creation in HotPlugDiskToVmCommandTest The createDiskWrongPlug method creates a redundant VmDevice for the sole purpose of making it plugged/unplugged, this can be done by simply using the already existing VmDevice created in the setup and just changing it's plugged status Also the redundant mockVmDevice(false) was removed from createVirtIODisk as an unplugged device is already mocked in the setup Change-Id: Icf50857716f63706b85a05ce8390980dc2b4659a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf50857716f63706b85a05ce8390980dc2b4659a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove duplicate from HotUnPlugDiskFromVmCommandTest
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove duplicate from HotUnPlugDiskFromVmCommandTest ...................................................................... core: Remove duplicate from HotUnPlugDiskFromVmCommandTest The method createVirtIODisk is exactly the same as in the super class only changes the status to plugged, the content was removed and a call to the super method was done instead along with changing the disk status to plugged Change-Id: Iccce97c33787a271161418e22254bbb417d8e2b5 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotUnPlugDiskFromVmCommandTest.java 2 files changed, 3 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccce97c33787a271161418e22254bbb417d8e2b5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Make setup method in HotPlugDiskToVmCommandTest more r...
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Make setup method in HotPlugDiskToVmCommandTest more readable ...................................................................... core: Make setup method in HotPlugDiskToVmCommandTest more readable Use @Mock instead of manual mocks, separate blocks that handle different mock behaviors to make the setup method more readable Change-Id: Ia8f14326e5098ae07dd1c6cb955fa18cfef9d372 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8f14326e5098ae07dd1c6cb955fa18cfef9d372 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Unify both @Before methods in HotPlugDiskToVmCommand
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Unify both @Before methods in HotPlugDiskToVmCommand ...................................................................... core: Unify both @Before methods in HotPlugDiskToVmCommand Unify both @Before methods to make the code more readable, having one method at the top of the class can result in missing the second one which is in the middle of the class. By JUnit spec the order multiple @Before methods are invoked is not guaranteed so it doesn't matter which content comes first Change-Id: Ic10aa3147405a10edb4ed79b762ce7b929dc9804 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java 1 file changed, 15 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic10aa3147405a10edb4ed79b762ce7b929dc9804 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove duplicate code in HotPlugDiskToVmCommandTest
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove duplicate code in HotPlugDiskToVmCommandTest ...................................................................... core: Remove duplicate code in HotPlugDiskToVmCommandTest All tests are mocking DiskDao and VmDao in the command either directly or by calling another method, moved those to the setup method. Inlined the oneline method mockVMDao Change-Id: I18cec31ac2842145d2a106f36671968d547d4c16 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java 1 file changed, 3 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18cec31ac2842145d2a106f36671968d547d4c16 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0