- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Use metamodel "BuiltinTypes"
by juan.hernandez＠redhat.com 05 Apr '16

05 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use metamodel "BuiltinTypes" ...................................................................... Use metamodel "BuiltinTypes" This patch changes the code generator so that it uses the "BuiltinTypes" class of the metamodel to add to the model the built-in types, like "Action" and "Fault". Change-Id: I7876f0497af2e3f84a6c0b3193d36ecddf3b8515 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/Tool.java M pom.xml 2 files changed, 8 insertions(+), 69 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7876f0497af2e3f84a6c0b3193d36ecddf3b8515 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Publish Ruby SDK packages
by sbonazzo＠redhat.com 05 Apr '16

05 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Publish Ruby SDK packages ...................................................................... Publish Ruby SDK packages This patch adds the Ruby SDK to the publisher job. Change-Id: Ie4bb6d242586122c7da3f5c7130ba5ec1234f241 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4bb6d242586122c7da3f5c7130ba5ec1234f241 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Async tasks - move steps/jobs handling to CommandBase
by laravot＠redhat.com 05 Apr '16

05 Apr '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Async tasks - move steps/jobs handling to CommandBase ...................................................................... core: Async tasks - move steps/jobs handling to CommandBase Currently the tasks related jobs/steps handling logic is within CommandAsyncTask. When using CoCo to track task related commands we'll sometimes want the child command endAction() to be executed by the parent command, in that case the jobs/steps logic won't be executed as the related code is in CommandAsyncTask. This patch moves that code to the endAction() in CommandBase, so when having a CoCo managed flow the behavior will remain the same. Change-Id: I5836dbd3c6e3ff69fc1776471457affd9aa582f8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310426 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java 2 files changed, 21 insertions(+), 9 deletions(-) Approvals: Freddy Rolland: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5836dbd3c6e3ff69fc1776471457affd9aa582f8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: split ExecutionHandler.endTaskJob()
by laravot＠redhat.com 05 Apr '16

05 Apr '16

Liron Aravot has submitted this change and it was merged. Change subject: core: split ExecutionHandler.endTaskJob() ...................................................................... core: split ExecutionHandler.endTaskJob() ExecutionHandler.endTaskJob() performs two different things today - 1. Ends the FINALIZING step if present, otherwise the current step. 2. Ends the jobs if needed This patch splits this method into two different methods to be used separately in the following patches. Change-Id: I75f97b4347dce4b7e5130a7ae59e29013d24f973 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310426 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDisksTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java 5 files changed, 65 insertions(+), 31 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/55613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75f97b4347dce4b7e5130a7ae59e29013d24f973 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: remove FileUtil
by laravot＠redhat.com 05 Apr '16

05 Apr '16

Liron Aravot has submitted this change and it was merged. Change subject: backend: remove FileUtil ...................................................................... backend: remove FileUtil This patch removes the FileUtil class and replaces it by using the standard Java Files class. Change-Id: I00761489a92fcde9df2d41635a49d801112eeb95 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/FileUtil.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/FileUtilTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java 4 files changed, 14 insertions(+), 80 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00761489a92fcde9df2d41635a49d801112eeb95 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: fixing typo
by sbonazzo＠redhat.com 05 Apr '16

05 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: fixing typo ...................................................................... fixing typo Change-Id: Iab69713df9fa2bfa5d3c2ea7dbd45172814e0e6f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-el7-deps.repo.in M ovirt-release40.spec.in 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab69713df9fa2bfa5d3c2ea7dbd45172814e0e6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: do not ping too often
by tnisan＠redhat.com 05 Apr '16

05 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: do not ping too often ...................................................................... core: do not ping too often Code has a bug causing polling (with FutureVDSCommandType.Poll / ping verb) too bursty when host is responding fast. Changes: 1. method waitBetweenPolls is moved from end of method to the start. When wait is needed, it's the first thing which is done. 2. field lastTimeBeforePoll is introduced. After waiting this field is set with current time. In next execution, waitBetweenPolls will wait if requested POLLING_BREAK is not met. 3. in waitBetweenPolls while is introduced, because Thread.sleep does not guarantee to wait for requested time period, actually it may sometimes return way sooner than that (see comment in method). Not that important changes: 4. extracted reading value from task / handling timeouts to single method for code clarity 5. added trace logging for next time this class misbehaves. Change-Id: I2569376eae0b67591f669438a9742b34ba7ff568 Bug-Url: https://bugzilla.redhat.com/1320606 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworkPoller.java 1 file changed, 48 insertions(+), 17 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Anton Marchukov: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2569376eae0b67591f669438a9742b34ba7ff568 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: OVF: Use the maximum number of vcpus when provided by the en...
by msivak＠redhat.com 05 Apr '16

05 Apr '16

Martin Sivák has submitted this change and it was merged. Change subject: OVF: Use the maximum number of vcpus when provided by the engine ...................................................................... OVF: Use the maximum number of vcpus when provided by the engine https://bugzilla.redhat.com/show_bug.cgi?id=1304387 Change-Id: I3d5a705f382f8305864ae0937d6afacf7885bf21 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/ovf/Makefile.am M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py A ovirt_hosted_engine_ha/lib/ovf/ovf_test_max_vcpu.xml 4 files changed, 284 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d5a705f382f8305864ae0937d6afacf7885bf21 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: _fake_mastersd_uuid as a scalar value
by msivak＠redhat.com 05 Apr '16

05 Apr '16

Martin Sivák has submitted this change and it was merged. Change subject: upgrade: _fake_mastersd_uuid as a scalar value ...................................................................... upgrade: _fake_mastersd_uuid as a scalar value Fixing an issue introduced with 41ae38e5fc55b0188896c88a3b9bac5b68a17b42 Change-Id: Ifc53263888da42f097e04bc917a5773270c56e58 Bug-Url: https://bugzilla.redhat.com/1292652 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc53263888da42f097e04bc917a5773270c56e58 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Use metamodel "BuiltinTypes"
by juan.hernandez＠redhat.com 05 Apr '16

05 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use metamodel "BuiltinTypes" ...................................................................... Use metamodel "BuiltinTypes" This patch changes the code generator so that it uses the "BuiltinTypes" class of the metamodel to add to the model the built-in types, like "Action" and "Fault". Change-Id: I1b392a1d4bc5685bc488c11bfc6cfa87e65d0819 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/Tool.java 1 file changed, 5 insertions(+), 66 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b392a1d4bc5685bc488c11bfc6cfa87e65d0819 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0