- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.5]: HE: Make the unmanaged hosted engine error a bit more generic
by tnisan＠redhat.com 04 Apr '16

04 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: HE: Make the unmanaged hosted engine error a bit more generic ...................................................................... HE: Make the unmanaged hosted engine error a bit more generic This updates the ACTION_TYPE_FAILED_UNMANAGED_HOSTED_ENGINE error message to include the full action and type to make it ready for more actions than just VM activation. The message is changed from: Cannot ${action} unmanaged hosted engine VM. Please upgrade the cluster level to 3.6 and wait for the hosted engine storage domain to be properly imported. To: Cannot ${action} ${type}. You are using an unmanaged hosted engine VM. Please upgrade the cluster level to 3.6 and wait for the hosted engine storage domain to be properly imported. Change-Id: Ie3230c4b7a783d200df0da18cf8462a21aa0b54f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3230c4b7a783d200df0da18cf8462a21aa0b54f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.5]: packaging: Allow different java home per component
by tnisan＠redhat.com 04 Apr '16

04 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: Allow different java home per component ...................................................................... packaging: Allow different java home per component Change-Id: I4943f685c9d972ea6deb098565cea87f72274bab Bug-Url: https://bugzilla.redhat.com/1303132 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/java-home M packaging/pythonlib/ovirt_engine/java.py 2 files changed, 60 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/55650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4943f685c9d972ea6deb098565cea87f72274bab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: scheduler: Store correct OS version in map
by tnisan＠redhat.com 04 Apr '16

04 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: scheduler: Store correct OS version in map ...................................................................... scheduler: Store correct OS version in map Write the new version into the highest version map. Change-Id: I9594f2f8f8c5d9c7fbeba7b6aff3a77cdc533d14 Bug-Url: https://bugzilla.redhat.com/1241149 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnitTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9594f2f8f8c5d9c7fbeba7b6aff3a77cdc533d14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: Allow different java home per component
by tnisan＠redhat.com 04 Apr '16

04 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: Allow different java home per component ...................................................................... packaging: Allow different java home per component Change-Id: I4943f685c9d972ea6deb098565cea87f72274bab Bug-Url: https://bugzilla.redhat.com/1303132 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/java-home M packaging/pythonlib/ovirt_engine/java.py 2 files changed, 60 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/55648 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4943f685c9d972ea6deb098565cea87f72274bab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Added CPU Profiles Roles to the RoleTree
by tnisan＠redhat.com 04 Apr '16

04 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Added CPU Profiles Roles to the RoleTree ...................................................................... webadmin: Added CPU Profiles Roles to the RoleTree CPU profile roles were added to the Role Tree in the UI. The roles are: CpuProfileCreator and CpuProfileOperator. Change-Id: Ib5e8b2b11a882fadadd1e6261fb574f871d4ec4c Bug-Url: https://bugzilla.redhat.com/1143869 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 49 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55651 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5e8b2b11a882fadadd1e6261fb574f871d4ec4c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor refactoring in vm-analyzer
by ahadas＠redhat.com 04 Apr '16

04 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in vm-analyzer ...................................................................... core: minor refactoring in vm-analyzer 1. In proceedDownVm, 'prevStatus' is always assigned with some value now so no need to compare to 'Unassigned'. 2. Remove the arguments from handleVmOnDown and inMigrationTo methods. 3. Remove the argument from afterSuspendTreatment method. 4. Remove redundant null checks in proceedVmBeforeDeletion and removeVmFromCache methods. Change-Id: I4128fd29470ddcaeecc882f16ed5aa3e0e34a965 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 29 insertions(+), 30 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4128fd29470ddcaeecc882f16ed5aa3e0e34a965 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: packaging: Have own java home
by Shirly Radco 04 Apr '16

04 Apr '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: Have own java home ...................................................................... packaging: Have own java home Do not use java home as set by the engine code, as the engine currently supports both 1.7 and 1.8 while reports supports 1.7 only. Change-Id: I043225d4a55b5f1949d0c6455637c112788d5bdb Bug-Url: https://bugzilla.redhat.com/1303132 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/services/ovirt-engine-reportsd/ovirt-engine-reportsd.py M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/ovirt_engine_setup/reports/reportsutil.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/config/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/config/java.py M packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 8 files changed, 67 insertions(+), 16 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/55619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I043225d4a55b5f1949d0c6455637c112788d5bdb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.5]: restapi: Tolerate invalid fencing options
by tnisan＠redhat.com 04 Apr '16

04 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Tolerate invalid fencing options ...................................................................... restapi: Tolerate invalid fencing options Currently the parsing of fencing options fails when there is any error in the configuration parameters that contain then. This produces a complete failure of the capabilities resource. To avoid that complete failure this patch changes that code so that it logs errors and continues. Change-Id: I5901fa82972cbe13245c5212451f288b077369d0 Bug-Url: https://bugzilla.redhat.com/1323450 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/FenceOptionsParser.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/FenceOptionsParserTest.java 2 files changed, 40 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5901fa82972cbe13245c5212451f288b077369d0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Save the disconnected vNIC info to vm.conf when converting t...
by msivak＠redhat.com 04 Apr '16

04 Apr '16

Martin Sivák has submitted this change and it was merged. Change subject: Save the disconnected vNIC info to vm.conf when converting the OVF image ...................................................................... Save the disconnected vNIC info to vm.conf when converting the OVF image Some vNICs might not be plugged in and the --vm-start command should handle that properly. Trying to connect a vNIC like that can fail the VM start as the network might not be available on the host. Change-Id: If0ae1af6152236a0c4a7d767ae828a91cfd4dbd2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319785 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 9505b3005bac21cf15e90edde6414e736f817265) --- M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml 3 files changed, 36 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0ae1af6152236a0c4a7d767ae828a91cfd4dbd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fixed remove storage qos error popup
by derez＠redhat.com 04 Apr '16

04 Apr '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fixed remove storage qos error popup ...................................................................... webadmin: Fixed remove storage qos error popup When removing storage QoSes(Quality Of Services) which had disk profiles attached to them, together with QoSes that didn't, the confirmation dialog would show only the QoSes with the disk profiles. The fix changed that and now the confirmation dialog is showing all of the QoSes that are about to be removed. Also, Style can be added to the list items in the "Remove Qos Model" using html tagging. Change-Id: I66d7bd71ed736d61c72deb885b8a37c35e95f030 Bug-Url: https://bugzilla.redhat.com/1142865 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/RemoveQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/RemoveStorageQosModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/StorageQosRemovePopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/StorageQosRemovePopupView.java 8 files changed, 131 insertions(+), 35 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/46327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66d7bd71ed736d61c72deb885b8a37c35e95f030 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0