- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Remove version check for rebooting a VM
by mbetak＠redhat.com 05 Apr '16

05 Apr '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Remove version check for rebooting a VM ...................................................................... webadmin: Remove version check for rebooting a VM Rebooting a VM is supported for any cluster of version 3.4 and above. Since we no longer support older clusters, this check is redundant, and can safely be removed. Change-Id: I98d51365a01f1bf1f6b84def92867724c09d0aeb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/55562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98d51365a01f1bf1f6b84def92867724c09d0aeb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Limited use of CPU Profiles by user
by tnisan＠redhat.com 05 Apr '16

05 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Limited use of CPU Profiles by user ...................................................................... engine: Limited use of CPU Profiles by user Adding/Updating VM using REST API now checks that the user has permissions for the CPU Profile of the VM. This applies whether the CPU profile is changed or not. It means that even if the CPU Profile is not changed or the user tries to create a VM in a cluster where he/she doesn't have permissions for any CPU Profile, he/she will not be able to Create/Update the VM. This change effects the following Commands in the engine: AddVmCommand, UpdateVmCommand. In case no Cpu Profile was specified in the REST API request, Any CPU Profile that the user has permissions for will be used to comply with the old behaviour of the system Change-Id: Ic187e1815fbb2334e4eca7140e6b2a5493059bae Bug-Url: https://bugzilla.redhat.com/1143869 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 80 insertions(+), 21 deletions(-) Approvals: Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, approved Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic187e1815fbb2334e4eca7140e6b2a5493059bae Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: upgrade: _fake_mastersd_uuid as a scalar value
by msivak＠redhat.com 05 Apr '16

05 Apr '16

Martin Sivák has submitted this change and it was merged. Change subject: upgrade: _fake_mastersd_uuid as a scalar value ...................................................................... upgrade: _fake_mastersd_uuid as a scalar value Fixing an issue introduced with 41ae38e5fc55b0188896c88a3b9bac5b68a17b42 Change-Id: Ifc53263888da42f097e04bc917a5773270c56e58 Bug-Url: https://bugzilla.redhat.com/1292652 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Artyom Lukianov: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc53263888da42f097e04bc917a5773270c56e58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: make certificate subject part of VDS
by emesika＠redhat.com 05 Apr '16

05 Apr '16

Eli Mesika has submitted this change and it was merged. Change subject: core: make certificate subject part of VDS ...................................................................... core: make certificate subject part of VDS Change-Id: Ica83845eec9f8442f9e20a0416de87ae5c0a3758 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1268224 Signed-off-by: emesika <emesika(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsCertificateSubjectByVdsIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsCertificateSubjectByVmIdQuery.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsCertificateSubjectByVdsIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CertificateSubjectHelper.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/CertificateSubjectHelperTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/AbstractInvertibleMappingTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 17 files changed, 96 insertions(+), 163 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Passed CI tests Juan Hernandez: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica83845eec9f8442f9e20a0416de87ae5c0a3758 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: build: ovirt-live-4.0.0_alpha1
by sbonazzo＠redhat.com 05 Apr '16

05 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-4.0.0_alpha1 ...................................................................... build: ovirt-live-4.0.0_alpha1 Change-Id: Idaf6045798bd2308fdeb5cc999f8b2252a356932 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaf6045798bd2308fdeb5cc999f8b2252a356932 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: build: oVirt 4.0 alpha1
by sbonazzo＠redhat.com 05 Apr '16

05 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt 4.0 alpha1 ...................................................................... build: oVirt 4.0 alpha1 Change-Id: I93896db216f4cde18b67dc56cd393590d74836b6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-el7-deps.repo.in M ovirt-release40.spec.in 3 files changed, 7 insertions(+), 6 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93896db216f4cde18b67dc56cd393590d74836b6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unnecessary argument in VmPoolUserParameters
by juan.hernandez＠redhat.com 05 Apr '16

05 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove unnecessary argument in VmPoolUserParameters ...................................................................... core: Remove unnecessary argument in VmPoolUserParameters The VmPoolUserParameters.getUser() method is not used, no need to pass DbUser object via params constructor. Change-Id: Id783490d1cf24fd4ed096400e5b82140e17038a3 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolUserParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/PoolItemBehavior.java 3 files changed, 4 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/53137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id783490d1cf24fd4ed096400e5b82140e17038a3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Added permissions to Power User
by tnisan＠redhat.com 05 Apr '16

05 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Added permissions to Power User ...................................................................... core: Added permissions to Power User Added permission to 'Attach Disk Profile' to Power User. Change-Id: If17d5bc09c60e3ab6b22e40260f82222ded25c3d Bug-Url: https://bugzilla.redhat.com/1311052 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> (cherry picked from commit be9724556fbc82de3a171acc5a2df335ce5b22e2) --- A packaging/dbscripts/upgrade/03_06_2090_add_attach_disk_profile_permissions_to_power_user_role.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Eli Mesika: Looks good to me, but someone else must approve Tomer Saban: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If17d5bc09c60e3ab6b22e40260f82222ded25c3d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: oVirt Live 3.6.5 rc2
by sbonazzo＠redhat.com 04 Apr '16

04 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: oVirt Live 3.6.5 rc2 ...................................................................... oVirt Live 3.6.5 rc2 Change-Id: Id161ff7de70f7f6dbddbbbe486f0ecc7d945f7e3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55667 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id161ff7de70f7f6dbddbbbe486f0ecc7d945f7e3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6.5]: HE: Enable hosted engine vNIC editing
by tnisan＠redhat.com 04 Apr '16

04 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: HE: Enable hosted engine vNIC editing ...................................................................... HE: Enable hosted engine vNIC editing This patch enabled vNIC management for the hosted engine VM, But the management interface (ovirtmgmt) can't be deactivated for the HE VM. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769 Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 39 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Sivák: Verified Roy Golan: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/55569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0