- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.5]: core: prevent a race on add template version - done right
by tnisan＠redhat.com 03 Apr '16

03 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: prevent a race on add template version - done right ...................................................................... core: prevent a race on add template version - done right Putting an empty string as a place-holder in updateVmsJobIdMap to prevent a race in which updateVmVersion method that is called by quartz is executed before this map is updated with the job. Change-Id: I6489bc1c606b28c60066a687690373b7b7c71140 Bug-Url: https://bugzilla.redhat.com/1294511 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 2 files changed, 2 insertions(+), 12 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6489bc1c606b28c60066a687690373b7b7c71140 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Tolerate invalid fencing options
by juan.hernandez＠redhat.com 03 Apr '16

03 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Tolerate invalid fencing options ...................................................................... restapi: Tolerate invalid fencing options Currently the parsing of fencing options fails when there is any error in the configuration parameters that contain then. This produces a complete failure of the capabilities resource. To avoid that complete failure this patch changes that code so that it logs errors and continues. Change-Id: I5901fa82972cbe13245c5212451f288b077369d0 Bug-Url: https://bugzilla.redhat.com/1322923 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/FenceOptionsParser.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/FenceOptionsParserTest.java 2 files changed, 38 insertions(+), 13 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5901fa82972cbe13245c5212451f288b077369d0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor changes in vm analyze
by ahadas＠redhat.com 03 Apr '16

03 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: minor changes in vm analyze ...................................................................... core: minor changes in vm analyze Remove redundant null checks that make the code more messy. Change-Id: I56b3384749e7e0d2519414ac3a6e06cb2d2eb090 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56b3384749e7e0d2519414ac3a6e06cb2d2eb090 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix logs in vm analyze
by ahadas＠redhat.com 03 Apr '16

03 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix logs in vm analyze ...................................................................... core: fix logs in vm analyze Add logs for: 1. discovery of external VM 2. discovery of unmanaged hosted engine 3. disappearance of a VM (stopped being reported) Change other logs to contain both VM ID and name. Change-Id: I05938ad01e7e221d1fef44a160348a818bc670d8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 55 insertions(+), 21 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05938ad01e7e221d1fef44a160348a818bc670d8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: add automation for standard ci
by Shirly Radco 03 Apr '16

03 Apr '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: add automation for standard ci ...................................................................... packaging: add automation for standard ci Added automation directory for standard ci. Change-Id: I698c9ccf0d32afe8cc3418533b290a1f9fc2d920 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- A automation/README.md A automation/build-artifacts.packages A automation/build-artifacts.repos A automation/build-artifacts.sh A automation/check-merged.packages A automation/check-merged.repos A automation/check-merged.sh A automation/check-patch.packages A automation/check-patch.repos A automation/check-patch.sh 10 files changed, 241 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I698c9ccf0d32afe8cc3418533b290a1f9fc2d920 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Barak Korren Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: core: rewrite buildSequence using toposort
by didi＠redhat.com 03 Apr '16

03 Apr '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: core: rewrite buildSequence using toposort ...................................................................... core: rewrite buildSequence using toposort Change-Id: I9a7e9a26ac68543331dc869ab151883ac8bd5b30 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/constants.py M src/otopi/context.py 2 files changed, 278 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/28775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a7e9a26ac68543331dc869ab151883ac8bd5b30 Gerrit-PatchSet: 27 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: core: Default to fail on priority overrides
by didi＠redhat.com 03 Apr '16

03 Apr '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: core: Default to fail on priority overrides ...................................................................... core: Default to fail on priority overrides Allow that also by system env var OTOPI_ALLOW_PRIORITY_OVERRIDE. This will break any code in which priority orders were not kept in the final sequence. Change-Id: I1eb4db9b94e87edb3efbe9b49e9ae56609d0e9bd Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/constants.py M src/otopi/context.py 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1eb4db9b94e87edb3efbe9b49e9ae56609d0e9bd Gerrit-PatchSet: 4 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduler: Store correct OS version in map
by mperina＠redhat.com 02 Apr '16

02 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: scheduler: Store correct OS version in map ...................................................................... scheduler: Store correct OS version in map Write the new version into the highest version map. Change-Id: I9594f2f8f8c5d9c7fbeba7b6aff3a77cdc533d14 Bug-Url: https://bugzilla.redhat.com/1241149 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnitTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9594f2f8f8c5d9c7fbeba7b6aff3a77cdc533d14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: don't allow removal of inherited perms via rest
by mperina＠redhat.com 02 Apr '16

02 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: engine: don't allow removal of inherited perms via rest ...................................................................... engine: don't allow removal of inherited perms via rest Previously it was possible to remove inherited permissions from user/group via rest api call. Now we do check at backend if user is trying to remove inherited permissions from user/group and if yes we do not allow it. Change-Id: Ica8610e4cf613629c0fbc0a8d7414598a8bbd899 Bug-Url: https://bugzilla.redhat.com/1302034 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PermissionsOperationsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java 7 files changed, 33 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica8610e4cf613629c0fbc0a8d7414598a8bbd899 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Fix name of method to close element
by juan.hernandez＠redhat.com 01 Apr '16

01 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix name of method to close element ...................................................................... Fix name of method to close element Currently the code generated for XML writers uses in some cases the "XmlWriter.end_element" method, but that method doesn't exist, it should be "write_end". This patch corrects the error. Change-Id: I00a4406ea2bda1b93025d8f3e59837f2990f0466 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00a4406ea2bda1b93025d8f3e59837f2990f0466 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0