- Engine-commits - oVirt List Archives

Change in ovirt-release[master]: The glusterfs key was changed to rsa
by sbonazzo＠redhat.com 21 Mar '16

21 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: The glusterfs key was changed to rsa ...................................................................... The glusterfs key was changed to rsa https://download.gluster.org/pub/gluster/glusterfs/LATEST/NEW_PUBLIC_KEY.RE… Change-Id: If34c154f955dae83b16a69b1e2fedaab62f21c2f Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M ovirt-el7-deps.repo.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If34c154f955dae83b16a69b1e2fedaab62f21c2f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Avoid errors when applying NEXT_RUN snapshot
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Avoid errors when applying NEXT_RUN snapshot ...................................................................... core: Avoid errors when applying NEXT_RUN snapshot * Ignore changes in clusterCompatibilityVersionOrigin. It is not stored in OVF, so will never be changed when a snapshot is applied. * Do not check CPU Profile changing permissons, if cpuProfileId is not changed. Current user is null in ProcessDownVmCommand, so this permission check will always fail. But cpuProfileId is not stored in OVF, so will never be changed when a snapshot is applied and there is no need to check permissions. Change-Id: Ia2fd9ca872ab1c438d5f02a98c55ab91991cb11a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1313369 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified -- To view, visit https://gerrit.ovirt.org/54964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2fd9ca872ab1c438d5f02a98c55ab91991cb11a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Call end action once CopyTaskHandler is finished.
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Call end action once CopyTaskHandler is finished. ...................................................................... core: Call end action once CopyTaskHandler is finished. Call end successfully once glance image if finished to be imported so actual size will be updated properly. Change-Id: I44343b1f49d099fc6febd3907066a35f22ef3a4f Bug-Url: https://bugzilla.redhat.com/1291080 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/54974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44343b1f49d099fc6febd3907066a35f22ef3a4f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Remove index from curly braces
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove index from curly braces ...................................................................... core: Remove index from curly braces This patch removes the index in curley braces. Change-Id: I8d0ef6615d96c3738e2c54fc795abc6530cf4a40 Bug-Url: https://bugzilla.redhat.com/1310615 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/54961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d0ef6615d96c3738e2c54fc795abc6530cf4a40 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: LiveMerge: Remove audit message when delete succeeds
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: LiveMerge: Remove audit message when delete succeeds ...................................................................... core: LiveMerge: Remove audit message when delete succeeds Currently, if live merge succeeds we get an audit message indicating that volume doesn't exist. This hapens during DESTROY_IMAGE_CHECK step where we verify that image removed. In a successful use case, the image is indeed removed hence, we get an audit message alerting that volume doesn't exist. To fix this, we added an option to indicate whether we want to log audit message. Change-Id: I18d190aa05c7f1e404c10b11fd537e92ba77e434 Bug-Url: https://bugzilla.redhat.com/1310615 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DestroyImageCheckCommandTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetVolumeInfoVDSCommand.java 3 files changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/54960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18d190aa05c7f1e404c10b11fd537e92ba77e434 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Remove redundant shouldLogToAudit method
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant shouldLogToAudit method ...................................................................... core: Remove redundant shouldLogToAudit method The shouldLogToAudit method in GetAllVmStatsVDSCommand class is redundant as it has same implementation as its parent class. Change-Id: Ic08ceb464c1787035bd5f3a1b4525c25c2b5c004 Bug-Url: https://bugzilla.redhat.com/1310615 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetAllVmStatsVDSCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/54959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic08ceb464c1787035bd5f3a1b4525c25c2b5c004 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add support for suppressing audit log engine errors
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add support for suppressing audit log engine errors ...................................................................... core: Add support for suppressing audit log engine errors In some use cases an error is expected when invoking a VDSM command. In these cases, the engine should not spam the user with the aforementioned audit log. This patch enables us to provide a set of expected errors when running commands. Change-Id: Id46be151e2fbbdd962b7b9cc2f329bd53ad7a266 Bug-Url: https://bugzilla.redhat.com/1310615 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSParametersBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetAllVmStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java 5 files changed, 34 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/54958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id46be151e2fbbdd962b7b9cc2f329bd53ad7a266 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unregistered disks once an entity gets registered.
by mlipchuk＠redhat.com 21 Mar '16

21 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unregistered disks once an entity gets registered. ...................................................................... core: Remove unregistered disks once an entity gets registered. When registering a VM or a Template that contains unregistered disks, the engine should remove the related unregistered disks from unregistered_disks table Change-Id: I00058094494b8316ac3447c4ff7e6bca0ddccf67 Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/54479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00058094494b8316ac3447c4ff7e6bca0ddccf67 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unregistered disk once it gets registered.
by mlipchuk＠redhat.com 21 Mar '16

21 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unregistered disk once it gets registered. ...................................................................... core: Remove unregistered disk once it gets registered. Once an unregistered disk is being registered, remove the unregistered disk from the unregistered_disks table Change-Id: Id4b0c223d25bb2a7555f3868d5aadf386ea20da3 Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/54480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4b0c223d25bb2a7555f3868d5aadf386ea20da3 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introduce GetUnregisteredDisksFromDBQuery
by mlipchuk＠redhat.com 21 Mar '16

21 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce GetUnregisteredDisksFromDBQuery ...................................................................... core: Introduce GetUnregisteredDisksFromDBQuery Add a vdc query to get all the unregistered disks from unregistered_disks table. Add also a test for the query and a new parameters class to indicate whthere the result should be filtered, in this case it is filtered only for floating disks. Change-Id: I278cade457db259b064bafa6b095199834ca0980 Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksFromDBQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksFromDBQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdAndBooleanQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 147 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/54481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I278cade457db259b064bafa6b095199834ca0980 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0