- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: fix findBugs warning
by gshereme＠redhat.com 20 Mar '16

20 Mar '16

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal: fix findBugs warning ...................................................................... userportal: fix findBugs warning Fix findBugs warning "Possible null pointer dereference of vm in VmStatusColumn.getValue(UserPortalItemModel)". Change-Id: I71b2886f07b776641b90a92b1a4c97a5703733c7 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/54976 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71b2886f07b776641b90a92b1a4c97a5703733c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: plugins: fix pep8 issue
by didi＠redhat.com 20 Mar '16

20 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: plugins: fix pep8 issue ...................................................................... plugins: fix pep8 issue Change-Id: Ib2013dd49a8fa37ba56e9f8af89b0919467df2c5 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/otopi/debug/force_fail/force_fail.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2013dd49a8fa37ba56e9f8af89b0919467df2c5 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove usage of Java 8 Optional
by amureini＠redhat.com 20 Mar '16

20 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove usage of Java 8 Optional ...................................................................... core: Remove usage of Java 8 Optional 'common' module compiles with Java 7 hence, Java 8 features cannot be used. Change-Id: If3c34a35f02b263a0498951d43e428f1dce87e6b Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSParametersBase.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved; Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/54966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3c34a35f02b263a0498951d43e428f1dce87e6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Call end action once CopyTaskHandler is finished.
by mlipchuk＠redhat.com 20 Mar '16

20 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Call end action once CopyTaskHandler is finished. ...................................................................... core: Call end action once CopyTaskHandler is finished. Call end successfully once glance image if finished to be imported so actual size will be updated properly. Change-Id: I44343b1f49d099fc6febd3907066a35f22ef3a4f Bug-Url: https://bugzilla.redhat.com/1291080 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCopyTaskHandler.java 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/54688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44343b1f49d099fc6febd3907066a35f22ef3a4f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Warning for unsupported memory restore (Custom Sna...
by ahadas＠redhat.com 20 Mar '16

20 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: Warning for unsupported memory restore (Custom Snapshot Preview) ...................................................................... webadmin: Warning for unsupported memory restore (Custom Snapshot Preview) The user gets warning message when trying to restore snapshot with memory which was taken in different cluster version (i.e. before upgrade). This patch is relevant to the Custom Snapshot Preview dialog. Change-Id: Id5fc98bd2478195f56fdd00fb1b9b098eef22c8a Bug-Url: https://bugzilla.redhat.com/1292398 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 5 files changed, 49 insertions(+), 34 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Marek Libra: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5fc98bd2478195f56fdd00fb1b9b098eef22c8a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "core: Migration bandwidth columns added to stored pr...
by ahadas＠redhat.com 20 Mar '16

20 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: Revert "core: Migration bandwidth columns added to stored procedures" ...................................................................... Revert "core: Migration bandwidth columns added to stored procedures" This reverts commit 8df05f9348e61f5d4b146d017859083c66b63c74. Change-Id: I2f84d7382134ea65aebdbfe23625e0e59cc8e8e1 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/clusters_sp.sql 1 file changed, 5 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f84d7382134ea65aebdbfe23625e0e59cc8e8e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Check box tooltip
by tnisan＠redhat.com 20 Mar '16

20 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Check box tooltip ...................................................................... webadmin: Check box tooltip - Fixed issue where disabling a checkbox would not enable the tooltip associated with it. - Fixed spelling error. Change-Id: Icab9605c9308086faffc5f7ebcd31ac9e6a67794 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1314181 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54944 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icab9605c9308086faffc5f7ebcd31ac9e6a67794 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Migration bandwidth columns added to stored procedures
by ahadas＠redhat.com 20 Mar '16

20 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Migration bandwidth columns added to stored procedures ...................................................................... core: Migration bandwidth columns added to stored procedures Columns 'migration_bandwidth_limit_type' and 'custom_migration_bandwidth_limit' added to cluster Insert and Update storage procedures. Change-Id: I506050622a248644eb69a48e830231f223dccd96 Bug-Url: https://bugzilla.redhat.com/1252426 Feature-Page: http://www.ovirt.org/Features/Migration_Enhancements Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/dbscripts/clusters_sp.sql 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: Jakub Niedermertl: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I506050622a248644eb69a48e830231f223dccd96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Remove all the log gathering from the system job
by dcaro＠redhat.com 19 Mar '16

19 Mar '16

David Caro has submitted this change and it was merged. Change subject: Remove all the log gathering from the system job ...................................................................... Remove all the log gathering from the system job Now it's the runner script that will gather it as it belongs along the code Change-Id: I6a1047eab78ca2dd6067410606725368f1bf62ba Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/system_tests.collect_logs.sh 1 file changed, 4 insertions(+), 21 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/54956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a1047eab78ca2dd6067410606725368f1bf62ba Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Remove the "kerberos" test tag
by juan.hernandez＠redhat.com 18 Mar '16

18 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Remove the "kerberos" test tag ...................................................................... Remove the "kerberos" test tag This patch temoves the "kerberos" test tag, as all the tests, including the ones that use Kerberos, can run now using the embedded test server. Change-Id: Ic3b32be7b1e63558ad81c1f62c56b650221102ee Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M .gitignore M README.adoc D sdk/spec/clusters_kerberos_service_spec.rb M sdk/spec/connection_create_spec.rb M sdk/spec/spec_helper.rb 5 files changed, 71 insertions(+), 114 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3b32be7b1e63558ad81c1f62c56b650221102ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0