- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix typo
by mlipchuk＠redhat.com 21 Mar '16

21 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix typo ...................................................................... core: Fix typo diskDecription with diskDescription Change-Id: I700dab000148f3aefd1dfd87e20b4f52a2cc0907 Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/54260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I700dab000148f3aefd1dfd87e20b4f52a2cc0907 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: dal: Introduce unregistered disks table.
by mlipchuk＠redhat.com 21 Mar '16

21 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: dal: Introduce unregistered disks table. ...................................................................... dal: Introduce unregistered disks table. Introducing the unregistered disks table for all the disks which are part of the Storage Domain and were not registered yet to the engine. Also introducing functions for different CRUD operations. Change-Id: I1857d3fbef4cacf66c18738e053ba16bec754388 Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/UnregisteredDisk.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredDisksDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredDisksDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredDisksDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/unregistered_disks_sp.sql A packaging/dbscripts/upgrade/04_00_0340_add_unregistered_disks.sql 9 files changed, 803 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/54182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1857d3fbef4cacf66c18738e053ba16bec754388 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add a command for scanning unregistered disks.
by mlipchuk＠redhat.com 21 Mar '16

21 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add a command for scanning unregistered disks. ...................................................................... core: Add a command for scanning unregistered disks. Add a command which scans new unregistered entities from the Storage Domain. Change-Id: Id4f9960afe13c500ebbf4a9aae8d4a5be7c35460 Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ScanStorageForUnregisteredDisksCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ScanStorageForUnregisteredDisksCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 3 files changed, 266 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/54489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4f9960afe13c500ebbf4a9aae8d4a5be7c35460 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update unregistered disks in DB on attach.
by mlipchuk＠redhat.com 21 Mar '16

21 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update unregistered disks in DB on attach. ...................................................................... core: Update unregistered disks in DB on attach. Update the following changes when attaching a Storage Domain: 1. Fetch and store all the unregistered disks from the Storage Domain and filter out all the registered disks in the DB before store those disks in the unregisteredDisks table. 2. Update each unregistered disks with its VMs/Templates it is attached to 3. Add tests for OvfUtils and update existing tests of attach SD. Change-Id: Ib8dd1c484abdc48f0f195af192fe250f5cc28219 Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 6 files changed, 199 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/54390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8dd1c484abdc48f0f195af192fe250f5cc28219 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: spec: Only use vhostmd in RHEL
by fabiand＠redhat.com 21 Mar '16

21 Mar '16

Fabian Deutsch has submitted this change and it was merged. Change subject: spec: Only use vhostmd in RHEL ...................................................................... spec: Only use vhostmd in RHEL Change-Id: I42888fa3661a64edeaf20e162557fe4c6e3e8229 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1314390 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> Reviewed-on: https://gerrit.ovirt.org/54929 Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Continuous-Integration: Douglas Schilling Landgraf <dougsland(a)redhat.com> Tested-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> (cherry picked from commit bc9cd30d41cff2a7d9ba690e488dbafc0c2d492a) Reviewed-on: https://gerrit.ovirt.org/54935 --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/54935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42888fa3661a64edeaf20e162557fe4c6e3e8229 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: FeatureSupported getOrDefault usage
by amureini＠redhat.com 21 Mar '16

21 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: FeatureSupported getOrDefault usage ...................................................................... core: FeatureSupported getOrDefault usage FeatureSupported is in the common module, and as such, it should only use JDK 7 methods (since GWT does not yet support JDK 8 methods, as verified by animal-sniffer). This patch removes the usage of getOrDefault and implements an equivalent logic (under the assumption that the config map may not contain null values) in-place by checking if the value returned from the get method was null or not. Change-Id: Ibb7775796005d8a65f1741e01458589e95f33ac1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb7775796005d8a65f1741e01458589e95f33ac1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove RemoveSnapshotCommand#isContainImages
by amureini＠redhat.com 21 Mar '16

21 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove RemoveSnapshotCommand#isContainImages ...................................................................... core: Remove RemoveSnapshotCommand#isContainImages Removed an unused private method. Change-Id: I5c34a38443833e8941c59f2a827b3358fc81d0c9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c34a38443833e8941c59f2a827b3358fc81d0c9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move CompatibilityVersionUtils to bll
by amureini＠redhat.com 21 Mar '16

21 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Move CompatibilityVersionUtils to bll ...................................................................... core: Move CompatibilityVersionUtils to bll As CompatibilityVersionUtils is only used by the bll module and as it uses JDK classes that shouldn't be allowed in the common (it breaks animal sniffer), bll is the more appropriate place for it. This patch moves it accordingly. Change-Id: I052ff66c54fbb6037cecb11afacbfe45aab3e3dc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/CompatibilityVersionUtils.java 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I052ff66c54fbb6037cecb11afacbfe45aab3e3dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix configuration definition in engine config
by tnisan＠redhat.com 20 Mar '16

20 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix configuration definition in engine config ...................................................................... core: Fix configuration definition in engine config Config value appered as "description.type" instead of ".type" Change-Id: I55440fd15fee3c11c44ef0da7ab0170a53860ba7 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55440fd15fee3c11c44ef0da7ab0170a53860ba7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Avoid errors when applying NEXT_RUN snapshot
by ahadas＠redhat.com 20 Mar '16

20 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Avoid errors when applying NEXT_RUN snapshot ...................................................................... core: Avoid errors when applying NEXT_RUN snapshot * Ignore changes in clusterCompatibilityVersionOrigin. It is not stored in OVF, so will never be changed when a snapshot is applied. * Do not check CPU Profile changing permissons, if cpuProfileId is not changed. Current user is null in ProcessDownVmCommand, so this permission check will always fail. But cpuProfileId is not stored in OVF, so will never be changed when a snapshot is applied and there is no need to check permissions. Change-Id: Ia2fd9ca872ab1c438d5f02a98c55ab91991cb11a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1313369 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2fd9ca872ab1c438d5f02a98c55ab91991cb11a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0