- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: KeysConfig default path constant
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: KeysConfig default path constant ...................................................................... core: KeysConfig default path constant Renamed the constant to a proper upstream name referencing oVirt instead of RHEV. Change-Id: I5ae1bf6bc34ccfbbb07c063cbd9a0ac2800cc21e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/KeysConfig.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/54830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ae1bf6bc34ccfbbb07c063cbd9a0ac2800cc21e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused ConfigValues
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused ConfigValues ...................................................................... core: Remove unused ConfigValues This patch removes ConfigValues that are no longer used by the application. It removes: * Entires in ConfigValues * The corresponding entires in ConfigurationValues * The corresponding entries in engine-config.properties * The corresponding entries from the database * Mocking of these entries in tests Change-Id: I09b6e7133028fa7986f04583cedc453e31e36770 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java A packaging/dbscripts/upgrade/04_00_0330_delete_unused_vdc_options.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 7 files changed, 17 insertions(+), 137 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09b6e7133028fa7986f04583cedc453e31e36770 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Reindex vdc_options after upgrade
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Reindex vdc_options after upgrade ...................................................................... core: Reindex vdc_options after upgrade Once installed in a running system, the vdc_options table is relatively static, with users rarely changing it. However, upgrading the system usually involves a large amount of changes to it (see details below). This makes this table a good candidate for indexing at the end of the upgrade (hence the script is added to the post_upgrade directory). Consider, e.g., upgrading from the latest 3.6 release (i.e., 3.6.3.4, built from commit cb35e8c) to the current master branch (commit 7fe2363, which will eventually be a part of 4.0 when it's released): In 3.6.3, this table had 871 rows. The upgrade to 4.0 deleted 468 of them (~54%) and added 63 new lines (~7%). Reindexing it on my test setup (Postgres 9.4.6 on Fedora 23, with default configurations) reduced the size of the ix_vdc_options index from 80KB to 40KB (50%) and the size of pk_vdc_options, the primary key's index, from 40KB to 32KB (20%). Change-Id: I2fff10b11bf3dafa71f96651ef2cecb491f89a86 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A packaging/dbscripts/upgrade/post_upgrade/0040_reindex_vdc_options.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fff10b11bf3dafa71f96651ef2cecb491f89a86 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove UserMessageOfTheDay ConfigValue
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove UserMessageOfTheDay ConfigValue ...................................................................... core: Remove UserMessageOfTheDay ConfigValue The UserMessageofTheDay ConfigValue is only used by the AsyncDataProvider, in a method which is never called itself. This patch finishes removing this unused method, the ConfValue and the ConfigurationValue associated with it. Change-Id: Id07b2fc650ff03ed9373e018b1f4342dc914bb0b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java A packaging/dbscripts/upgrade/04_00_0320_delete_user_message_of_the_day.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 7 files changed, 1 insertion(+), 22 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id07b2fc650ff03ed9373e018b1f4342dc914bb0b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: push hamcrest down to the root pom.xml
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: build: push hamcrest down to the root pom.xml ...................................................................... build: push hamcrest down to the root pom.xml hamcrest is a basic requirement for unit tests, like junit. This patch removes its dependency from the various pom.xmls it appears in and pushes it down to the root pom.xml, as was done with the other basic testing libraries like junit and mockito. Change-Id: I6728a3b15e90fb3b588c6622811d684eee73cccb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/pom.xml M backend/manager/modules/dal/pom.xml M pom.xml 3 files changed, 6 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6728a3b15e90fb3b588c6622811d684eee73cccb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tools: CriticalSpaceActionBlocker description
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: tools: CriticalSpaceActionBlocker description ...................................................................... tools: CriticalSpaceActionBlocker description Commit 19038bdfa4971ecf969c14e4174b89f2fcd251e5 renamed the CriticalSpaceThreshold ConfigValue to CriticalSpaceActionBlocker, but missed updating its description in engine-config.properties. This patch fixes that mistake. Change-Id: Idf79ea215d524b8d41df3a3463dd706c805febfa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54836 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf79ea215d524b8d41df3a3463dd706c805febfa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Cleanup engine-config.properties
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Cleanup engine-config.properties ...................................................................... core: Cleanup engine-config.properties engine-config.properties should represent a subset of ConfigValues users are able to control easily. Several careless patches have left obsolete references in it that do not represent valid config values any more and just confuse users. This patch removes these obsolete entries and introduces a unit test which evaluates packaging/etc/engine-config/engine-config.properties against the ConfigValues enum to ensure such mistakes don't happen again. Change-Id: I75f30d45e80bb3c8918a16148523b1e405185abc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/pom.xml A backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigPropertiesTest.java M packaging/etc/engine-config/engine-config.properties 3 files changed, 54 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75f30d45e80bb3c8918a16148523b1e405185abc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove InitStorageSparseSizeInGB ConfigValue
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove InitStorageSparseSizeInGB ConfigValue ...................................................................... core: Remove InitStorageSparseSizeInGB ConfigValue The InitStorageSparseSizeInGB ConfigValue is pointless, as the size property of the disk already takes this into account. It has been removed from production code throughout the codebase (although, surprisingly, it was not removed from the tests), and only appears mistakenly in the quote calculation of creating a new pool, where it has no effect anyway, as its value is 1 and it's used in multiplication. This patch finishes the job and removes all trace of this redundant config value Change-Id: I4358a78a88898fc93b095becc883dec5d066246e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java A packaging/dbscripts/upgrade/04_00_0310_delete_init_storage_sparse_size_in_gb.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 6 files changed, 2 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4358a78a88898fc93b095becc883dec5d066246e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused ConfigurationValues
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused ConfigurationValues ...................................................................... core: Remove unused ConfigurationValues ConfigurationValues are a subset of the ConfigValues exposed to the various frontend applications. This patch removes such values that were either added by mistake or neglected while refactoring/updating the frontend code in a way they are no longer used by it. Change-Id: If905cbe85a8c6d5dca4b49f6da1e4d616def3fdf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 1 file changed, 0 insertions(+), 43 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If905cbe85a8c6d5dca4b49f6da1e4d616def3fdf Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added github publisher to startand-ci github
by dcaro＠redhat.com 17 Mar '16

17 Mar '16

David Caro has submitted this change and it was merged. Change subject: Added github publisher to startand-ci github ...................................................................... Added github publisher to startand-ci github Change-Id: I8c8741d6721e708b5e717e9b969abbb96b99a6a1 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/yaml/templates/standard-stage.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/54880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c8741d6721e708b5e717e9b969abbb96b99a6a1 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0