- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove wrong code in AddVmFromScratchCommand
by tnisan＠redhat.com 17 Mar '16

17 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove wrong code in AddVmFromScratchCommand ...................................................................... core: Remove wrong code in AddVmFromScratchCommand AddVmFromScratchCommand is called in all flows when a VM is created with a blank template, in the case the VM cannot have disks to be created thus the logic within addVmImages is incorreect and removed Change-Id: I932ac5744deda45360c26db6d15afe8d485e7229 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java 1 file changed, 1 insertion(+), 49 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I932ac5744deda45360c26db6d15afe8d485e7229 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: github:Fixed unwanted triggers by quoted messages
by dcaro＠redhat.com 17 Mar '16

17 Mar '16

David Caro has submitted this change and it was merged. Change subject: github:Fixed unwanted triggers by quoted messages ...................................................................... github:Fixed unwanted triggers by quoted messages That usually happens on email responses Change-Id: I8a7ca86397c1cf68a8728730c2d2a7cecdffa8e0 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/yaml/triggers/github.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/54843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a7ca86397c1cf68a8728730c2d2a7cecdffa8e0 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: storage: provide a more informative message on not enough space
by sbonazzo＠redhat.com 17 Mar '16

17 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: provide a more informative message on not enough space ...................................................................... storage: provide a more informative message on not enough space Provide a more informative message if there is not enough free space on the storage domain. Change-Id: Icf640f25c7c891ea9471c4fdb7df103c7b82212a Bug-Url: https://bugzilla.redhat.com/1306573 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/image.py 1 file changed, 12 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf640f25c7c891ea9471c4fdb7df103c7b82212a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: tool: let the user pass a custom vm.conf
by sbonazzo＠redhat.com 17 Mar '16

17 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: tool: let the user pass a custom vm.conf ...................................................................... tool: let the user pass a custom vm.conf Since 3.6.z the user will be able to edit the engine VM configuration from the engine. This could lead to an issue if the new configuration will prevent the engine VM to start since in order to edit it again the user needs the engine. Passing an alternative vm.conf from CLI the user could be able to temporary amend what was wrong in the master configuration on the shared storage in order to be able to start again the engine VM and definitively fix it. Change-Id: Id0bd98648600872ea8145c1ad90cab3264b430a9 Bug-Url: https://bugzilla.redhat.com/1309572 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M man/hosted-engine.8 M src/bin/hosted-engine.in 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54814 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0bd98648600872ea8145c1ad90cab3264b430a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: packaging: spec: reintorduced non-maven build
by didi＠redhat.com 17 Mar '16

17 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: packaging: spec: reintorduced non-maven build ...................................................................... packaging: spec: reintorduced non-maven build re-introduced non-maven build support for building on systems without maven. Change-Id: Ia03cffb366114e54164c55e61670d9b20e1dbe74 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M otopi.spec.in 1 file changed, 54 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia03cffb366114e54164c55e61670d9b20e1dbe74 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: packaging: setup: use shared code from ovirt_setup_lib
by Shirly Radco 17 Mar '16

17 Mar '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: use shared code from ovirt_setup_lib ...................................................................... packaging: setup: use shared code from ovirt_setup_lib Change-Id: I543626dcfdaefcfe3097289ac4a18fc17afab917 Bug-Url: https://bugzilla.redhat.com/1316471 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine-reports.spec.in M packaging/services/ovirt-engine-reportsd/ovirt-engine-reportsd.py M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/ovirt_engine_setup/reports/reportsutil.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/config/admin.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/config/jasper.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/misc.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/protocols.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/service.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/config.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/pgpass.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/core/service.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/db/clear.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/jasper/clear.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine-reports/engine.py M packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/core/actions.py M packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/core/misc.py M packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/jasper/change_admin_password.py M packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/jasper/export_saved_reports.py M packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/jasper/import_saved_reports.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/apache/reports.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/admin.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/database.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/firewall.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jasper.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/java.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/protocols.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/sso.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/core/service.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/provisioning/postgres.py 40 files changed, 38 insertions(+), 128 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/54686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I543626dcfdaefcfe3097289ac4a18fc17afab917 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: i18n: updated pt_BR
by sbonazzo＠redhat.com 17 Mar '16

17 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: i18n: updated pt_BR ...................................................................... i18n: updated pt_BR Change-Id: Ided94bc8de4c096cb007d1f4af6aed3fcace6aa1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M po/pt_BR.po 1 file changed, 44 insertions(+), 37 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ided94bc8de4c096cb007d1f4af6aed3fcace6aa1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: packaging: spec: reintorduced non-maven build
by sbonazzo＠redhat.com 17 Mar '16

17 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: reintorduced non-maven build ...................................................................... packaging: spec: reintorduced non-maven build re-introduced non-maven build support for building on systems without maven. Change-Id: I056a9631a157dc71451257d153b4fa1a7eb24f53 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-host-deploy.spec.in 1 file changed, 48 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I056a9631a157dc71451257d153b4fa1a7eb24f53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use Java 8 streams API
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Use Java 8 streams API ...................................................................... engine: Use Java 8 streams API Use Java 8 streams API to make the code more readable. In addition, this patch addresses Coverty CID 1352153. Change-Id: Idf4370cd7a0dd35083c2ef1ffd71de2ce45c9ddc Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java 1 file changed, 6 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved; Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/54705 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf4370cd7a0dd35083c2ef1ffd71de2ce45c9ddc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: LiveMerge: Remove audit message when delete succeeds
by amureini＠redhat.com 17 Mar '16

17 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: LiveMerge: Remove audit message when delete succeeds ...................................................................... core: LiveMerge: Remove audit message when delete succeeds Currently, if live merge succeeds we get an audit message indicating that volume doesn't exist. This hapens during DESTROY_IMAGE_CHECK step where we verify that image removed. In a successful use case, the image is indeed removed hence, we get an audit message alerting that volume doesn't exist. To fix this, we added an option to indicate whether we want to log audit message. Change-Id: I18d190aa05c7f1e404c10b11fd537e92ba77e434 Bug-Url: https://bugzilla.redhat.com/1310615 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DestroyImageCheckCommandTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetVolumeInfoVDSCommand.java 3 files changed, 4 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved; Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/53864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18d190aa05c7f1e404c10b11fd537e92ba77e434 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0