- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: LiveMigrateDiskCommand - shared locks are unneeded
by tnisan＠redhat.com 16 Mar '16

16 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: LiveMigrateDiskCommand - shared locks are unneeded ...................................................................... core: LiveMigrateDiskCommand - shared locks are unneeded Shared locks are not needed on LiveMigrateDiskCommand as they are already added by LiveMigrateVmDisksCommand. Change-Id: I31065f76ba5ef866bf968f03f76446ea1041b4ab Bug-Url: https://bugzilla.redhat.com/1313744 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31065f76ba5ef866bf968f03f76446ea1041b4ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix assigning permission to group
by mperina＠redhat.com 16 Mar '16

16 Mar '16

Martin Peřina has submitted this change and it was merged. Change subject: webadmin: Fix assigning permission to group ...................................................................... webadmin: Fix assigning permission to group Patch I5b1750301a48c874f979f91ce7680b610ba03516 introduces split views of users or groups when assigning permissions. Unfortunately current GWT representation of users and groups is very broken as we use DbUser class to represent both users and groups. That led to unfortunate decission to map group's Display Name to loginName attribute and this mapping broke method isGroup() which uses loginName to distinguish between user or group (another very broken design), which led to an error during assigning permissions to a group. This flow didn't insert group into ad_groups table, which means that this permission is not loaded on user login. This patch fixes assignment of a permission to a group by using DbUser attribute note (which is not used otherwise) instead of loginName (it's a hack, but at least it doesn't break existing functionality). Change-Id: I12bc5b0d158d2572883ef8baa65f0aca856ed0a8 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12bc5b0d158d2572883ef8baa65f0aca856ed0a8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: ignore CpuProfileOperator for everyone
by tjelinek＠redhat.com 16 Mar '16

16 Mar '16

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: ignore CpuProfileOperator for everyone ...................................................................... userportal: ignore CpuProfileOperator for everyone The CpuProfileOperator on everyone made everyone see the power user portal. This adds also this role to be ignored. Change-Id: I4fff54bed5fe0b7550e55872dca1d5997c05ef4a Bug-Url: https://bugzilla.redhat.com/1316849 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/auth/ApplicationGuids.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54654 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fff54bed5fe0b7550e55872dca1d5997c05ef4a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Prevent of recursion loop in flat groups
by mperina＠redhat.com 16 Mar '16

16 Mar '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Prevent of recursion loop in flat groups ...................................................................... aaa: Prevent of recursion loop in flat groups Change-Id: I6fc143c62d67febf010cbd0ec71d5f87bea4b25e Bug-Url: https://bugzilla.redhat.com/1301345 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java 2 files changed, 36 insertions(+), 18 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fc143c62d67febf010cbd0ec71d5f87bea4b25e Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Updating to the new syntax of artifacts keeping in jjb
by tlitovsk＠redhat.com 16 Mar '16

16 Mar '16

Anatoly Litovsky has submitted this change and it was merged. Change subject: Updating to the new syntax of artifacts keeping in jjb ...................................................................... Updating to the new syntax of artifacts keeping in jjb Change-Id: I4b8d0e86bcf6d5f2fb30e35ffd451b20b9e6f677 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/yaml/templates/ovirt-node-job-templates.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Anatoly Litovsky: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/54789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b8d0e86bcf6d5f2fb30e35ffd451b20b9e6f677 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Fix JSON serialization of cyclic nested groups
by mperina＠redhat.com 16 Mar '16

16 Mar '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Fix JSON serialization of cyclic nested groups ...................................................................... aaa: Fix JSON serialization of cyclic nested groups Fixes JSON serialization/deserialization of user's group memberhips where nested group memberships could contain cyclic references and Jackson is not able to handle them. Change-Id: I6addda680f4cfae351047764f23fb67da31ee077 Bug-Url: https://bugzilla.redhat.com/1301345 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SSOOAuthServiceUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java 2 files changed, 102 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54673 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6addda680f4cfae351047764f23fb67da31ee077 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Provisioning of VMs created from Templates tab fix
by tjelinek＠redhat.com 16 Mar '16

16 Mar '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Provisioning of VMs created from Templates tab fix ...................................................................... core: Provisioning of VMs created from Templates tab fix Previously when VM was create from Templates tab ("New VM"), its type was Desktop and "Optimized for" listbox was not touched in "New Virtual Machine" dialog then the VM was created with disk provisioning "Clone" which corresponds to vm type "Server". It could be workaround by selecting "Server" and "Desktop" option back again in "Optimized for" listbox. This patch fixes that so VMs optimized for Desktop created from Templates tab withoud touching "Optimized for" are correctly provisioned - Thin. Bug-Url: https://bugzilla.redhat.com/1309221 Change-Id: I7d3a3b3afbc933135121f6bd02ca3fe665edfdad Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d3a3b3afbc933135121f6bd02ca3fe665edfdad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix collection type in CreateUserSessionParameters
by mperina＠redhat.com 16 Mar '16

16 Mar '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Fix collection type in CreateUserSessionParameters ...................................................................... core: Fix collection type in CreateUserSessionParameters Unfortunately ExtMap type defined in extensions API cannot be easily included into our GWT build infrastructure, so groups, that user is a member of (represented as Collection<ExtMap>), are incorrectly defined as Collection<Map> in CreateUserSessionParameters. This patch corrects the definition to Collection<? extends Map> as ExtMap is indirect ancestor of Map. Change-Id: I935d4aa7867c11335cdaf1bfbe95e3c10f160bf4 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SSOUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateUserSessionParameters.java 4 files changed, 14 insertions(+), 13 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I935d4aa7867c11335cdaf1bfbe95e3c10f160bf4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6.4_rc1
by sbonazzo＠redhat.com 16 Mar '16

16 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6.4_rc1 ...................................................................... build: ovirt-live-3.6.4_rc1 Change-Id: Ie5fc2261ce76abe7a547a4fb0f09d52001a20de2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5fc2261ce76abe7a547a4fb0f09d52001a20de2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: aaa: Don't assume that Collection is a List type
by mperina＠redhat.com 16 Mar '16

16 Mar '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Don't assume that Collection is a List type ...................................................................... aaa: Don't assume that Collection is a List type Fixes wrong assumption that Collection type returned from extension call have to be a List. Change-Id: If09592963214d5e24ab5328e9d65e2f6924b9fca Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SSOUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryUserByPrincipalQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryUserByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateUserSessionParameters.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenInfoServlet.java 11 files changed, 27 insertions(+), 27 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If09592963214d5e24ab5328e9d65e2f6924b9fca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0