- Engine-commits - oVirt List Archives

Change in jenkins[master]: Fixed retention strategi
by dcaro＠redhat.com 28 Jan '16

28 Jan '16

David Caro has submitted this change and it was merged. Change subject: Fixed retention strategi ...................................................................... Fixed retention strategi The latest update changed the way the xml looks and made all the retention strategies empty, filling up the disk... This needs the custom jjb that has the fix (1.4.1.dev50.ovirt) Change-Id: I773be36b6b0f0b2d56ce03f9faddfc2ce10aaaca Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/defaults.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.5.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml M jobs/confs/yaml/templates/install-rpm-sanity.yaml M jobs/confs/yaml/templates/ovirt-node-job-templates.yaml M jobs/confs/yaml/templates/standard-stage.yaml 8 files changed, 55 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/52872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I773be36b6b0f0b2d56ce03f9faddfc2ce10aaaca Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: Reimplement PKIResources.Resource as class
by piotr.kliczewski＠gmail.com 28 Jan '16

28 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Reimplement PKIResources.Resource as class ...................................................................... core: Reimplement PKIResources.Resource as class PKIResources.Resource was implemented as enum, but we used Config value as a parameter for enum constructor. This caused troubles because enum constructor was called during class loading but Config values are initialized during Backend EJB initialization, so if some called PKIResourceServlet to get certificate before Backend was initialized, enum was initialized incorrectly and servlet returned error until JBoss instance was restarted. 1. Connection refused - before JBoss instance starts up 2. 404 Not Found - JBoss instance is up, but engine application is not yet deployed 3. 500 Internal Server Error - in server log there's our custom message describing that certificate is not available yet as engine startup hasn't been finished yet 4. Success, certificate returned - JBoss instance is up, engine application fisnished initialization Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Bug-Url: https://bugzilla.redhat.com/1294025 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployPKIUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployVmconsoleUnit.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 6 files changed, 71 insertions(+), 19 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52870 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Reimplement PKIResources.Resource as class
by piotr.kliczewski＠gmail.com 28 Jan '16

28 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Reimplement PKIResources.Resource as class ...................................................................... core: Reimplement PKIResources.Resource as class PKIResources.Resource was implemented as enum, but we used Config value as a parameter for enum constructor. This caused troubles because enum constructor was called during class loading but Config values are initialized during Backend EJB initialization, so if some called PKIResourceServlet to get certificate before Backend was initialized, enum was initialized incorrectly and servlet returned error until JBoss instance was restarted. 1. Connection refused - before JBoss instance starts up 2. 404 Not Found - JBoss instance is up, but engine application is not yet deployed 3. 500 Internal Server Error - in server log there's our custom message describing that certificate is not available yet as engine startup hasn't been finished yet 4. Success, certificate returned - JBoss instance is up, engine application fisnished initialization Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Bug-Url: https://bugzilla.redhat.com/1294025 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployPKIUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployVmconsoleUnit.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 6 files changed, 71 insertions(+), 19 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: new pool dialog contained the sub version field
by tnisan＠redhat.com 28 Jan '16

28 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: new pool dialog contained the sub version field ...................................................................... webadmin: new pool dialog contained the sub version field The sub version field is from the template dialog - it should not be present in the new pool dialog. Change-Id: I36188c0e666377ea076caea1966004a47632f338 Bug-Url: https://bugzilla.redhat.com/1302372 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36188c0e666377ea076caea1966004a47632f338 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Consistent relation memory - guaranteed memory
by tjelinek＠redhat.com 28 Jan '16

28 Jan '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Consistent relation memory - guaranteed memory ...................................................................... webadmin: Consistent relation memory - guaranteed memory * Null checks added * If value of 'System' > 'Memory Size' is changed, value of 'Resource allocation' > 'Physical Memory Guaranteed' is set to (memory size / cluster over-commitment factor) for following dialogs: * New/Edit VM * New Pool * Values 'Memory Size' and 'Physical Memory Guaranteed' are not connected for dialogs: * New/Edit Template * New/Edit Instance Type Change-Id: I2c1d257b6edc81964272474510afd004248b9e39 Bug-Url: https://bugzilla.redhat.com/1302582 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewInstanceTypeModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NonClusterModelBehaviorBase.java 8 files changed, 16 insertions(+), 28 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c1d257b6edc81964272474510afd004248b9e39 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Reimplement PKIResources.Resource as class
by mperina＠redhat.com 28 Jan '16

28 Jan '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Reimplement PKIResources.Resource as class ...................................................................... core: Reimplement PKIResources.Resource as class PKIResources.Resource was implemented as enum, but we used Config value as a parameter for enum constructor. This caused troubles because enum constructor was called during class loading but Config values are initialized during Backend EJB initialization, so if some called PKIResourceServlet to get certificate before Backend was initialized, enum was initialized incorrectly and servlet returned error until JBoss instance was restarted. 1. Connection refused - before JBoss instance starts up 2. 404 Not Found - JBoss instance is up, but engine application is not yet deployed 3. 500 Internal Server Error - in server log there's our custom message describing that certificate is not available yet as engine startup hasn't been finished yet 4. Success, certificate returned - JBoss instance is up, engine application fisnished initialization Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Bug-Url: https://bugzilla.redhat.com/1294025 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployPKIUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployVmconsoleUnit.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 6 files changed, 71 insertions(+), 19 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Uninitialized host fails to open hardware tab
by tnisan＠redhat.com 28 Jan '16

28 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Uninitialized host fails to open hardware tab ...................................................................... webadmin: Uninitialized host fails to open hardware tab When hardware sub-tab is selected for uninitialized host, a NPE is thrown since the HBA collection is null. In addition, the HostGeneralModel.oupdateAlerts() will be the only place where alerts are being handled. Change-Id: I759e49a0418c9a0c21e917b153d4c1ef4c877911 Bug-Url: https://bugzilla.redhat.com/1293574 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 3 files changed, 2 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/52855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759e49a0418c9a0c21e917b153d4c1ef4c877911 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: stateless vms monitoring - vmManagers
by ahadas＠redhat.com 28 Jan '16

28 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: stateless vms monitoring - vmManagers ...................................................................... core: stateless vms monitoring - vmManagers As part of the effort to make VmsMonitoring stateless, the managers of the monitored VMs are now fetched using the VM analyzers instead of holding them as a member of VmsMonitoring. Change-Id: Ic7f60c810db6f8a37353c732a452e5b151b7c5b7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 3 files changed, 18 insertions(+), 25 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/52816 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f60c810db6f8a37353c732a452e5b151b7c5b7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: CreateSnapshot - add parameters ctor
by tnisan＠redhat.com 28 Jan '16

28 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CreateSnapshot - add parameters ctor ...................................................................... core: CreateSnapshot - add parameters ctor Change Iaae93b7e6b041749c4911806bfdb78fa4afe166c add missing ctors to the relevant commands, CreateSnapshot was missing from that patch - this patch adds the ctor to that command as well. Change-Id: I54effa540931d68c67b0f5928a4cf3ad343dc5ba Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1300757 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/52854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54effa540931d68c67b0f5928a4cf3ad343dc5ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Uninitialized host fails to open hardware tab
by masayag＠redhat.com 28 Jan '16

28 Jan '16

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Uninitialized host fails to open hardware tab ...................................................................... webadmin: Uninitialized host fails to open hardware tab When hardware sub-tab is selected for uninitialized host, a NPE is thrown since the HBA collection is null. In addition, the HostGeneralModel.oupdateAlerts() will be the only place where alerts are being handled. Change-Id: I759e49a0418c9a0c21e917b153d4c1ef4c877911 Bug-Url: https://bugzilla.redhat.com/1293574 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 3 files changed, 2 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/52852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759e49a0418c9a0c21e917b153d4c1ef4c877911 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0