- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: GlusterGeoRepUtil lambdas
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterGeoRepUtil lambdas ...................................................................... core: GlusterGeoRepUtil lambdas Modernized the syntax and reduced code bloating by replacing explicit implementations of java.util.function.Predicate with neater inline lambda expressions. Change-Id: I4fa9aeaa99965b71344bc5e783030f63d3146154 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java 1 file changed, 25 insertions(+), 62 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fa9aeaa99965b71344bc5e783030f63d3146154 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterGeoRepUtil predicates
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterGeoRepUtil predicates ...................................................................... core: GlusterGeoRepUtil predicates Replaced the usage of org.ovirt.engine.core.utils.linq.Predicate with the modern java.util.function.Predicate. This patch is a minimalistic in-place replacement of two similar interfaces. Following patches will update, clean up and modernize the code where possible. Change-Id: I83101d123e74b21afa6cf7f76b1d1e05294fc423 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java 3 files changed, 16 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved anmolbabu: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83101d123e74b21afa6cf7f76b1d1e05294fc423 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: rm getNonEligibilityReasonsForSlaveVolume1()
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm getNonEligibilityReasonsForSlaveVolume1() ...................................................................... core: rm getNonEligibilityReasonsForSlaveVolume1() This method just returns an empty ArrayList, and was only used to assert against. Removing it and asserting that various lists are empty makes the code much cleaner and easier to understand. Change-Id: If077e5074c9630f6a8ace24b092902b309ddcc87 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQueryTest.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If077e5074c9630f6a8ace24b092902b309ddcc87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetNonEligibilityReasonsOfVolumeForGeoRepSessionQueryT...
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetNonEligibilityReasonsOfVolumeForGeoRepSessionQueryTest generics ...................................................................... core: GetNonEligibilityReasonsOfVolumeForGeoRepSessionQueryTest generics Replace the cumbersome generic specification with the more readable Java 7 diamond operator. Change-Id: I8435ab397ab762673744333c19e4e02e1f769b4f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQueryTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8435ab397ab762673744333c19e4e02e1f769b4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Test GetGlusterGeoReplicationEligibleVolumesQuery#getE...
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Test GetGlusterGeoReplicationEligibleVolumesQuery#getEligibleVolumes ...................................................................... core: Test GetGlusterGeoReplicationEligibleVolumesQuery#getEligibleVolumes Enhanced GetGlusterGeoReplicationEligibleVolumesQueryTest so that getEligibleVolumes is also tested, as it has some non-trivial logic. This is done in order to facilitate the refactoring of this method. Change-Id: Ifee0119d1ee0d26cac0543f870e3d7fa44a12672 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQueryTest.java 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved anmolbabu: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifee0119d1ee0d26cac0543f870e3d7fa44a12672 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: getEligibleVolumes performance
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: getEligibleVolumes performance ...................................................................... core: getEligibleVolumes performance getEligibleVolumes traverses a list of GlusterVolumeEntitys and filters it by a different predicate in each pass, resulting in a list of GlusterVolumeEntitys that pass all the predicates. This patch improves this method's performance by unifying all the predicates to a single predicate using Predicate::and and then uses it to filter the list. This change offers a slight performance improvement as it saves the need to collect the results into a different list each iteration. Change-Id: I18b691366e4588263dcb99fe18d644f751458e69 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18b691366e4588263dcb99fe18d644f751458e69 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: getEligibleVolumes map iteration
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: getEligibleVolumes map iteration ...................................................................... core: getEligibleVolumes map iteration Replace the entrySet() iteration with an iteration over the values(), since the key is never used, and it just makes the code more complicated to understand. Change-Id: I445c92072238776d33cc805346d04fef2a8a5cdc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I445c92072238776d33cc805346d04fef2a8a5cdc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterGeoRepUtil#getSessionSlaveVolumeIds
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterGeoRepUtil#getSessionSlaveVolumeIds ...................................................................... core: GlusterGeoRepUtil#getSessionSlaveVolumeIds Simplified the method by using the modern Java 8 collect approach instead of coding the transformation in the method. Change-Id: I9b092cf47fd7e062bfb6a780f01a930f81f65de4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b092cf47fd7e062bfb6a780f01a930f81f65de4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetGlusterGeoReplicationEligibleVolumesQueryTest generics
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetGlusterGeoReplicationEligibleVolumesQueryTest generics ...................................................................... core: GetGlusterGeoReplicationEligibleVolumesQueryTest generics Used Java 7's diamond generics to improve the code's readability. Change-Id: I5b237a2860cd7633313daa60334391a5f0a15195 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b237a2860cd7633313daa60334391a5f0a15195 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetGlusterGeoReplicationEligibleVolumesQueryTest casts
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetGlusterGeoReplicationEligibleVolumesQueryTest casts ...................................................................... core: GetGlusterGeoReplicationEligibleVolumesQueryTest casts Removed redundant cast. Change-Id: Ie3f842044d667d4f43015ad6eb9db2d81d125d02 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQueryTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3f842044d667d4f43015ad6eb9db2d81d125d02 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0