- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core, frontend: allow spice+vnc only on 3.6+ cluster
by tnisan＠redhat.com 30 Nov '15

30 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core,frontend: allow spice+vnc only on 3.6+ cluster ...................................................................... core,frontend: allow spice+vnc only on 3.6+ cluster Changes: - do not add the SPICE+VNC option to the dialogs if not allowed - check on add/edit if more than one graphics are allowed - check on add new graphics device if it can be added Change-Id: I4a52ae9f5525578e641e1d039fda048b1f447595 Bug-Url: https://bugzilla.redhat.com/1279524 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsDeviceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 14 files changed, 52 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a52ae9f5525578e641e1d039fda048b1f447595 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: pki: Do not fail if pkcs12 unreadable
by sbonazzo＠redhat.com 30 Nov '15

30 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: pki: Do not fail if pkcs12 unreadable ...................................................................... packaging: setup: pki: Do not fail if pkcs12 unreadable During upgrade, we check several pkcs12 files to see if they expired or are close to expire. Do not fail upgrade if we failed to read them. This can happen e.g. if some of them were replaced with ones signed by a 3rd party CA, changed their passphrase, etc. Change-Id: Ibe88e38b073433a357ee7ac09f6ead159e22baa4 Bug-Url: https://bugzilla.redhat.com/1260752 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 30 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/49172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe88e38b073433a357ee7ac09f6ead159e22baa4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: set VirtIO type if profile is not passthrough enab...
by alkaplan＠redhat.com 30 Nov '15

30 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: set VirtIO type if profile is not passthrough enabled. ...................................................................... webadmin: set VirtIO type if profile is not passthrough enabled. Change-Id: I12a0212c0630e3c44f90fba091e6939877c94afd Bug-Url: https://bugzilla.redhat.com/1285696 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 3 files changed, 16 insertions(+), 8 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12a0212c0630e3c44f90fba091e6939877c94afd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: change 'SSH Port' to 'Port' in PM dialog
by masayag＠redhat.com 29 Nov '15

29 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: change 'SSH Port' to 'Port' in PM dialog ...................................................................... core: change 'SSH Port' to 'Port' in PM dialog Changing 'SSH Port' to 'Port' in PM dialog since not all ports are SSH ports and the term 'Port' is more general and matches all PM agents. Change-Id: I8220adb1da68edddd18a801e2deaf6dafbc2bb87 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280309 Signed-off-by: emesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8220adb1da68edddd18a801e2deaf6dafbc2bb87 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: resolve Coverity issue 1229033
by masayag＠redhat.com 29 Nov '15

29 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: resolve Coverity issue 1229033 ...................................................................... core: resolve Coverity issue 1229033 Prevent race conditions and replace active flag with standard lock mechanism Change-Id: I9ffc58a133dc575d247e781fe9ad4ad2e59b262b Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java 1 file changed, 12 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ffc58a133dc575d247e781fe9ad4ad2e59b262b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: resolve Coverityy issue 1294817
by masayag＠redhat.com 29 Nov '15

29 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: resolve Coverityy issue 1294817 ...................................................................... core: resolve Coverityy issue 1294817 Prevent race conditions and replace active flag with standard lock mechanism Change-Id: I938affa7863f903001679fbc634371df00190306 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java 1 file changed, 8 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I938affa7863f903001679fbc634371df00190306 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: explicit cast from Object to boolean
by ahadas＠redhat.com 29 Nov '15

29 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: core: explicit cast from Object to boolean ...................................................................... core: explicit cast from Object to boolean Some compailers complain on implicit cast from Object to boolean, thus replacing it with explicit cast. Change-Id: Ib2f3ec27b276b04bba2adcf9be49091edf00dcba Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/49362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2f3ec27b276b04bba2adcf9be49091edf00dcba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in ImportVmCommand
by ahadas＠redhat.com 29 Nov '15

29 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in ImportVmCommand ...................................................................... core: cleanup in ImportVmCommand ImportVmCommand does not need to implement TaskHandlerCommand, therefore changing it. Change-Id: I16916d2dd4673c3ecb583d3f3e1c5d0a7ed3579f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 1 insertion(+), 65 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/49369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16916d2dd4673c3ecb583d3f3e1c5d0a7ed3579f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Audit log importing of hosted engine domain
by rgolan＠redhat.com 29 Nov '15

29 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: core: Audit log importing of hosted engine domain ...................................................................... core: Audit log importing of hosted engine domain Change-Id: Idf3ec89b73824c6078979d94bae46cd204c93f6d Bug-Url: https://bugzilla.redhat.com1269768 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 12 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf3ec89b73824c6078979d94bae46cd204c93f6d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: reports: fix problem with chinese translations
by sradco＠redhat.com 29 Nov '15

29 Nov '15

Shirly Radco has submitted this change and it was merged. Change subject: reports: fix problem with chinese translations ...................................................................... reports: fix problem with chinese translations Fix broken chinese translations in ad hoc reports by adding full width parantheses to the validatore Change-Id: I863dceb83cd2e5a0c7dc4743dfbfcccdf7c5a778 Bug-Url: https://bugzilla.redhat.com/1211052 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- A packaging/jasper-war-patches/pro/200_010_web-inf-allow-full-width-parentheses.patch 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I863dceb83cd2e5a0c7dc4743dfbfcccdf7c5a778 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0