- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VdsSpmIdMap naming conventions
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: VdsSpmIdMap naming conventions ...................................................................... core: VdsSpmIdMap naming conventions Renamed vds_spm_id_map to use the proper Java naming convention, VdsSpmIdMap. Member, parameter and local variable names were amended accordingly. Change-Id: Ida163cc4d3ffec991e3e025c651b8aa0f023c212 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsSpmIdMap.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vds_spm_id_map.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsSpmIdMapDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsSpmIdMapDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsSpmIdMapDaoTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 11 files changed, 130 insertions(+), 135 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49190 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida163cc4d3ffec991e3e025c651b8aa0f023c212 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: core, restapi: fixed potential NPE and removed duplicity
by tnisan＠redhat.com 30 Nov '15

30 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core,restapi: fixed potential NPE and removed duplicity ...................................................................... core,restapi: fixed potential NPE and removed duplicity Change-Id: Ia913e0f2069fa63b07be3f640600c1867406eda7 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java 2 files changed, 2 insertions(+), 6 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia913e0f2069fa63b07be3f640600c1867406eda7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: when switching macPool assigned to DC, MACs has to be ...
by tnisan＠redhat.com 30 Nov '15

30 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: when switching macPool assigned to DC, MACs has to be moved between pools. ...................................................................... core: when switching macPool assigned to DC, MACs has to be moved between pools. When new mac pool is different from old mac pool, all mac addresses of NICs belonging to this DC has to be released from old mac pool and added to new one. Change-Id: I1a14c49c3af8e7a4268b40f52bba9767c05120cf Bug-Url: https://bugzilla.redhat.com/1269846 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDc.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 2 files changed, 64 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a14c49c3af8e7a4268b40f52bba9767c05120cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: set VirtIO type if profile is not passthrough enab...
by tnisan＠redhat.com 30 Nov '15

30 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: set VirtIO type if profile is not passthrough enabled. ...................................................................... webadmin: set VirtIO type if profile is not passthrough enabled. Change-Id: I12a0212c0630e3c44f90fba091e6939877c94afd Bug-Url: https://bugzilla.redhat.com/1285696 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 3 files changed, 16 insertions(+), 8 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12a0212c0630e3c44f90fba091e6939877c94afd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: update network status only if there's at least one hos...
by alkaplan＠redhat.com 30 Nov '15

30 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: update network status only if there's at least one host with up status ...................................................................... core: update network status only if there's at least one host with up status Change-Id: Id45135af63e7cf11ffbc22292139fdcc12b3f7dc Bug-Url: https://bugzilla.redhat.com/1250063 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java 1 file changed, 90 insertions(+), 40 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id45135af63e7cf11ffbc22292139fdcc12b3f7dc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: change "vf" to "virtualfunction"
by juan.hernandez＠redhat.com 30 Nov '15

30 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: change "vf" to "virtualfunction" ...................................................................... restapi: change "vf" to "virtualfunction" Change "vf" to "virtualfunction" Change-Id: I85ce1e4d07c8dc4808b15eb37a9174eb3c9cb02e Bug-Url: https://bugzilla.redhat.com/1286427 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/49382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85ce1e4d07c8dc4808b15eb37a9174eb3c9cb02e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: setup: raise after VDSM re-start timeout
by sbonazzo＠redhat.com 30 Nov '15

30 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: raise after VDSM re-start timeout ...................................................................... setup: raise after VDSM re-start timeout If VDSM failed to start within a fixed timeout raise to abort setup execution. Increasing the timeout value from 10 to 120 seconds. Change-Id: I636315a3e5f7a04fb004bf6be56687c362863174 Bug-Url: https://bugzilla.redhat.com/1285738 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I636315a3e5f7a04fb004bf6be56687c362863174 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine, webadmin: do not invoke HostSetupNetworksCommand wher...
by alkaplan＠redhat.com 30 Nov '15

30 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine,webadmin: do not invoke HostSetupNetworksCommand where no changes were made ...................................................................... engine,webadmin: do not invoke HostSetupNetworksCommand where no changes were made • discard from HostSetupNetworksCommandParameters all bonds and network attachments, which are sent to be updated, but they're equal to already existing Bonds resp. NetworkAttachment in the system. • added method to HostSetupNetworksCommandParameters to figure out if there's any change to be done in them, and this method is used both on UI and bll to figure out, whether changes needs to be done to the system. Change-Id: Icc4c17171ed37cea79ea80aa65b7f2a056ca407c Bug-Url: https://bugzilla.redhat.com/1254320 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetHostBondsByHostIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 4 files changed, 145 insertions(+), 35 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc4c17171ed37cea79ea80aa65b7f2a056ca407c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: engine-backup: Fix failure notifications
by tnisan＠redhat.com 30 Nov '15

30 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: engine-backup: Fix failure notifications ...................................................................... packaging: engine-backup: Fix failure notifications Always check and set FAILURE_NOTIFIED before trying to notify. Without this patch, in certain conditions, we could enter an endless loop while trying to notify the engine about a failure. Change-Id: Ieade3725a9a932c98cfc4e443e4f0c6b96d041d5 Bug-Url: https://bugzilla.redhat.com/1240923 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit a1a99f2829ec02ca5a33efad1468592288439265) --- M packaging/bin/engine-backup.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/49365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieade3725a9a932c98cfc4e443e4f0c6b96d041d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: engine-backup: Do not log cmdline parsing errors
by tnisan＠redhat.com 30 Nov '15

30 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: engine-backup: Do not log cmdline parsing errors ...................................................................... packaging: engine-backup: Do not log cmdline parsing errors That's especially important for the error about missing log file. Others are also not important to log - we want to log actual failures caught during backup. Bug-Url: https://bugzilla.redhat.com/1240923 Change-Id: Id804aeabf3f16cf52a372b07db7d4dcb741b4636 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 208f2cbebf3193cbe64d08423d6aa8c9c68edcdd) --- M packaging/bin/engine-backup.sh 1 file changed, 14 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/49364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id804aeabf3f16cf52a372b07db7d4dcb741b4636 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0