- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.1]: core: MoveOrCopyDiskCommand - do not attempt to increment db...
by tnisan＠redhat.com 24 Nov '15

24 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: MoveOrCopyDiskCommand - do not attempt to increment db gen ...................................................................... core: MoveOrCopyDiskCommand - do not attempt to increment db gen When copying a floating/VM disk the disk is copied to a new floating disk, therefore there is no need to attempt to increment the db generation. Change-Id: Ifa660944f8de2c93d0a595aa9ca5387ff2de6d8a Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/49092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa660944f8de2c93d0a595aa9ca5387ff2de6d8a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: core: MoveOrCopyDisk - attempt to perform rollback for vm/fl...
by tnisan＠redhat.com 24 Nov '15

24 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: MoveOrCopyDisk - attempt to perform rollback for vm/floating disk ...................................................................... core: MoveOrCopyDisk - attempt to perform rollback for vm/floating disk Currently when executing MoveOrCopyDisk for a non template disk no rollback is done and the disk will remain in the engine as a legit disk, while for template disk the mapping of the disk on the other domain will be deleted from the db. This patch adds an attempt to perform a rollback when copying a non template disk, the rollback when copying a template disk requires some other modifications and will be handled on a different patch. Change-Id: Id6727f513efca391ff843a1665dabb7826533706 Bug-Url: https://bugzilla.redhat.com/1232396 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/49091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6727f513efca391ff843a1665dabb7826533706 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: core: MoveOrCopyDisk - the created disk should be locked
by tnisan＠redhat.com 24 Nov '15

24 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: MoveOrCopyDisk - the created disk should be locked ...................................................................... core: MoveOrCopyDisk - the created disk should be locked MoveOrCopyDiskCommand creates a new disk when a disk which isn't a template disk is being copied. The created disk isn't LOCKED, which allows to attempt to perform operations using the disk while the copy wasn't finished yet. This patch makes sure that the disk is added as LOCKED. Change-Id: I82774a686fb5443e0402b1894c0e5fb2c8820cec Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1282694 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/49090 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82774a686fb5443e0402b1894c0e5fb2c8820cec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: core: MoveOrCopyDiskCommand - do not pass same parameters in...
by tnisan＠redhat.com 24 Nov '15

24 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: MoveOrCopyDiskCommand - do not pass same parameters instance ...................................................................... core: MoveOrCopyDiskCommand - do not pass same parameters instance The parameters instance of each command contains information that is unique to the command (for example - the command id). In MoveOrCopyDiskCommand the parameters of the command are passed to to child command which is problematic - the infra doesn't support that and it causes the endAction() of the wrong command to be executed, for entities to stay locked and so on. This patch solves that by adding a copy constructor to the parameters class hirerchy excluding the base parameters class that contains command specific information. That is the taken approach to minimize the risk of influecing one of the command usages as we'll backport this change. Later on we can remove the copy constructor and just create the child parameters manually without relying on the fact that they are of the same type of the parent command. Change-Id: I9b127231c8fb8a416d1861c2a6395fd2c0966c6b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1282693 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StoragePoolParametersBase.java 6 files changed, 80 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/49089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b127231c8fb8a416d1861c2a6395fd2c0966c6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: build: after build reports for 3.6.1
by sradco＠redhat.com 24 Nov '15

24 Nov '15

Shirly Radco has submitted this change and it was merged. Change subject: build: after build reports for 3.6.1 ...................................................................... build: after build reports for 3.6.1 Change-Id: Iff329d54fc3e7878c05e042d27a5251e68791483 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff329d54fc3e7878c05e042d27a5251e68791483 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: build: post ovirt-engine-dwh-3.6.1
by sradco＠redhat.com 24 Nov '15

24 Nov '15

Shirly Radco has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.6.1 ...................................................................... build: post ovirt-engine-dwh-3.6.1 Change-Id: I5d6062d360ad2b832197aecd041afb3c738a745c Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d6062d360ad2b832197aecd041afb3c738a745c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: build: ovirt-engine-dwh-3.6.1
by sradco＠redhat.com 24 Nov '15

24 Nov '15

Shirly Radco has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.6.1 ...................................................................... build: ovirt-engine-dwh-3.6.1 Change-Id: I412458958b8d234990e9be2b70e28f1f0070659f Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I412458958b8d234990e9be2b70e28f1f0070659f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Enabled concurrent builds in standard-ci
by dcaro＠redhat.com 24 Nov '15

24 Nov '15

David Caro has submitted this change and it was merged. Change subject: Enabled concurrent builds in standard-ci ...................................................................... Enabled concurrent builds in standard-ci Enabled concurrent builds in standard-ci, limiting each job to max 3 concurrent builds. Change-Id: Ic5049c8819a99d09b6bb61b166b0b8d17b8200be Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/yaml/templates/standard-stage.yaml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sharon Naftaly: Verified Barak Korren: Looks good to me Jenkins CI: Passed CI tests David Caro: Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/48760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5049c8819a99d09b6bb61b166b0b8d17b8200be Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: add all infra team git repos to nudge & abandon
by eedri＠redhat.com 24 Nov '15

24 Nov '15

Eyal Edri has submitted this change and it was merged. Change subject: add all infra team git repos to nudge & abandon ...................................................................... add all infra team git repos to nudge & abandon Change-Id: I5d6b6e0ee14abd4e940ee077bbf3ed2f8e109e54 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Verified; Passed CI tests; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests David Caro: Looks good to me -- To view, visit https://gerrit.ovirt.org/49015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d6b6e0ee14abd4e940ee077bbf3ed2f8e109e54 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: build: build reports for 3.6.1
by sradco＠redhat.com 24 Nov '15

24 Nov '15

Shirly Radco has submitted this change and it was merged. Change subject: build: build reports for 3.6.1 ...................................................................... build: build reports for 3.6.1 Change-Id: I431ecdf5778fe0fca3918ab0c3c9d0a3796e1f3a Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I431ecdf5778fe0fca3918ab0c3c9d0a3796e1f3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0