- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: passthrough vnic profile qos should be removed
by alkaplan＠redhat.com 24 Nov '15

24 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: passthrough vnic profile qos should be removed ...................................................................... webadmin: passthrough vnic profile qos should be removed Change-Id: I8c2a6e1c93193357bb8adc0a88286580661fb7cd Bug-Url: https://bugzilla.redhat.com/1258208 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c2a6e1c93193357bb8adc0a88286580661fb7cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: IrsProxyData.updateVdsDomainsData() - separation to me...
by tnisan＠redhat.com 24 Nov '15

24 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: IrsProxyData.updateVdsDomainsData() - separation to methods ...................................................................... core: IrsProxyData.updateVdsDomainsData() - separation to methods This patch separates the logic contained in updateVdsDomainsData() into different methods for simplification and easier maintenance. Change-Id: I56124dc1a1511a41af2eda2649dc4f4640d35c76 Bug-Url: https://bugzilla.redhat.com/1256841 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 111 insertions(+), 82 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/48921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56124dc1a1511a41af2eda2649dc4f4640d35c76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: more accurate audit log when domain is deactivated
by tnisan＠redhat.com 24 Nov '15

24 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: more accurate audit log when domain is deactivated ...................................................................... core: more accurate audit log when domain is deactivated when a Storage Domain is being deactivated it first moves to "Preparing for maintenance" status and only when it's confirmed that its not accessed (by monitoring) from any host it moves to Maintenance status. However, currently when it moves to "Preparing for maintenance" the audit log indicates that the domain was deactivated and when it actually moves to Maintenance there's no audit log at all. This patch fixes the current audit log and adds a new one for the time the domain status is changed to Maintenance. Change-Id: Ia64ce39aeeb4a8874a6c92dc4b337e7e4b1664bc Bug-Url: https://bugzilla.redhat.com/1247957 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 4 files changed, 26 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/48920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia64ce39aeeb4a8874a6c92dc4b337e7e4b1664bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: post ovirt-hosted-engine-ha-1.3.3
by msivak＠redhat.com 24 Nov '15

24 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.3.3 ...................................................................... build: post ovirt-hosted-engine-ha-1.3.3 Change-Id: I3f2c129fca443605847c7273a27b06f53dfe78d7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f2c129fca443605847c7273a27b06f53dfe78d7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: ovirt-hosted-engine-ha-1.3.3
by msivak＠redhat.com 24 Nov '15

24 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: ovirt-hosted-engine-ha-1.3.3 ...................................................................... ovirt-hosted-engine-ha-1.3.3 Change-Id: I62f940bc94d284de54e002663a5c7d329d3a5c1c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62f940bc94d284de54e002663a5c7d329d3a5c1c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Fix a PEP8 issue
by msivak＠redhat.com 24 Nov '15

24 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: Fix a PEP8 issue ...................................................................... Fix a PEP8 issue Change-Id: I64ad0b3bab2eb03bc8921e05150540b48c8e7542 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 07069ff0fe17517508d68ea7371aef646faf5be4) --- M ovirt_hosted_engine_ha/broker/storage_broker.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64ad0b3bab2eb03bc8921e05150540b48c8e7542 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Fix a PEP8 issue
by msivak＠redhat.com 24 Nov '15

24 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: Fix a PEP8 issue ...................................................................... Fix a PEP8 issue Change-Id: I64ad0b3bab2eb03bc8921e05150540b48c8e7542 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/storage_broker.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64ad0b3bab2eb03bc8921e05150540b48c8e7542 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: build: post ovirt-engine-3.6.1
by tnisan＠redhat.com 24 Nov '15

24 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-3.6.1 ...................................................................... build: post ovirt-engine-3.6.1 Change-Id: Ide3a88e376142d2eaa4da0456efe2354be566f03 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 58 files changed, 65 insertions(+), 62 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide3a88e376142d2eaa4da0456efe2354be566f03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: avoid cleaning up SP if was not created by me
by sbonazzo＠redhat.com 24 Nov '15

24 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid cleaning up SP if was not created by me ...................................................................... packaging: setup: avoid cleaning up SP if was not created by me Avoid trying to clening up the SP if was not created by me. Change-Id: Ia06320a9904c52021d6f7c81916600faeaa77226 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia06320a9904c52021d6f7c81916600faeaa77226 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Use SYNC DIRECT IO everywhere to make sure all hosts see the...
by msivak＠redhat.com 24 Nov '15

24 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: Use SYNC DIRECT IO everywhere to make sure all hosts see the same data ...................................................................... Use SYNC DIRECT IO everywhere to make sure all hosts see the same data We did remove direct io for LVM based backends as Python did not supported that properly (http://bugs.python.org/issue5396) The issue with direct io is that it requires page aligned buffers for writes and reads. Python can't ensure that. This patch uses a very nice workaround from http://www.alexonlinux.com/direct-io-in-python that proposed to use mmap to get the buffer. MMAPped memory is page aligned and Python can use it for reads and writes. Change-Id: I31912300b27a2ae215e2462114012676b43cb017 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1277079 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 8b1e39ea7583d8a542cfaa3e67b7da3e788a008a) --- M ovirt_hosted_engine_ha/broker/storage_broker.py M ovirt_hosted_engine_ha/lib/storage_backends.py M ovirt_hosted_engine_ha/lib/util.py 3 files changed, 67 insertions(+), 25 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31912300b27a2ae215e2462114012676b43cb017 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0