- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137
by alkaplan＠redhat.com 23 Nov '15

23 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 ...................................................................... core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 patch 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 was entirelly wrong. One must not consult macPool there, since interface here already has MAC address obtained from pool, so check here always failed. It probably cannot be reverted nicely, since there were other patches fixing some of problems this patch introduced. note: bug https://bugzilla.redhat.com/show_bug.cgi?id=1212461 related to patch being reverted, was reverified as well and I did not reproduce it. Change-Id: I0c3b9f9a4cb2f8515823d42293a7928485f4cedf Bug-Url: https://bugzilla.redhat.com/1270583 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 6 insertions(+), 31 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c3b9f9a4cb2f8515823d42293a7928485f4cedf Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: remove HostPredicate and use IdPredicate instead
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: remove HostPredicate and use IdPredicate instead ...................................................................... frontend: remove HostPredicate and use IdPredicate instead This patch removes duplicate code implemented in HostPredicate and uses IdPredicate instead. Change-Id: Ib2fce1d2744e6e7cc3a6e6bde8eb644065ffcebe Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 3 files changed, 2 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48652 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2fce1d2744e6e7cc3a6e6bde8eb644065ffcebe Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: remove ClusterPredicate and use IdPredicate instead
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: remove ClusterPredicate and use IdPredicate instead ...................................................................... frontend: remove ClusterPredicate and use IdPredicate instead This patch removes duplicate code implemented in ClusterPredicate and uses IdPredicate instead. Change-Id: Ic9c3102d644d402cf0e2136214a4eec9184b300e Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 6 files changed, 5 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48651 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9c3102d644d402cf0e2136214a4eec9184b300e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: improve Linq.DataCenterNotStatusPredicate
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: improve Linq.DataCenterNotStatusPredicate ...................................................................... frontend: improve Linq.DataCenterNotStatusPredicate DataCenterNotStatusPredicate does the exact opposite of DataCenterStatusPredicate, so it's better to use it instead of repeating the same logic with negation. Change-Id: Ic676a71a6a95b53a85b3ff29769d9eee2f6a35e6 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic676a71a6a95b53a85b3ff29769d9eee2f6a35e6 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: remove DataCenterPredicate and use IdPredicate ins...
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: remove DataCenterPredicate and use IdPredicate instead ...................................................................... frontend: remove DataCenterPredicate and use IdPredicate instead This patch removes duplicate code implemented in DataCenterPredicate, and uses IdPredicate instead. Change-Id: I6a5fc8190d2e3b4ed4574617d017e9c754d9194a Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 7 files changed, 7 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a5fc8190d2e3b4ed4574617d017e9c754d9194a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: add null checks to IdPredicate
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: add null checks to IdPredicate ...................................................................... frontend: add null checks to IdPredicate This patch adds some null checks to IdPredicate to avoid NullPointerExceptions. Change-Id: I5c1865aa3e9969969681a6b4bc8fe15044c02ece Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48648 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c1865aa3e9969969681a6b4bc8fe15044c02ece Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: change StoragePredicate to IdPredicate
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: change StoragePredicate to IdPredicate ...................................................................... frontend: change StoragePredicate to IdPredicate This patch generalizes StoragePredicate to get any BusinessEntity<Guid> object, and not only StorageDomain objects. Change-Id: I016e6e255c446ce60ab7a92001df17e7ccc1e3b8 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I016e6e255c446ce60ab7a92001df17e7ccc1e3b8 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: change VersionPredicate to EqualsPredicate
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: change VersionPredicate to EqualsPredicate ...................................................................... frontend: change VersionPredicate to EqualsPredicate This patch generalizes VersionPredicate to get any Object, and not only Version objects. Change-Id: I654b781495b03ef1eb1f758867a0a7e9e70a7e94 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48646 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I654b781495b03ef1eb1f758867a0a7e9e70a7e94 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Bootable disk index considers CDROM on PPC
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Bootable disk index considers CDROM on PPC ...................................................................... core: Bootable disk index considers CDROM on PPC PPC specific: The CDROM is mapped to sda (or index=0). This patch handles setting of additional bootable disk's index on PPC. Change-Id: I32ad475a311c9be4b8a38b5ec616e12723ecf305 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1274677 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/architecture/GetBootableDiskIndex.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 45 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/48964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32ad475a311c9be4b8a38b5ec616e12723ecf305 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: live snapshot - create VM metadata in RAW
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: live snapshot - create VM metadata in RAW ...................................................................... core: live snapshot - create VM metadata in RAW Currently, VM metadata file is created in COW format during live snapshot flow. However, dumping the data (using pickle on snapshot verb) transforms the file to RAW. As a result, we get a miscorrelation between the .meta file (which still has COW as a format), while the file itself is RAW (verified using 'qemu info'). Hence, the VM metadata file should be created as RAW format in the first place instead of COW. Change-Id: I12c1d657661c86f129df92e633f0438d778d6147 Bug-Url: https://bugzilla.redhat.com/1284580 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Daniel Erez: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12c1d657661c86f129df92e633f0438d778d6147 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0