- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: Use Cinder snapshot for unplugged disks.
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Use Cinder snapshot for unplugged disks. ...................................................................... core: Use Cinder snapshot for unplugged disks. Add unplugged Cinder disks to snapshot. Change-Id: I502884fe802120db34c95de4d73405d3e8e42fc8 Bug-Url: https://bugzilla.redhat.com/1284266 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/48999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I502884fe802120db34c95de4d73405d3e8e42fc8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Return empty list if no VM numa nodes are present
by rgolan＠redhat.com 23 Nov '15

23 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: core: Return empty list if no VM numa nodes are present ...................................................................... core: Return empty list if no VM numa nodes are present Let AddVmNumaNodesCommand and VM always return an empty list instead of null if no numa configuration is present to avoid confusing null checks. Bug-Url: https://bugzilla.redhat.com/1279178 Bug-Url: https://bugzilla.redhat.com/1177259 Change-Id: I095e245227aed5e5c8f6d342d2a8af17b936eb00 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmNumaNodeOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 3 files changed, 12 insertions(+), 8 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests Tomer Saban: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I095e245227aed5e5c8f6d342d2a8af17b936eb00 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: change StorageNamePredicate to NamePredicate
by tnisan＠redhat.com 23 Nov '15

23 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: change StorageNamePredicate to NamePredicate ...................................................................... frontend: change StorageNamePredicate to NamePredicate This patch generalizes StorageNamePredicate to get any Nameable object, and not only StorageDomain objects. Change-Id: I1ddecd2361f1398ed3b2f5fe0bcd3a4a28ef1868 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ddecd2361f1398ed3b2f5fe0bcd3a4a28ef1868 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: live snapshot - create VM metadata in RAW
by derez＠redhat.com 23 Nov '15

23 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: core: live snapshot - create VM metadata in RAW ...................................................................... core: live snapshot - create VM metadata in RAW Currently, VM metadata file is created in COW format during live snapshot flow. However, dumping the data (using pickle on snapshot verb) transforms the file to RAW. As a result, we get a miscorrelation between the .meta file (which still has COW as a format), while the file itself is RAW (verified using 'qemu info'). Hence, the VM metadata file should be created as RAW format in the first place instead of COW. Change-Id: I12c1d657661c86f129df92e633f0438d778d6147 Bug-Url: https://bugzilla.redhat.com/1284580 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12c1d657661c86f129df92e633f0438d778d6147 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not pass the context automatically on rollback
by laravot＠redhat.com 23 Nov '15

23 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: do not pass the context automatically on rollback ...................................................................... core: do not pass the context automatically on rollback In change I310f5f77fff78b3232ee77fe63791425fd521516 CommandBase.attemptRollback() was changed so that instead of accepting a callback as a parameter it automatically clones the current command context and passes it. That changed the previous behavior, as the using commands didn't pass the context. This change isn't documented in the change commit message and affects the rollback, as now the context is passed always the compensation context of the rollback initiating command is used opposed to before. therefore i'm restoring the previous behavior here (null was passed as the context for the callback). Change-Id: I02cd0bf6ff89591f5f62741200b5620ac96fbd90 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1284250 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java 3 files changed, 10 insertions(+), 6 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02cd0bf6ff89591f5f62741200b5620ac96fbd90 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveImage - fix parameters ctor
by laravot＠redhat.com 23 Nov '15

23 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: RemoveImage - fix parameters ctor ...................................................................... core: RemoveImage - fix parameters ctor The parameters shoudld execute the ctor that gets the context as needed logic is contained there. Change-Id: If0c6eb9fc892b9ed6b7e13ab5e370d0fa753d4b3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1284250 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48914 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0c6eb9fc892b9ed6b7e13ab5e370d0fa753d4b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: MoveOrCopyDiskCommand - do not attempt to increment db...
by laravot＠redhat.com 23 Nov '15

23 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: MoveOrCopyDiskCommand - do not attempt to increment db gen ...................................................................... core: MoveOrCopyDiskCommand - do not attempt to increment db gen When copying a floating/VM disk the disk is copied to a new floating disk, therefore there is no need to attempt to increment the db generation. Change-Id: Ifa660944f8de2c93d0a595aa9ca5387ff2de6d8a Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa660944f8de2c93d0a595aa9ca5387ff2de6d8a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: MoveOrCopyDisk - attempt to perform rollback for vm/fl...
by laravot＠redhat.com 23 Nov '15

23 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: MoveOrCopyDisk - attempt to perform rollback for vm/floating disk ...................................................................... core: MoveOrCopyDisk - attempt to perform rollback for vm/floating disk Currently when executing MoveOrCopyDisk for a non template disk no rollback is done and the disk will remain in the engine as a legit disk, while for template disk the mapping of the disk on the other domain will be deleted from the db. This patch adds an attempt to perform a rollback when copying a non template disk, the rollback when copying a template disk requires some other modifications and will be handled on a different patch. Change-Id: Id6727f513efca391ff843a1665dabb7826533706 Bug-Url: https://bugzilla.redhat.com/1232396 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6727f513efca391ff843a1665dabb7826533706 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: MoveOrCopyDisk - the created disk should be locked
by laravot＠redhat.com 23 Nov '15

23 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: MoveOrCopyDisk - the created disk should be locked ...................................................................... core: MoveOrCopyDisk - the created disk should be locked MoveOrCopyDiskCommand creates a new disk when a disk which isn't a template disk is being copied. The created disk isn't LOCKED, which allows to attempt to perform operations using the disk while the copy wasn't finished yet. This patch makes sure that the disk is added as LOCKED. Change-Id: I82774a686fb5443e0402b1894c0e5fb2c8820cec Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1282694 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48634 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82774a686fb5443e0402b1894c0e5fb2c8820cec Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: MoveOrCopyDiskCommand - do not pass same parameters in...
by laravot＠redhat.com 23 Nov '15

23 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: MoveOrCopyDiskCommand - do not pass same parameters instance ...................................................................... core: MoveOrCopyDiskCommand - do not pass same parameters instance The parameters instance of each command contains information that is unique to the command (for example - the command id). In MoveOrCopyDiskCommand the parameters of the command are passed to to child command which is problematic - the infra doesn't support that and it causes the endAction() of the wrong command to be executed, for entities to stay locked and so on. This patch solves that by adding a copy constructor to the parameters class hirerchy excluding the base parameters class that contains command specific information. That is the taken approach to minimize the risk of influecing one of the command usages as we'll backport this change. Later on we can remove the copy constructor and just create the child parameters manually without relying on the fact that they are of the same type of the parent command. Change-Id: I9b127231c8fb8a416d1861c2a6395fd2c0966c6b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1282693 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StoragePoolParametersBase.java 6 files changed, 80 insertions(+), 29 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b127231c8fb8a416d1861c2a6395fd2c0966c6b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0