- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove the Findbugs profiles
by juan.hernandez＠redhat.com 23 Nov '15

23 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove the Findbugs profiles ...................................................................... core: Remove the Findbugs profiles Currently we have two Maven profiles related to Findbugs, one named "findbugs" that adds the project specific exclussions, and another one named "findbugs-general" that also adds the shared exclussions. As both exclussions need to be always enabled these profiles aren't needed, instead the required settings can be specified in the Findbugs plugin, inside the "plugins" section of the root POM. After applying this patch the invocation of Findbugs will just be the following: $ mvn findbugs:findbugs The "-Pfindbugs-general" option is no longer required. Change-Id: Ife1fafa2b6b7db4ee12d61835319059396a1f68e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 20 insertions(+), 56 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife1fafa2b6b7db4ee12d61835319059396a1f68e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmValidator#vmNotHavingPassthroughVnics linq
by amureini＠redhat.com 23 Nov '15

23 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmValidator#vmNotHavingPassthroughVnics linq ...................................................................... core: VmValidator#vmNotHavingPassthroughVnics linq Replaced the usage of LinqUtils with a single fluent call to Java 8's streaming API. This patch both simplifies the code and offers a slight performance boost since the list of interfaces is only iterated once, instead of twice in the original code (once for filtering the passthrough nics and once for extracting their Names with ReplacementUtils). Change-Id: Ibb009e2c2e604a740712987fd35763c578f2b36c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb009e2c2e604a740712987fd35763c578f2b36c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmValidator#vmNotHavingPassthroughVnics replacements
by amureini＠redhat.com 23 Nov '15

23 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmValidator#vmNotHavingPassthroughVnics replacements ...................................................................... core: VmValidator#vmNotHavingPassthroughVnics replacements Calculate the list of replacement strings only if needed. This patch improves the code's readability by emphasizing that the replacements are only used in an error case, and offers a [very] slight performance improvement in the non-error case. Change-Id: I4f3c285c5195c369101f9b09b7e9c2867d911a31 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f3c285c5195c369101f9b09b7e9c2867d911a31 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Bootable disk index considers CDROM on PPC
by derez＠redhat.com 23 Nov '15

23 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: core: Bootable disk index considers CDROM on PPC ...................................................................... core: Bootable disk index considers CDROM on PPC PPC specific: The CDROM is mapped to sda (or index=0). This patch handles setting of additional bootable disk's index on PPC. Change-Id: I32ad475a311c9be4b8a38b5ec616e12723ecf305 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1274677 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/architecture/GetBootableDiskIndex.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 45 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/48407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32ad475a311c9be4b8a38b5ec616e12723ecf305 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Changed NATURAL INNER JOIN to NATURAL JOIN
by emesika＠redhat.com 22 Nov '15

22 Nov '15

Eli Mesika has submitted this change and it was merged. Change subject: core: Changed NATURAL INNER JOIN to NATURAL JOIN ...................................................................... core: Changed NATURAL INNER JOIN to NATURAL JOIN The create_views sql script is using "NATURAL INNER JOIN" views which practically behaves the same as "NATURAL JOIN" and is also confusing for anyone looking at the code. It's also not commonly used in code bases. For that reason, all views using "NATURAL INNER JOIN" now use "NATURAL JOIN" instead. Change-Id: I95e197312cc506c2aaa94c8c5532c09c9faf7f9a Bug-Url: https://bugzilla.redhat.com/1143869 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/48934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95e197312cc506c2aaa94c8c5532c09c9faf7f9a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove DbFacade#isStoragePoolMasterUp(Guid)
by amureini＠redhat.com 22 Nov '15

22 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove DbFacade#isStoragePoolMasterUp(Guid) ...................................................................... core: Remove DbFacade#isStoragePoolMasterUp(Guid) The isStoragePoolMasterUp(Guid) method has no place in DbFacade, that's supposed to be a general access point that provides the various DAOs. Moreover, its implementation is awful, retrieving all of the pool's domains from the database and iterating them one by one to find the master domain in memory, instead of applying that filtering the query itself. This patch removes this useless method and its tests, and replaces it with a method in IrsProxyData (the only place that used this call), which is implemented properly, by retrieving only the correct domains from the database, offering a slight performance benefit by the way. Change-Id: I27b0ab4ae9b253ece29be97e9d9ae86ba9aefcb0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 3 files changed, 7 insertions(+), 46 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27b0ab4ae9b253ece29be97e9d9ae86ba9aefcb0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Optimize equals/hashCode in sla classes
by mperina＠redhat.com 22 Nov '15

22 Nov '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Optimize equals/hashCode in sla classes ...................................................................... core: Optimize equals/hashCode in sla classes 1. Optimizes equals method to contain recommended functionality as described in Effective Java 2nd edition 2. Optimizes objects comparison in equals method to use Objects.equals() 3. Optimizes hashCode method to use Objects.hash()/hashCode() methods Change-Id: I96f0c51d2c7940d86b1d224d990cac5f50ed6e30 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CpuStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaStorage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaVdsGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNode.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNumaNode.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/CpuProfile.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/DiskProfile.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/AffinityGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/ClusterPolicy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationValue.java 17 files changed, 271 insertions(+), 447 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48842 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96f0c51d2c7940d86b1d224d990cac5f50ed6e30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.4]: packaging: post ovirt-host-deploy-1.4.1
by Alon Bar-Lev 22 Nov '15

22 Nov '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: post ovirt-host-deploy-1.4.1 ...................................................................... packaging: post ovirt-host-deploy-1.4.1 Change-Id: Ia9406955c4bd1b681cb7fdf49a0416cb98fa784a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9406955c4bd1b681cb7fdf49a0416cb98fa784a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.4]: packaging: ovirt-host-deploy-1.4.1
by Alon Bar-Lev 22 Nov '15

22 Nov '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: ovirt-host-deploy-1.4.1 ...................................................................... packaging: ovirt-host-deploy-1.4.1 Change-Id: I174cf362935a99d3767747cba50f071609d7dc9d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac M ovirt-host-deploy-offline.spec.in M ovirt-host-deploy.spec.in 4 files changed, 9 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48932 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I174cf362935a99d3767747cba50f071609d7dc9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmHandler streaming API usage
by amureini＠redhat.com 22 Nov '15

22 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmHandler streaming API usage ...................................................................... core: VmHandler streaming API usage Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. This patch is part of the effort to remove LinqUtils completely. Change-Id: I906c977c7b029a1842f581cf9593374f357e56ae Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 4 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/48886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I906c977c7b029a1842f581cf9593374f357e56ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0