- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Extract method to identify detached storage domain.
by Code Review 24 Aug '17

24 Aug '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/80825 ) Change subject: core: Extract method to identify detached storage domain. ...................................................................... core: Extract method to identify detached storage domain. Extract code which checks for null storage pool to a boolean method to make force remove process more readable. Change-Id: Ibe43173d3013a867be9a64243058edbfaa50989a Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ForceRemoveStorageDomainCommand.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/80825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe43173d3013a867be9a64243058edbfaa50989a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live 4.1.6 rc1
by Code Review 24 Aug '17

24 Aug '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/80992 ) Change subject: build: ovirt-live 4.1.6 rc1 ...................................................................... build: ovirt-live 4.1.6 rc1 Change-Id: I276e27cc7bea720cf562f752d661e6bb8aad8694 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/80992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I276e27cc7bea720cf562f752d661e6bb8aad8694 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use is prefix for boolean method.
by Code Review 24 Aug '17

24 Aug '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/80753 ) Change subject: core: Use is prefix for boolean method. ...................................................................... core: Use is prefix for boolean method. Change the signeture name of getForceRemove to isForceRemove to be compatible with the rest of the boolean methods in the project. Change-Id: Iac982b0a98b5cb5d1c87180c0b482e224c314e40 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StoragePoolParametersBase.java 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/80753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac982b0a98b5cb5d1c87180c0b482e224c314e40 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ExecuteNetworkCommandInNetworkOperationTest type i...
by Code Review 24 Aug '17

24 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80986 ) Change subject: webadmin: ExecuteNetworkCommandInNetworkOperationTest type inference ...................................................................... webadmin: ExecuteNetworkCommandInNetworkOperationTest type inference Change-Id: I822092d3339ed8e05217a52169bbecef41035c48 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I822092d3339ed8e05217a52169bbecef41035c48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ExecuteNetworkCommandInNetworkOperationTest boolea...
by Code Review 24 Aug '17

24 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80987 ) Change subject: webadmin: ExecuteNetworkCommandInNetworkOperationTest boolean expression ...................................................................... webadmin: ExecuteNetworkCommandInNetworkOperationTest boolean expression Simplify a boolean expression using the "!" operator instead of a cumbersome ternary operator. Change-Id: I45402822ed0eb21743ee5986f64c4652f3ef3fe6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45402822ed0eb21743ee5986f64c4652f3ef3fe6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ExecuteNetworkCommandInNetworkOperationTest matchers
by Code Review 24 Aug '17

24 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80988 ) Change subject: webadmin: ExecuteNetworkCommandInNetworkOperationTest matchers ...................................................................... webadmin: ExecuteNetworkCommandInNetworkOperationTest matchers The is(value) matcher supports nulls, so the boiler plate of checking if the value matched against is null or not is redundant, and can (should!) be removed. Change-Id: Ieb583597677b4d4df1a1ae005a114dd3140589a0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb583597677b4d4df1a1ae005a114dd3140589a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Enhance the VM has illegal images alert
by Code Review 24 Aug '17

24 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80638 ) Change subject: core: Enhance the VM has illegal images alert ...................................................................... core: Enhance the VM has illegal images alert If the VM is running, display an alert warning the user that there are snapshots with illegal images, and recommend retrying deleting those snapshots before shutting down the VM. If the VM is down, display an alert warning the user that there are snapshots will illegal images, and recommend retrying deleting those snapshots. Change-Id: I8bf6294c11078bde2deca5f6d7a63a80821056f8 Bug-Url: https://bugzilla.redhat.com/1372163 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusColumn.java 3 files changed, 10 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/80638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bf6294c11078bde2deca5f6d7a63a80821056f8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Change creation date format
by Code Review 24 Aug '17

24 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80979 ) Change subject: webadmin: Change creation date format ...................................................................... webadmin: Change creation date format This patch changes the creation date's format in templates > disks subtub from mm/dd/yy to a full date format (Mar 16, 2017, 10:52:29 AM). Accordingly, the column widths were expanded. Change-Id: If4a61159c28cece1ad21517ed7e7081daa33f509 Bug-Url: https://bugzilla.redhat.com/1478880 Signed-off-by: Shani Leviim <sleviim(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateDiskView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Shani Leviim: Verified -- To view, visit https://gerrit.ovirt.org/80979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4a61159c28cece1ad21517ed7e7081daa33f509 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: set vm owner on import vm like on add vm
by Code Review 24 Aug '17

24 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80956 ) Change subject: core: set vm owner on import vm like on add vm ...................................................................... core: set vm owner on import vm like on add vm In theory, the permission settings on import VM should be similar to that on add VM. This patch applies what commit I7e814ab0 did for add VM to import VM, in order to prevent a scenario in which users import VMs and then lack the required permissions to manage them. Change-Id: I4a8c63e8a5cce4c313fdeee8e90a8857faca11d0 Bug-Url: https://bugzilla.redhat.com/1451501 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java 1 file changed, 31 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a8c63e8a5cce4c313fdeee8e90a8857faca11d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused CommandBase methods
by Code Review 24 Aug '17

24 Aug '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. ( https://gerrit.ovirt.org/80941 ) Change subject: core: Remove unused CommandBase methods ...................................................................... core: Remove unused CommandBase methods Change-Id: I5a32a523bd272447a61605b7f453667a680be0f1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 0 insertions(+), 101 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a32a523bd272447a61605b7f453667a680be0f1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0