- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: store offset of vm lease as a string
by Code Review 24 Aug '17

24 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80872 ) Change subject: core: store offset of vm lease as a string ...................................................................... core: store offset of vm lease as a string We don't use it besides putting it in the engine XML. Having it as Integer in the database complicates the engine-side handling. Thus, converting it into String. Change-Id: Ie4ca6251a00c960b4d9b2c02f8fab99e54eb3f01 Bug-Id: https://bugzilla.redhat.com/1481691 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmLeaseInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LeaseInfoReturn.java 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/80872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ca6251a00c960b4d9b2c02f8fab99e54eb3f01 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Fix wrong order of setChangeProhibitionReason
by Code Review 24 Aug '17

24 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80902 ) Change subject: frontend: Fix wrong order of setChangeProhibitionReason ...................................................................... frontend: Fix wrong order of setChangeProhibitionReason If setChangeProhibitionReason was called before setIsChangeable the reason was overwritten by null. Change-Id: I2d1c0877317cf8e5d24d766a6f7aab2c5b9e1f8e Signed-off-by: Ales Musil <amusil(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1435094 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportEntityData.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 7 files changed, 14 insertions(+), 14 deletions(-) Approvals: Ales Musil: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d1c0877317cf8e5d24d766a6f7aab2c5b9e1f8e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: db: drop redundant indexes from db
by Code Review 23 Aug '17

23 Aug '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/80919 ) Change subject: db: drop redundant indexes from db ...................................................................... db: drop redundant indexes from db In Postgres a primary key implies a unique index implicitly. Therefor, there is no need to create an index explicitly that is identical to columns on which the PK is defined. This patch removes redundant indexes from the database. The duplicate indexes were found using the following query: SELECT pg_size_pretty(SUM(pg_relation_size(idx))::BIGINT) AS SIZE, (array_agg(idx))[1] AS idx1, (array_agg(idx))[2] AS idx2, (array_agg(idx))[3] AS idx3, (array_agg(idx))[4] AS idx4 FROM ( SELECT indexrelid::regclass AS idx, ( indrelid::text ||E'\n'|| indclass::text ||E'\n'|| indkey::text ||E'\n'|| COALESCE(indexprs::text,'')||E'\n' || COALESCE(indpred::text,'')) AS KEY FROM pg_index) sub GROUP BY KEY HAVING COUNT(*)>1 ORDER BY SUM(pg_relation_size(idx)) DESC; The results were: engine_1483889=# \d idx_vm_ovf_generations_vm_guid Index "public.idx_vm_ovf_generations_vm_guid" Column | Type | Definition ---------+------+------------ vm_guid | uuid | vm_guid btree, for table "public.vm_ovf_generations" engine_1483889=# \d vm_ovf_generations_pkey Index "public.vm_ovf_generations_pkey" Column | Type | Definition ---------+------+------------ vm_guid | uuid | vm_guid primary key, btree, for table "public.vm_ovf_generations" engine_1483889=# \d idx_engine_backup_log Index "public.idx_engine_backup_log" Column | Type | Definition ---------+--------------------------+------------ scope | character varying(64) | scope done_at | timestamp with time zone | done_at unique, btree, for table "public.engine_backup_log" engine_1483889=# \d engine_backup_log_pkey Index "public.engine_backup_log_pkey" Column | Type | Definition ---------+--------------------------+------------ scope | character varying(64) | scope done_at | timestamp with time zone | done_at primary key, btree, for table "public.engine_backup_log" engine_1483889=# \d idx_event_notification_hist Index "public.idx_event_notification_hist" Column | Type | Definition --------------+--------+-------------- audit_log_id | bigint | audit_log_id btree, for table "public.event_notification_hist" engine_1483889=# \d idx_event_notification_hist_audit_log_id Index "public.idx_event_notification_hist_audit_log_id" Column | Type | Definition --------------+--------+-------------- audit_log_id | bigint | audit_log_id btree, for table "public.event_notification_hist" engine_1483889=# \d idx_supported_cluster_features Index "public.idx_supported_cluster_features" Column | Type | Definition ------------+------+------------ cluster_id | uuid | cluster_id feature_id | uuid | feature_id unique, btree, for table "public.supported_cluster_features" engine_1483889=# \d pk_supported_cluster_features Index "public.pk_supported_cluster_features" Column | Type | Definition ------------+------+------------ cluster_id | uuid | cluster_id feature_id | uuid | feature_id primary key, btree, for table "public.supported_cluster_features" Change-Id: I7760ccf64af99b243a87e1344eb0d2b6caadaeb3 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql A packaging/dbscripts/upgrade/04_02_0510_drop_redundant_indexes.sql 2 files changed, 20 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7760ccf64af99b243a87e1344eb0d2b6caadaeb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Unify usage of UIConstants in vNIC profile
by Code Review 23 Aug '17

23 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80901 ) Change subject: frontend: Unify usage of UIConstants in vNIC profile ...................................................................... frontend: Unify usage of UIConstants in vNIC profile Add UIConstants in VnicProfileModel and use the constants variable instead of calling ConstantsManager every time. Change-Id: I1ab3710e98b80aec5ea048d73c0342e555f58c62 Signed-off-by: Ales Musil <amusil(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1435094 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 3 files changed, 11 insertions(+), 25 deletions(-) Approvals: Ales Musil: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ab3710e98b80aec5ea048d73c0342e555f58c62 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: rename: Fix URL
by Code Review 23 Aug '17

23 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80316 ) Change subject: packaging: rename: Fix URL ...................................................................... packaging: rename: Fix URL Change-Id: I551f843ed1c75af6372b9ffd224ed23795564573 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/80316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I551f843ed1c75af6372b9ffd224ed23795564573 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: isort: Add mock to known third-party packages
by Code Review 23 Aug '17

23 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80882 ) Change subject: packaging: isort: Add mock to known third-party packages ...................................................................... packaging: isort: Add mock to known third-party packages Bug-Url: https://bugzilla.redhat.com/1450161 Change-Id: Iee0432826d7e2fc2b030f2b910c4e1e172f6dc15 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M .isort.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee0432826d7e2fc2b030f2b910c4e1e172f6dc15 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: history: update vm template name length
by Code Review 23 Aug '17

23 Aug '17

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. ( https://gerrit.ovirt.org/80968 ) Change subject: history: update vm template name length ...................................................................... history: update vm template name length Updated vm template name length from 40 to 255. Change-Id: I96224411ab3e769b5ae5bdb62db68b02a1e3c10c Bug-Url: https://bugzilla.redhat.com/1482043 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/create_tables.sql A packaging/dbscripts/upgrade/04_02_0010_updated_vm_template_name_length.sql M tos_project/process/ConfigurationSync_4.2.item M tos_project/process/ConfigurationSync_4.2.properties 4 files changed, 11 insertions(+), 8 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96224411ab3e769b5ae5bdb62db68b02a1e3c10c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: start new transaction for AuditLogDirector
by Code Review 23 Aug '17

23 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80958 ) Change subject: core: start new transaction for AuditLogDirector ...................................................................... core: start new transaction for AuditLogDirector Fixed issue with AuditLogDirector sharing same transaction as command. Now for logging is started new transaction. Change-Id: I564a9fd3022b3886b55ed7c8285880642a902ed3 Bug-Url: https://bugzilla.redhat.com/1479693 Signed-off-by: Miroslava Voglova <mvoglova(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Miroslava Voglova: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I564a9fd3022b3886b55ed7c8285880642a902ed3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Miroslava Voglova <mvoglova(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Miroslava Voglova <mvoglova(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: mock_runner fix empty mrmap bug
by Code Review 23 Aug '17

23 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80960 ) Change subject: mock_runner fix empty mrmap bug ...................................................................... mock_runner fix empty mrmap bug Mock runner would wait for input forever because it tried to `cat` ovirt-ci.mrmap. If the path to mock-confs-dir was wrong, or the file doesn't exists it would cause mock runner to wait forever without any meaningful message written to the screen. Change-Id: Ic2fe06037dbf3b398b56361c783042b39efd579f Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests Daniel Belenky: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/80960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2fe06037dbf3b398b56361c783042b39efd579f Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: db:enable to change col type from general function
by Code Review 23 Aug '17

23 Aug '17

>From Eli Mesika <emesika(a)redhat.com>: Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/80963 ) Change subject: db:enable to change col type from general function ...................................................................... db:enable to change col type from general function The implementation ignored changing from certain type to the same one so this function could not be used for extending a VARCHAR columns for example. This patch fixes that issue. Change-Id: I93120b93d6cc2dbb7492c8cd654293c054fe8d8b Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 4 insertions(+), 18 deletions(-) Approvals: Shirly Radco: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/80963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93120b93d6cc2dbb7492c8cd654293c054fe8d8b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0