- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: Support remove for Cinder volume.
by tnisan＠redhat.com 08 Nov '15

08 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Support remove for Cinder volume. ...................................................................... core: Support remove for Cinder volume. Adding a new command to support only remove of Cinder volume. Change-Id: I2a2441480a485436ea85f25679e769333d24c3d7 Bug-Url: https://bugzilla.redhat.com/1278126 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskVolumeCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskVolumeCommandCallback.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskVolumeParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 4 files changed, 178 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/48234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a2441480a485436ea85f25679e769333d24c3d7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix for required checkbox in manage network popup
by alkaplan＠redhat.com 08 Nov '15

08 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fix for required checkbox in manage network popup ...................................................................... webadmin: fix for required checkbox in manage network popup the fix will prevent mark network as required if the network is not attached to the cluster. Change-Id: Ib8bb00a953d3085bff032f123cff0b08a34afbe4 Bug-Url: https://bugzilla.redhat.com/1200787 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8bb00a953d3085bff032f123cff0b08a34afbe4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Support recursive remove of cinder volumes.
by mlipchuk＠redhat.com 08 Nov '15

08 Nov '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support recursive remove of cinder volumes. ...................................................................... core: Support recursive remove of cinder volumes. Implementing a recursive way to remove Cinder volumes. As part of this implementation the behviour should be as follow: When trying to remove a Cinder disk we aggragate all the volumes of the Cinder disk, snapshots and Cinder volumes (commited snapshots). Then we execute them one at a time, if there is a failure in the middle we change the disk status to illegal and fail the command. Once an illegal Cinder disk is being removed we only remove the Cinder disk and its volumes from the DB, without removing it from the Cinder provider. Change-Id: Icc5c19c0fa06f2fb40423072e609b3c0ca7f28f3 Bug-Url: https://bugzilla.redhat.com/1278126 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreFromCinderSnapshotCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java 5 files changed, 293 insertions(+), 200 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/46042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5c19c0fa06f2fb40423072e609b3c0ca7f28f3 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Audit log on remove disk should be on failure.
by mlipchuk＠redhat.com 08 Nov '15

08 Nov '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Audit log on remove disk should be on failure. ...................................................................... core: Audit log on remove disk should be on failure. On remove disk failure, an audit log should still be performed regardless to the flag shouldBeLogged. Also, when removing a VM with Cinder disks set the log flag to false, since the remove of the VM should already log this action. Change-Id: I831f7bb78ce53586ce4eca1edd61540345536218 Bug-Url: https://bugzilla.redhat.com/1278126 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/48225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I831f7bb78ce53586ce4eca1edd61540345536218 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Support remove for Cinder volume.
by mlipchuk＠redhat.com 08 Nov '15

08 Nov '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support remove for Cinder volume. ...................................................................... core: Support remove for Cinder volume. Adding a new command to support only remove of Cinder volume. Change-Id: I2a2441480a485436ea85f25679e769333d24c3d7 Bug-Url: https://bugzilla.redhat.com/1278126 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskVolumeCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskVolumeCommandCallback.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskVolumeParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 4 files changed, 178 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/47985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a2441480a485436ea85f25679e769333d24c3d7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Add VF icon and PF name for VF nics
by alkaplan＠redhat.com 08 Nov '15

08 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add VF icon and PF name for VF nics ...................................................................... webadmin: Add VF icon and PF name for VF nics Add VF icon and PF name for VF nics in Setup network dialog. Change-Id: Iba8ec1246d5c3a3c12d06af7899d61b34efdcf06 Bug-Url: https://bugzilla.redhat.com/1202118 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/BondNetworkInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkInterfaceModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/nic_vfunc.png 9 files changed, 90 insertions(+), 21 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/47710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba8ec1246d5c3a3c12d06af7899d61b34efdcf06 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: add GetAllVfsConfigByHostIdQuery
by alkaplan＠redhat.com 08 Nov '15

08 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: add GetAllVfsConfigByHostIdQuery ...................................................................... engine: add GetAllVfsConfigByHostIdQuery Make possible to know what PF NICs the VF NICs rely on. Change-Id: Id598599ba6e8b1a2789b9489fa40076825c0db34 Bug-Url: https://bugzilla.redhat.com/1202118 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVfToPfMapByHostIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImpl.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVfToPfMapByHostIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImplTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 7 files changed, 295 insertions(+), 36 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/47096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id598599ba6e8b1a2789b9489fa40076825c0db34 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: add missing MockitoJUnitRunner annotation
by amureini＠redhat.com 07 Nov '15

07 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: backend: add missing MockitoJUnitRunner annotation ...................................................................... backend: add missing MockitoJUnitRunner annotation To be consistent with our testing conventions, and although initMocks is already called by BaseCommandTest.setUpSessionDataContainer, this patch adds the MockitoJUnitRunner annotation to GetAncestorImagesByImagesIdsQueryTest. Change-Id: I88e9bbd3cb46aab7da99aee431fa781863321af4 Bug-Url: https://bugzilla.redhat.com/1257240 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAncestorImagesByImagesIdsQueryTest.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e9bbd3cb46aab7da99aee431fa781863321af4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Adding appliance publishing
by dcaro＠redhat.com 06 Nov '15

06 Nov '15

David Caro has submitted this change and it was merged. Change subject: Adding appliance publishing ...................................................................... Adding appliance publishing Change-Id: I880f17216b2d648b7617bf20cfcdab799be6bfd8 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47703 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I880f17216b2d648b7617bf20cfcdab799be6bfd8 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Fixed issue with the groups inside mock
by dcaro＠redhat.com 06 Nov '15

06 Nov '15

David Caro has submitted this change and it was merged. Change subject: Fixed issue with the groups inside mock ...................................................................... Fixed issue with the groups inside mock It was very unlikely, but when a new group is created inside mock and it turns out to have the same id than the one of the user running mock, it will wrongly try to add it again. Change-Id: Ic92721d6201e82b1566cfa5cee919780e7200abc Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: David Caro: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/48203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic92721d6201e82b1566cfa5cee919780e7200abc Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0