- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: extapi: extmap: do not cast to default type class
by masayag＠redhat.com 09 Nov '15

09 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: extapi: extmap: do not cast to default type class ...................................................................... extapi: extmap: do not cast to default type class default type can be different subclass of the spec type and may cause casting exception. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1279589 Change-Id: Id6a07149189a9316acc1985b2cc496a439efccfe Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuthzGroupsByUserIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableNamespacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupsForUserQuery.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java 6 files changed, 14 insertions(+), 12 deletions(-) Approvals: Alon Bar-Lev: Verified Ondra Machacek: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6a07149189a9316acc1985b2cc496a439efccfe Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: configure: increase release
by dougsland＠redhat.com 09 Nov '15

09 Nov '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: configure: increase release ...................................................................... configure: increase release Change-Id: I178151a156bcfe1cd53f3421860b104d9258d2d4 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/48320 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I178151a156bcfe1cd53f3421860b104d9258d2d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: mock_runner: in case of no logs, say so
by dcaro＠redhat.com 09 Nov '15

09 Nov '15

David Caro has submitted this change and it was merged. Change subject: mock_runner: in case of no logs, say so ...................................................................... mock_runner: in case of no logs, say so Until now, it just failed with 'file not found' when there was an error and there were no logs yet written to disk Change-Id: Ie919822134dba057fa529cb6b96d7c42eb80e2ea Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge David Caro: Verified; Passed CI tests; Ready for review -- To view, visit https://gerrit.ovirt.org/48205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie919822134dba057fa529cb6b96d7c42eb80e2ea Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Run Once dialog > Host: widgets alignment
by tjelinek＠redhat.com 09 Nov '15

09 Nov '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Run Once dialog > Host: widgets alignment ...................................................................... webadmin: Run Once dialog > Host: widgets alignment Vertical alignment of widgets in Run Once dialog, Host part Change-Id: I3f0cc01d1f744be069037a4df550e108692fd070 Bug-Url: https://bugzilla.redhat.com/1269092 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f0cc01d1f744be069037a4df550e108692fd070 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Cluster dialog - ja_JP locale adjustment
by tjelinek＠redhat.com 09 Nov '15

09 Nov '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Cluster dialog - ja_JP locale adjustment ...................................................................... webadmin: Cluster dialog - ja_JP locale adjustment Cluster new/edit dialog > tab console > label 'Define SPICE proxy for Cluster' - infoicon moved to prevent label wrapping. Change-Id: Ie2796a17ec748e24036298366a74dbcaeb562860 Bug-Url: https://bugzilla.redhat.com/1268814 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2796a17ec748e24036298366a74dbcaeb562860 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: Restart hosted engine services after unclean shutdown too
by msivak＠redhat.com 09 Nov '15

09 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: Restart hosted engine services after unclean shutdown too ...................................................................... Restart hosted engine services after unclean shutdown too Restart: on-abnormal does not catch error return codes, only true exceptions. Turns out we do so much error handling ourselves that we need to restart on clean shutdown with error code too. Change-Id: Iaeed22a803be2fff562fc41a1d86cd743d1c77f5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1030441 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M initscripts/ovirt-ha-agent.service M initscripts/ovirt-ha-broker.service 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaeed22a803be2fff562fc41a1d86cd743d1c77f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal: Attach disk to VM window does not open
by tnisan＠redhat.com 09 Nov '15

09 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal: Attach disk to VM window does not open ...................................................................... userportal: Attach disk to VM window does not open Since add a disk and attach disk windows has been separated both in webadmin and in userportal in commit e0e2161014bf6971fab9ce33f783b57b343fa7cb the attach window did not open in userportal since it was not added to the provider, this is fixed in this patch Change-Id: Ib8dd843017d0eaa8631abb36597199cee236b3c7 Bug-Url: https://bugzilla.redhat.com/1279208 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/VmDiskListModelProvider.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8dd843017d0eaa8631abb36597199cee236b3c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: UI: sysprep attached by default in run once dialog.
by shavivi＠redhat.com 09 Nov '15

09 Nov '15

Shahar Havivi has submitted this change and it was merged. Change subject: UI: sysprep attached by default in run once dialog. ...................................................................... UI: sysprep attached by default in run once dialog. Needs to attach on the first run only if there is sysprep data. Change-Id: I75a1bc4dce36337d14baeae8101b803706d2fd27 Bug-Url: https://bugzilla.redhat.com/1240900 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48283 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75a1bc4dce36337d14baeae8101b803706d2fd27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Invoke UpgradeOvirtNodeCommand when image is provided
by oourfali＠redhat.com 09 Nov '15

09 Nov '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Invoke UpgradeOvirtNodeCommand when image is provided ...................................................................... engine: Invoke UpgradeOvirtNodeCommand when image is provided When /api/hosts/{host:id}/install action is invoked for ovirt-node, and the user provides also an image, the desired action should be an upgrade of the ovirt-node to the specified image. For that to happen, the invoked command by the backend should be UpgradeOvirtNodeCommand. Bug-Url: https://bugzilla.redhat.com/1279461 Change-Id: I53044e77e647882a8775c2bee7599eb220ad0f4e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ori Liel: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/48281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53044e77e647882a8775c2bee7599eb220ad0f4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Invoke UpgradeOvirtNodeCommand when image is provided
by oourfali＠redhat.com 09 Nov '15

09 Nov '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Invoke UpgradeOvirtNodeCommand when image is provided ...................................................................... engine: Invoke UpgradeOvirtNodeCommand when image is provided When /api/hosts/{host:id}/install action is invoked for ovirt-node, and the user provides also an image, the desired action should be an upgrade of the ovirt-node to the specified image. For that to happen, the invoked command by the backend should be UpgradeOvirtNodeCommand. Bug-Url: https://bugzilla.redhat.com/1278467 Change-Id: I53044e77e647882a8775c2bee7599eb220ad0f4e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ori Liel: Looks good to me, approved Moti Asayag: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53044e77e647882a8775c2bee7599eb220ad0f4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0