- Engine-commits - oVirt List Archives

Change in ovirt-live[ovirt-live-3.5]: build: ovirt-live-3.5.6_rc2
by sbonazzo＠redhat.com 05 Nov '15

05 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.5.6_rc2 ...................................................................... build: ovirt-live-3.5.6_rc2 Change-Id: Ic7f797e797e328181d41cf3c3831daf3fb0e3e5a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f797e797e328181d41cf3c3831daf3fb0e3e5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Fix NPE when break bond and remove label from it in ...
by tnisan＠redhat.com 05 Nov '15

05 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Fix NPE when break bond and remove label from it in one action ...................................................................... engine: Fix NPE when break bond and remove label from it in one action Bug-Url: https://bugzilla.redhat.com/1275717 Change-Id: I96f7918d5424d3f4684e82d5f9be8c64ed91ac68 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit cfa9d5feb21dbcca438f60ec967f332743ef8dc2) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96f7918d5424d3f4684e82d5f9be8c64ed91ac68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: unable to add/remove slaves from bond using rest api
by juan.hernandez＠redhat.com 05 Nov '15

05 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: unable to add/remove slaves from bond using rest api ...................................................................... restapi: unable to add/remove slaves from bond using rest api A bug in the rest api did not allow to: -add new slaves to a bond using the slave id -specify exising slaves which are to remains in a bond using the slave name -remove existing slaves from a bond by either name or id Another problem was that specyfing an existing slave in a rest request caused the engine to try and add the slave again. Change-Id: I9c55817d94e85fc10a33971043487dcad2c2c5af Bug-Url: https://bugzilla.redhat.com/1262275 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c55817d94e85fc10a33971043487dcad2c2c5af Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Build the Java SDK in Fedora 23
by sbonazzo＠redhat.com 05 Nov '15

05 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Build the Java SDK in Fedora 23 ...................................................................... Build the Java SDK in Fedora 23 This patch changes the Java SDK build job so that it is built in Fedora 23 in addition to the distributions where it is currently built. Change-Id: I5d310de73cd13581690b71adba46e0e22f44d323 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_create-rpms.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d310de73cd13581690b71adba46e0e22f44d323 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Reformatting vm_templates_sp.sql
by tjelinek＠redhat.com 05 Nov '15

05 Nov '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Reformatting vm_templates_sp.sql ...................................................................... core: Reformatting vm_templates_sp.sql Reformatting of UpdateVmTemplateShiftBaseTemplate function in UpdateVmTemplateShiftBaseTemplate Change-Id: Ib9cd67fe5a23c0979fc87bdde44fea9012182b16 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/dbscripts/vm_templates_sp.sql 1 file changed, 10 insertions(+), 9 deletions(-) Approvals: Jakub Niedermertl: Verified Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9cd67fe5a23c0979fc87bdde44fea9012182b16 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: new key dialog - tool-tip for UUID text-box
by tnisan＠redhat.com 05 Nov '15

05 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: new key dialog - tool-tip for UUID text-box ...................................................................... webadmin: new key dialog - tool-tip for UUID text-box Cinder provider -> Authentication Keys -> New Dialog: added a tool-tip with explanation for UUID text-box. Change-Id: I288095208041393638101221f375cd298a4e1d3c Bug-Url: https://bugzilla.redhat.com/1273885 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/EnableableFormLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderSecretPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderSecretPopupView.ui.xml 4 files changed, 26 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I288095208041393638101221f375cd298a4e1d3c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Fix NPE when break bond and remove label from it in ...
by alkaplan＠redhat.com 05 Nov '15

05 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Fix NPE when break bond and remove label from it in one action ...................................................................... engine: Fix NPE when break bond and remove label from it in one action Bug-Url: https://bugzilla.redhat.com/1275717 Change-Id: I96f7918d5424d3f4684e82d5f9be8c64ed91ac68 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96f7918d5424d3f4684e82d5f9be8c64ed91ac68 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Bonding modes 0, 5 and 6 should be avoided for VM ne...
by alkaplan＠redhat.com 05 Nov '15

05 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Bonding modes 0, 5 and 6 should be avoided for VM networks ...................................................................... engine: Bonding modes 0, 5 and 6 should be avoided for VM networks Bonds with bonding modes 0, 5 and 6 should be prohibited from having vm networks. This patch modifies the HostSetupNetworkValidator not to allow to attach a vm network to a bond with such bonding options, and also prohibits to change the bonding options to such if a vm network is attached. Change-Id: Ie83b633b36de7985df42bc019e602d5f2fbd25dc Bug-Url: https://bugzilla.redhat.com/1094842 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 234 insertions(+), 2 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie83b633b36de7985df42bc019e602d5f2fbd25dc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: BondMode refactoring
by alkaplan＠redhat.com 05 Nov '15

05 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: BondMode refactoring ...................................................................... engine: BondMode refactoring Refactoring for BondMode Change-Id: I094d6a7388c06921d045be4f54735c2d52b1138a Bug-Url: https://bugzilla.redhat.com/1094842 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/network/BondModeTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksJoinBondsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java 5 files changed, 115 insertions(+), 31 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I094d6a7388c06921d045be4f54735c2d52b1138a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Bonding modes 0, 5 and 6 should be avoided for VM ...
by alkaplan＠redhat.com 05 Nov '15

05 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Bonding modes 0, 5 and 6 should be avoided for VM networks ...................................................................... webadmin: Bonding modes 0, 5 and 6 should be avoided for VM networks Bonds with bonding modes 0, 5 and 6 should be prohibited from having vm networks. This patch modifies the setup networks dialog not to allow to attach a vm network to a bond with such bonding options, and also prohibits to change the bonding options to such if a vm network is attached. Change-Id: I9bc5f0da68ce8cc55bda1c7aaf8568e7bbd9bda0 Bug-Url: https://bugzilla.redhat.com/1094842 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksAddBondModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksEditBondModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksJoinBondsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 10 files changed, 87 insertions(+), 16 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bc5f0da68ce8cc55bda1c7aaf8568e7bbd9bda0 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0