- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Introduce isEqual and hashCode methods of Validati...
by derez＠redhat.com 02 Nov '15

02 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Introduce isEqual and hashCode methods of ValidationResult ...................................................................... webadmin: Introduce isEqual and hashCode methods of ValidationResult Adding isEqual for testing purposes. Will enable to compare both success indicator and reasons. Change-Id: I3d01e92813664d96a347e06bc7e3148cbe0ad2db Bug-Url: https://bugzilla.redhat.com/1270563 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ValidationResult.java 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Eliraz Levi: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d01e92813664d96a347e06bc7e3148cbe0ad2db Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: packaging: windows spec: Remove 'artifacts' from paths
by vfeenstr＠redhat.com 02 Nov '15

02 Nov '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: packaging: windows spec: Remove 'artifacts' from paths ...................................................................... packaging: windows spec: Remove 'artifacts' from paths Change all /usr/share/artifacts to /usr/share. See: https://gerrit.ovirt.org/47771 - spice-nsis aka ovirt-wgt https://gerrit.ovirt.org/47460 - ovirt-wgt-toolchain https://gerrit.ovirt.org/47461 - ovirt-guest-agent Change-Id: Ia95c93d7399758fe4ae6bbf22219065b7a58c4ae Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-guest-agent-windows.spec 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/47461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia95c93d7399758fe4ae6bbf22219065b7a58c4ae Gerrit-PatchSet: 6 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fix migration policy update for running VM
by rgolan＠redhat.com 02 Nov '15

02 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: webadmin: Fix migration policy update for running VM ...................................................................... webadmin: Fix migration policy update for running VM Problem description: -------------------- When a VM is running and its migration policy is pinned. Change the migration policy to migrateable allows the running VM to migrate to another host. This behavior is a security threat, passing information from the pinned host to the migration target. And migration could fail due to incompatible target host. Desired behavior: ----------------- When a VM is running and changing migration policy from pinned to Migrateable (manual or automatic). - Provide warning and UX indicator. - If user confirms proceed with normal update. Implementation: -------------- 1. Replace @EditableOnVmStatusField with @EditableField to fields {dedicatedVmForVdsList, migrationSupport} (VmBase.java). Disable (vm restart requirement), when updating dedicated hosts field or updating migrationSupport field. 2. Redesign VmNextRunConfiguration UI to display warnning if running VM is unpinned. Modify VmListModel.java to append warning into VmNextRunConfigurationModel.java . Also Modify VmNextRunConfiguration layout and widget to display selective information (coresponding to updated fields). Change-Id: Idcc9c120606ebe5bc55803213065124f44972e0b Bug-Url: https://bugzilla.redhat.com/1058384 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java 9 files changed, 165 insertions(+), 45 deletions(-) Approvals: Dudi Maroshi: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47673 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcc9c120606ebe5bc55803213065124f44972e0b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix detection of preferred hosts for numa nodes
by rgolan＠redhat.com 02 Nov '15

02 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: core: Fix detection of preferred hosts for numa nodes ...................................................................... core: Fix detection of preferred hosts for numa nodes This fixes two things: When adding new numa nodes through the rest api or the numa support dialog in the host context menu, the detection of the preferred hosts failed in AddVmNumaNodesCommand#canDoAction. When creating or updating VMs, the first time the admin switched to "non migratable", the detection of the preferred hosts failed. This led to the situation where the whole VM was created, except for the numa nodes. When updating a VM all numa nodes were deleted and could not be added again. So the whole numa configuration disappeared. Bug-Url: https://bugzilla.redhat.com/1248049 Bug-Url: https://bugzilla.redhat.com/1256725 Change-Id: I1f72bbe131402f2037f6083c236864b5a2d3ac62 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java 2 files changed, 141 insertions(+), 1 deletion(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f72bbe131402f2037f6083c236864b5a2d3ac62 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename "OpenStack*Resource" to "Openstack*Resource"
by juan.hernandez＠redhat.com 01 Nov '15

01 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename "OpenStack*Resource" to "Openstack*Resource" ...................................................................... restapi: Rename "OpenStack*Resource" to "Openstack*Resource" This is to stick to the name capitalization rules used in the RESTAPI. Change-Id: I4ad1734f8878fe1eeaef87d80cd9562678219e47 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ApiResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackImageProviderResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackImageProvidersResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackImageResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackImagesResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackNetworkProviderResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackNetworkProvidersResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackNetworkResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackNetworksResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackSubnetResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackSubnetsResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeAuthenticationKeyResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeAuthenticationKeysResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeProviderResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeProvidersResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeTypeResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeTypesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProviderResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProvidersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImagesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkProviderResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkProvidersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackSubnetResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackSubnetsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeAuthenticationKeyResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeAuthenticationKeysResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProviderResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProvidersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeTypeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeTypesResource.java 35 files changed, 128 insertions(+), 128 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ad1734f8878fe1eeaef87d80cd9562678219e47 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use POST instead of DELETE to remove multiple bricks
by juan.hernandez＠redhat.com 01 Nov '15

01 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use POST instead of DELETE to remove multiple bricks ...................................................................... restapi: Use POST instead of DELETE to remove multiple bricks The operation that removes multiple Gluster bricks was implemented using the "DELETE" method and passing the list of bricks as the body of the request: DELETE /clusters/{cluster:id}/glustervolumes/{volume:id}/bricks <bricks> <bricks id="..."/> <bricks id="..."/> ... </bricks> This is problematic because the "DELETE" method shouldn't have a body, so it has been replaced with a new "remove" action that uses the "POST" method: POST /clusters/{cluster:id}/glustervolumes/{volume:id}/bricks/remove <bricks> <bricks id="..."/> <bricks id="..."/> ... </bricks> Change-Id: I6743e19222142e2fb699265c8ba400e2935bae3a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBricksResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResourceTest.java 7 files changed, 46 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6743e19222142e2fb699265c8ba400e2935bae3a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename "SSHPublicKeyResource" to "SshPublicKeyResou...
by juan.hernandez＠redhat.com 01 Nov '15

01 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename "SSHPublicKeyResource" to "SshPublicKeyResource" ...................................................................... restapi: Rename "SSHPublicKeyResource" to "SshPublicKeyResource" This is to stick to the name capitalization rules used in the RESTAPI. Change-Id: I991adf1c5ff6c4ca97bfbdf6b5b004b1d2e27067 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/SshPublicKeyResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/SshPublicKeysResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/UserResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendSSHPublicKeyResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendSSHPublicKeysResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResource.java 6 files changed, 12 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I991adf1c5ff6c4ca97bfbdf6b5b004b1d2e27067 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename "cloneVm" to "clone"
by juan.hernandez＠redhat.com 01 Nov '15

01 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename "cloneVm" to "clone" ...................................................................... restapi: Rename "cloneVm" to "clone" This is to stick to the rule that says that the names of the methods of the JAX-RS interfaces are equal to the names of the actions, except where the result is a Java reserved word. Change-Id: Ie4ead6cad1a8d114e0f3d3a8c24bca536cc8ab4c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ead6cad1a8d114e0f3d3a8c24bca536cc8ab4c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use matrix parameter to force remove virtual machine
by juan.hernandez＠redhat.com 01 Nov '15

01 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use matrix parameter to force remove virtual machine ...................................................................... restapi: Use matrix parameter to force remove virtual machine The operation that removes a virtual machine supports a "force" parameter. In order to use it the "DELETE" method used to support an optional action parameter: DELETE /vms/{vm:id} <action> <force>true</force> </action> This patch replaces the action parameter with an optional matrix parameter: DELETE /vms/{vm:id};force=true Change-Id: I0a3c1e189d23e9171179135a3f3552380d9cfb34 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 5 files changed, 64 insertions(+), 46 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a3c1e189d23e9171179135a3f3552380d9cfb34 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use "detach_only" matrix parameter to detach VM disk
by juan.hernandez＠redhat.com 01 Nov '15

01 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use "detach_only" matrix parameter to detach VM disk ...................................................................... restapi: Use "detach_only" matrix parameter to detach VM disk The operation that removes a virtual machine disk supports a "detach" parameter. In order to use it the "DELETE" method supports an optional action parameter: DELETE /vms/{vm:id}/disks/{disk:id} <action> <detach>true</detach> </action> This patch remplaces the optional action parameter with an optional matrix parameter: DELETE /vms/{vm:id}/disks/{disk:id};detach_only=true Change-Id: Ie7f222bf2d4ba5be2d107d3f91eb0acbd5590288 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java 6 files changed, 41 insertions(+), 33 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7f222bf2d4ba5be2d107d3f91eb0acbd5590288 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0