- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Use matrix parameters to remove template disks
by juan.hernandez＠redhat.com 01 Nov '15

01 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use matrix parameters to remove template disks ...................................................................... restapi: Use matrix parameters to remove template disks The operation that removes a template disk supports the "force" and "storage_domain" parameters. In order to use it them the "DELETE" method supports an optional action parameter: DELETE /templates/{template:id}/disks/{disk:id} <action> <force>...</force> <storage_domain id="..."/> </action> This patch remplaces this optional action parameter with the optional matrix parameters "force" and "storage_domain", so the way to remove a template disk is now the following: DELETE /templates/{template:id}/disks/{disk:id};force=true DELETE /templates/{template:id}/disks/{disk:id};storage_domain=123 Change-Id: I7d527dcec4c819e70eea28339b2eab47894e8db7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDiskResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java 5 files changed, 67 insertions(+), 44 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d527dcec4c819e70eea28339b2eab47894e8db7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use matrix "host" parameter to remove storage serve...
by juan.hernandez＠redhat.com 01 Nov '15

01 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use matrix "host" parameter to remove storage server connection ...................................................................... restapi: Use matrix "host" parameter to remove storage server connection The operation that removes a storage server connection supports a "host" parameter. In order to use it the "DELETE" method uses an optional action parameter: DELETE /storageconnections/{storageconnection:id} <action> <host id="..."> <name>...</name> </host> </action> This patch remplaces the optional action parameter with an optional matrix parameter: DELETE /storageconnections/{storageconnection:id};host=myhost Change-Id: I3bad9f6f34cea4222dc1e0425a602c0d1fe31631 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResourceTest.java 5 files changed, 93 insertions(+), 55 deletions(-) Approvals: Juan Hernandez: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bad9f6f34cea4222dc1e0425a602c0d1fe31631 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: enhance log message in case of empty reason
by oourfali＠redhat.com 01 Nov '15

01 Nov '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: enhance log message in case of empty reason ...................................................................... core: enhance log message in case of empty reason Up to now when we got an empty reason on command failure we just append a "Not Specified" string to the original log message. This message was changed to a more friendly format : "No specific reason was returned for this operation failure, please investigate logs for details." Change-Id: I4f7eee36df6a158e7c9ac4d2f93f06144f25bf8c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1203741 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f7eee36df6a158e7c9ac4d2f93f06144f25bf8c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: remove ie8 GWT permutation
by tnisan＠redhat.com 01 Nov '15

01 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: remove ie8 GWT permutation ...................................................................... engine: remove ie8 GWT permutation Change-Id: Ie69b5b546ed418994809617a67baedb136a9d645 Bug-Url: https://bugzilla.redhat.com/1276510 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Alexander Wels: Looks good to me, approved Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/47909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie69b5b546ed418994809617a67baedb136a9d645 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Refactor Create Volume with initial size
by amureini＠redhat.com 01 Nov '15

01 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Refactor Create Volume with initial size ...................................................................... engine: Refactor Create Volume with initial size Refactor the Create Volume interface with initial size to one method instead of two. Change-Id: If7db8ad8a95fec0eb980daa5e986b5e627717f8e Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 5 files changed, 26 insertions(+), 73 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/47730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7db8ad8a95fec0eb980daa5e986b5e627717f8e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: invoke connectStorageServers for Cinder domains
by tnisan＠redhat.com 01 Nov '15

01 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: invoke connectStorageServers for Cinder domains ...................................................................... core: invoke connectStorageServers for Cinder domains On e07565966a75801fdb250ceeb4a686c1c004ccb8, secrets registration logic was removed from ConnectHostToStoragePoolServersCommand based on the assumption that a storage_server_connection should exist for all storage domains. However, no connection is created for Cinder domains, hence, 'connectStorageServersByType' should be invoked directly. Change-Id: If2f0c10fd1cb243631036087d9f5169f38d42ad8 Bug-Url: https://bugzilla.redhat.com/1276915 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2f0c10fd1cb243631036087d9f5169f38d42ad8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: core: fixing NPE when importing nic with null valued mac
by tnisan＠redhat.com 01 Nov '15

01 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fixing NPE when importing nic with null valued mac ...................................................................... core: fixing NPE when importing nic with null valued mac Error fix of bug introduced by: 779d378e2b51510b54950e8f1f384382bfc956a5 In former code (prior to mentioned erroneous patch) was null valued mac used to gather nics from db, which indeed return no nics, thus no match was found and true returned. With removal of this call error was made; when mac of passed in nic is null, true must be returned. Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b Bug-Url: https://bugzilla.redhat.com/1270003 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fixing NPE when importing nic with null valued mac
by tnisan＠redhat.com 01 Nov '15

01 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fixing NPE when importing nic with null valued mac ...................................................................... core: fixing NPE when importing nic with null valued mac Error fix of bug introduced by: 779d378e2b51510b54950e8f1f384382bfc956a5 In former code (prior to mentioned erroneous patch) was null valued mac used to gather nics from db, which indeed return no nics, thus no match was found and true returned. With removal of this call error was made; when mac of passed in nic is null, true must be returned. Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b Bug-Url: https://bugzilla.redhat.com/1270003 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47932 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fixing NPE when importing nic with null valued mac
by alkaplan＠redhat.com 01 Nov '15

01 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: fixing NPE when importing nic with null valued mac ...................................................................... core: fixing NPE when importing nic with null valued mac Error fix of bug introduced by: 779d378e2b51510b54950e8f1f384382bfc956a5 In former code (prior to mentioned erroneous patch) was null valued mac used to gather nics from db, which indeed return no nics, thus no match was found and true returned. With removal of this call error was made; when mac of passed in nic is null, true must be returned. Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b Bug-Url: https://bugzilla.redhat.com/1270003 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: invoke connectStorageServers for Cinder domains
by derez＠redhat.com 01 Nov '15

01 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: core: invoke connectStorageServers for Cinder domains ...................................................................... core: invoke connectStorageServers for Cinder domains On e07565966a75801fdb250ceeb4a686c1c004ccb8, secrets registration logic was removed from ConnectHostToStoragePoolServersCommand based on the assumption that a storage_server_connection should exist for all storage domains. However, no connection is created for Cinder domains, hence, 'connectStorageServersByType' should be invoked directly. Change-Id: If2f0c10fd1cb243631036087d9f5169f38d42ad8 Bug-Url: https://bugzilla.redhat.com/1276915 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2f0c10fd1cb243631036087d9f5169f38d42ad8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0