- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: reimplementing getImagesList cause vdsm one is broken
by sbonazzo＠redhat.com 02 Nov '15

02 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: upgrade: reimplementing getImagesList cause vdsm one is broken ...................................................................... upgrade: reimplementing getImagesList cause vdsm one is broken VDSM getImagesList raises an 'list index out of range' exception if called on a storage domain witch is not connected to any SP. Change-Id: I3b014029e9a820ea6bbb038786502778e00ea679 Bug-Url: https://bugzilla.redhat.com/1276650 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 1776e0843895f0e3b3c512bda5e2454305b9c4d2) --- M ovirt_hosted_engine_ha/lib/heconflib.py M ovirt_hosted_engine_ha/lib/upgrade.py 2 files changed, 31 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b014029e9a820ea6bbb038786502778e00ea679 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: add warning for CD passthrough
by sbonazzo＠redhat.com 02 Nov '15

02 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: add warning for CD passthrough ...................................................................... packaging: setup: add warning for CD passthrough Provide a warning for the administrator that CD/DVD passthrough is disabled in RHEL7 and that the only option to boot hosted engine VM, for cdrom based installations, is from an ISO image. Upstream bug report: https://bugzilla.redhat.com/760885 Change-Id: I2b10b6b28044d135bf30ab26d07e77686e687d52 Bug-Url: https://bugzilla.redhat.com/1247068 Signed-off-by: Ivan Bulatovic <combuster(a)gmail.com> (cherry picked from commit f69b8ea2757c99e5d89f9bc24d24c51813de4bec) --- M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b10b6b28044d135bf30ab26d07e77686e687d52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: add warning for CD passthrough
by sbonazzo＠redhat.com 02 Nov '15

02 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: add warning for CD passthrough ...................................................................... packaging: setup: add warning for CD passthrough Provide a warning for the administrator that CD/DVD passthrough is disabled in RHEL7 and that the only option to boot hosted engine VM, for cdrom based installations, is from an ISO image. Upstream bug report: https://bugzilla.redhat.com/760885 Change-Id: I2b10b6b28044d135bf30ab26d07e77686e687d52 Bug-Url: https://bugzilla.redhat.com/1247068 Signed-off-by: Ivan Bulatovic <combuster(a)gmail.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b10b6b28044d135bf30ab26d07e77686e687d52 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Ivan Bulatović <combuster(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Fix NPE when processing NUMA info that lacks distances
by rgolan＠redhat.com 02 Nov '15

02 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: Fix NPE when processing NUMA info that lacks distances ...................................................................... Fix NPE when processing NUMA info that lacks distances This code fakes distances between NUMA nodes to allow adding a host with broken NUMA support and still properly show the nodes in the UI. Change-Id: I0545a65c0b32a12ca7dd617a9e35199b31ad0093 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252055 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45652 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0545a65c0b32a12ca7dd617a9e35199b31ad0093 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Windows 10 requires special CPU
by ahadas＠redhat.com 02 Nov '15

02 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: core: Windows 10 requires special CPU ...................................................................... core: Windows 10 requires special CPU Because of BSOD: SYSTEM_THREAD_EXCEPTION_NOT_HANDLES, running guest OS Windows 10 is limited westmere+ CPUs This patch makes RunVmCommand to respect 'cpu.unsupported' entries in osinfo-defaults.properties file. Change-Id: Iaa53264e12d8f80562987ea5bfa131e91d5737b2 Bug-Url: https://bugzilla.redhat.com/1275810 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerRule.java M packaging/conf/osinfo-defaults.properties 4 files changed, 104 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa53264e12d8f80562987ea5bfa131e91d5737b2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: IntegerValidation refactor
by derez＠redhat.com 02 Nov '15

02 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: engine: IntegerValidation refactor ...................................................................... engine: IntegerValidation refactor Refactoring the class to use the generic NumberRangeValidation implementation Change-Id: Iccec7ca9bdaa1601104b04d5651e3ecb5f888593 Bug-Url: https://bugzilla.redhat.com/1270563 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IntegerValidation.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/IntegerValidationTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 5 files changed, 90 insertions(+), 78 deletions(-) Approvals: Eliraz Levi: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccec7ca9bdaa1601104b04d5651e3ecb5f888593 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Remove useless map in "VmManagementCommandBase"
by tnisan＠redhat.com 02 Nov '15

02 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove useless map in "VmManagementCommandBase" ...................................................................... core: Remove useless map in "VmManagementCommandBase" This is needed in order to avoid the following findbugs warning: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed. This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT Bug-Url: https://bugzilla.redhat.com/1256657 Change-Id: I6e773e3a1ae8d901d9d6e3e9a09c3942447c923f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java 1 file changed, 18 insertions(+), 35 deletions(-) Approvals: Roman Mohr: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e773e3a1ae8d901d9d6e3e9a09c3942447c923f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Icons validation reworked
by tnisan＠redhat.com 02 Nov '15

02 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Icons validation reworked ...................................................................... webadmin: Icons validation reworked Icons are now validated inside IconEditorWidget and the ValidationResult is passed to UnitVmModel inside IconWithOsDefault. This allows to run validations utilizing <img> element that loads images anynchronously in Firefox and IE. Change-Id: I068f23e27adde1909296589a845a2f63ef36f692 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1252059 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/IconVmBaseToUnitBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IconWithOsDefault.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IconValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IconWithOsDefaultValidation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 8 files changed, 218 insertions(+), 143 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47955 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I068f23e27adde1909296589a845a2f63ef36f692 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: boolean params not always parsed well f...
by tjelinek＠redhat.com 02 Nov '15

02 Nov '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: boolean params not always parsed well for browser plugins ...................................................................... userportal,webadmin: boolean params not always parsed well for browser plugins The GWT JSNI sometimes returns the boolean as int and it needs to be casted back to boolean Change-Id: I715bae32006945ce5faa49402832742f25ac5e8e https://bugzilla.redhat.com/show_bug.cgi?id=1272181 https://bugzilla.redhat.com/show_bug.cgi?id=1273031 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 12 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715bae32006945ce5faa49402832742f25ac5e8e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: post ovirt-hosted-engine-ha-1.3.1
by msivak＠redhat.com 02 Nov '15

02 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.3.1 ...................................................................... build: post ovirt-hosted-engine-ha-1.3.1 Change-Id: I5eb99906e7526e9a578256a93ffc7ea0888802af Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5eb99906e7526e9a578256a93ffc7ea0888802af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0