- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Rename "CdRom" to "Cdrom"
by juan.hernandez＠redhat.com 02 Oct '15

02 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename "CdRom" to "Cdrom" ...................................................................... restapi: Rename "CdRom" to "Cdrom" This is to increase the consistency between the names of the complex types and the names of the elements. In this case the name of the element is "cdrom", a single word, and it is better for backwards compatibility to change the name of the type than to change the name of the element. Change-Id: Ifb642144312401688a4ceec3749223a44fdd53ea Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/LinkHelperTest.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CdRomResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/SnapshotCdRomResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/SnapshotCdRomsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyCdRomsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotCdRomResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotCdRomsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCdRomsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCdRomsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyCdRomResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/CdRomMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/CdRomMapperTest.java 24 files changed, 139 insertions(+), 138 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb642144312401688a4ceec3749223a44fdd53ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename "WatchDog" to "Watchdog"
by juan.hernandez＠redhat.com 02 Oct '15

02 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename "WatchDog" to "Watchdog" ...................................................................... restapi: Rename "WatchDog" to "Watchdog" This is to increase the consistency between the names of the complex types and the names of the elements. In this case the name of the element is "watchdog", a single word, and it is better for backwards compatibility to change the name of the type than to change the name of the element. Change-Id: I0f72725680fe849fed4b6a336c32d9fe6766b3ee Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/WatchdogResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/WatchdogsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/WatchdogValidator.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendWatchdogsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/validation/WatchdogValidatorTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/WatchdogMapperTest.java 15 files changed, 74 insertions(+), 72 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f72725680fe849fed4b6a336c32d9fe6766b3ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: packaging: setup: using versionlock for ovirt-engine-wildfly
by piotr.kliczewski＠gmail.com 02 Oct '15

02 Oct '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: using versionlock for ovirt-engine-wildfly ...................................................................... packaging: setup: using versionlock for ovirt-engine-wildfly Using versionlock to prevent unwanted updates of ovirt-engine-wildfly rpms. Fixing the behaviour of tolist helper function on empty strings. Conflict ovirt-engine-wildfly >= 9 Change-Id: I2b56d985c2c8bb6eda34508397ce271519fd7f2b Bug-Url: https://bugzilla.redhat.com/1264435 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/bin/ovirt-engine-upgrade-check M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/packages.py 6 files changed, 60 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b56d985c2c8bb6eda34508397ce271519fd7f2b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: using versionlock for ovirt-engine-wildfly
by piotr.kliczewski＠gmail.com 02 Oct '15

02 Oct '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: using versionlock for ovirt-engine-wildfly ...................................................................... packaging: setup: using versionlock for ovirt-engine-wildfly Using versionlock to prevent unwanted updates of ovirt-engine-wildfly rpms. Fixing the behaviour of tolist helper function on empty strings. Conflict ovirt-engine-wildfly >= 9 Change-Id: I2b56d985c2c8bb6eda34508397ce271519fd7f2b Bug-Url: https://bugzilla.redhat.com/1264435 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/bin/ovirt-engine-upgrade-check M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/packages.py 6 files changed, 60 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b56d985c2c8bb6eda34508397ce271519fd7f2b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: ovirt-engine_upgrade_to_*: add missing key
by sbonazzo＠redhat.com 02 Oct '15

02 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine_upgrade_to_*: add missing key ...................................................................... ovirt-engine_upgrade_to_*: add missing key add missing OVESETUP_VMCONSOLE_PROXY_CONFIG/vmconsoleProxyConfig=bool:True Change-Id: Ic1dcf444522106479d0f207aba8518f5067fd0d6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/ovirt-engine_upgrade_to_3.6/setup.file.otopi M jobs/ovirt-engine_upgrade_to_master/setup.file.otopi 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/46926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1dcf444522106479d0f207aba8518f5067fd0d6 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1001064 Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Re-selection of the same icon works in IE and Chrome
by piotr.kliczewski＠gmail.com 01 Oct '15

01 Oct '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Re-selection of the same icon works in IE and Chrome ...................................................................... webadmin: Re-selection of the same icon works in IE and Chrome In IE and Chrome <input type="file"> only fires 'change' event if the new files selection differes from the previous selection. This behaviour causes that one can't 1. select custom icons, 2. use default icon, 3. re-select the same custom icon The solution is creating new <input> tag for each upload invocation. Change-Id: I8455c45c5126409d37d3469d0b67a1c752c94f40 Bug-Url: https://bugzilla.redhat.com/1267711 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.ui.xml 2 files changed, 17 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8455c45c5126409d37d3469d0b67a1c752c94f40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: relying on %{jboss} variable
by sbonazzo＠redhat.com 01 Oct '15

01 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: relying on %{jboss} variable ...................................................................... packaging: setup: relying on %{jboss} variable Relying on %{jboss} global variable to make downstream customization easier. Change-Id: Ibcfa513722303aceebf84df3c4414ca1abf06507 Bug-Url: https://bugzilla.redhat.com/1264435 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcfa513722303aceebf84df3c4414ca1abf06507 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Re-selection of the same icon works in IE and Chrome
by tjelinek＠redhat.com 01 Oct '15

01 Oct '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Re-selection of the same icon works in IE and Chrome ...................................................................... webadmin: Re-selection of the same icon works in IE and Chrome In IE and Chrome <input type="file"> only fires 'change' event if the new files selection differes from the previous selection. This behaviour causes that one can't 1. select custom icons, 2. use default icon, 3. re-select the same custom icon The solution is creating new <input> tag for each upload invocation. Change-Id: I8455c45c5126409d37d3469d0b67a1c752c94f40 Bug-Url: https://bugzilla.redhat.com/1267711 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.ui.xml 2 files changed, 17 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8455c45c5126409d37d3469d0b67a1c752c94f40 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Don't generate Javadoc for findbugs plugin
by juan.hernandez＠redhat.com 01 Oct '15

01 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Don't generate Javadoc for findbugs plugin ...................................................................... core: Don't generate Javadoc for findbugs plugin This Javadoc is irrelevant, and it causes an inssue in the RPM packaging. Change-Id: Ide91d2b61180bc276aa9fa482341aeb4d5a359bf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M build-tools-root/ovirt-findbugs-maven-plugin/pom.xml 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide91d2b61180bc276aa9fa482341aeb4d5a359bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Icons validation reworked
by tjelinek＠redhat.com 01 Oct '15

01 Oct '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Icons validation reworked ...................................................................... webadmin: Icons validation reworked Icons are now validated inside IconEditorWidget and the ValidationResult is passed to UnitVmModel inside IconWithOsDefault. This allows to run validations utilizing <img> element that loads images anynchronously in Firefox and IE. Change-Id: I068f23e27adde1909296589a845a2f63ef36f692 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1267228 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/IconVmBaseToUnitBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IconWithOsDefault.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IconValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IconWithOsDefaultValidation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 8 files changed, 218 insertions(+), 143 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I068f23e27adde1909296589a845a2f63ef36f692 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0