- Engine-commits - oVirt List Archives

Change in jenkins[master]: ovirt-engine_standard: added branch 3.6.0
by sbonazzo＠redhat.com 29 Sep '15

29 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine_standard: added branch 3.6.0 ...................................................................... ovirt-engine_standard: added branch 3.6.0 Change-Id: I7a9dde82c7b21c18b4ac9d1ee090bfae26b69ad5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a9dde82c7b21c18b4ac9d1ee090bfae26b69ad5 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: pythonlib: service: by default redirect to /dev/n...
by sbonazzo＠redhat.com 29 Sep '15

29 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: pythonlib: service: by default redirect to /dev/null stdout/stderr ...................................................................... packaging: pythonlib: service: by default redirect to /dev/null stdout/stderr this avoid handle inheritance into the daemon process, enables detaching properly from the init.d parent. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1266881 Change-Id: I621a86647c2df1784e94cada25f8a907b5a2f3f3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/pythonlib/ovirt_engine/service.py M packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.py 2 files changed, 2 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I621a86647c2df1784e94cada25f8a907b5a2f3f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use "logical_units" instead of multiple "logical_unit"
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use "logical_units" instead of multiple "logical_unit" ...................................................................... restapi: Use "logical_units" instead of multiple "logical_unit" Currently the logical units that are part of a volume group are reported as an unbounded number of "logical_unit" elements. For example, when reporting the details of a storage domain: GET /storagedomains/{storagedomain:id} <storage_domain> ... <storage> ... <volume_group> <logical_unit>  </logical_unit> <logical_unit>  </logical_unit> ... </volume_group> </storage> </storage_domain> This is contrary to the usual practice in the API, as list of elements are always wrapped with an element. This has been fixed now, so the list of logical units will be wrapped with the "logical_units" element: GET /storagedomains/{storagedomain:id} <storage_domain> ... <storage> ... <volume_group> <logical_units> <logical_unit>  </logical_unit> <logical_unit>  </logical_unit> ... </logical_units> </volume_group> </storage> </storage_domain> Change-Id: I08a71b3ca7873cfee6dcd0d7b881ce6bae935581 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/DiskResourceUtils.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java 14 files changed, 315 insertions(+), 135 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08a71b3ca7873cfee6dcd0d7b881ce6bae935581 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename complex type "SupportedVersions" to "Versions"
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename complex type "SupportedVersions" to "Versions" ...................................................................... restapi: Rename complex type "SupportedVersions" to "Versions" The "supported" part of the name is an indication of what it is used for, not of what is its structure, and "Versions" is more consistent with the existig "Version" complex type. Change-Id: I3b7943dd4e041ccf14c15df9a9b5644d036ad11e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VersionMapper.java 4 files changed, 10 insertions(+), 9 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b7943dd4e041ccf14c15df9a9b5644d036ad11e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.6]: ovirt-live-3.6.0-rc1
by sbonazzo＠redhat.com 28 Sep '15

28 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-live-3.6.0-rc1 ...................................................................... ovirt-live-3.6.0-rc1 Change-Id: Ifb19786190659e266c2ef1c30d4e58e507b0654d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb19786190659e266c2ef1c30d4e58e507b0654d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add JAXB annotation to "custom_property" element
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add JAXB annotation to "custom_property" element ...................................................................... restapi: Add JAXB annotation to "custom_property" element This annotation is used to make sure that the name of the corresponding Java getter is "getCustomProperties", as this, plural, is what is used in the rest of the API. Change-Id: I6779bec2b34466b3a5d1e9e3372d348d1dca343e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VnicProfileMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VnicProfileMapperTest.java 8 files changed, 19 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6779bec2b34466b3a5d1e9e3372d348d1dca343e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename complex type "SPM" to "Spm"
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename complex type "SPM" to "Spm" ...................................................................... restapi: Rename complex type "SPM" to "Spm" This is required to make sure that there is only one rule for the names of complex types: all words, including acronyms, start with one upper case character and all the rest are lower case. Change-Id: I40cbc1803d80890ad7957373851820db823d0d47 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 3 files changed, 7 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40cbc1803d80890ad7957373851820db823d0d47 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin, userportal: Fix IE image size quirk
by piotr.kliczewski＠gmail.com 28 Sep '15

28 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin,userportal: Fix IE image size quirk ...................................................................... webadmin,userportal: Fix IE image size quirk IE automatically adds "width" and "height" attributes, with values taken from "src" image data, when an <img> element is created via Image constructor function. For example: var img = new Image(); img.src = "foo.png"; // adds "width" and "height" automatically document.body.appendChild(img); This causes render issues for images that use "src" attribute for initial placeholder image and CSS styling for the actual image. For example: <style> .fooImage { background: url("foo.png"); width: 400px; height: 200px; } </style> <img src="clear.cache.gif" class="fooImage"> In IE, above <img> element would have "width" and "height" attributes, with values from "clear.cache.gif" placeholder image, added automatically: <img src="clear.cache.gif" width="1" height="1" class="fooStyle"> To fix this quirk, "width" and "height" attributes of such images are set to value "auto": <img src="clear.cache.gif" width="auto" height="auto" class="fooStyle"> Change-Id: Ia17eb684cb08c0cb2cd610e38974bc9992e48285 Bug-Url: https://bugzilla.redhat.com/1255428 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BrowserHacks.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ClientAgentType.java 3 files changed, 85 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia17eb684cb08c0cb2cd610e38974bc9992e48285 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use multiple "boot.devices.device" instead of multi...
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use multiple "boot.devices.device" instead of multiple "boot" ...................................................................... restapi: Use multiple "boot.devices.device" instead of multiple "boot" Currently the way to specify the boot sequence when starting a virtual machine was to use multiple "boot" elements, each containing a "dev" element. For example, to specify that the virtual machine should first try to boot from CDROM and then from hard disk the following request was used: POST /vms/{vm:id}/start <action> <vm> ... <boot> <dev>cdrom</dev> </boot> <boot> <dev>hd</dev> </boot> </vm> </action> The common practice in other parts of the API is to represent arrays with a wrapper element. In that case that wrapper element could be named "boots", but that doesn't make much sense, as what can have multiple values here is the boot device, not the boot sequence. To fix this inconsistence this patch replaces that with a single "boot" element that can contain multiple devices: POST /vms/{vm:id}/start <action> <vm> ... <boot> <devices> <device>cdrom</device> <device>hd</device> </devices> </boot> </vm> </action> Change-Id: I63fbcef5cdfafc76cc95a3862ff8ac3457ee9074 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/BootValidator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/OsValidator.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/InstanceTypeMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 12 files changed, 149 insertions(+), 97 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46744 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63fbcef5cdfafc76cc95a3862ff8ac3457ee9074 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Removed the disk "clone" and "detach_only" elements
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Removed the disk "clone" and "detach_only" elements ...................................................................... restapi: Removed the disk "clone" and "detach_only" elements These elements aren't really part of the representation of disks, but parameters of the operations to add and remove virtual machines. The "disks.clone" element was used to indicate that the disks of a new virtual machine have to be cloned: POST /vms <vm> ... <disks> <clone>true</clone> </disks> <vm> This has been now removed, and replaced by a new "clone" matrix parameter: POST /vms;clone=true <vm> ... </vm> The "disks.detach_only" element was used to indicate that when removing a virtual machine the disks don't have to be removed, but just detached from the virtual machine: DELETE /vms/{vm:id} <action> <vm> <disks> <detach_only>true</detach_only> </disks> </vm> </action> This has been now removed, and replaced by a new "detach_only" matrix parameter: DELETE /vms/{vm:id};detach_only=true Change-Id: I4b3f4d00377c7dd1a102ec8aa8d87059c11d9cd0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java 7 files changed, 81 insertions(+), 19 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b3f4d00377c7dd1a102ec8aa8d87059c11d9cd0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0