- Engine-commits - oVirt List Archives

Change in jenkins[master]: ovirt-scheduler-proxy: new standard jobs
by sbonazzo＠redhat.com 25 Sep '15

25 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-scheduler-proxy: new standard jobs ...................................................................... ovirt-scheduler-proxy: new standard jobs Change-Id: Id99a2a8514fd828e634e14ad85a433a6eeb0b045 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/projects/ovirt-scheduler-proxy/ovirt-scheduler-proxy_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml A jobs/confs/yaml/scms/ovirt-scheduler-proxy.yaml 4 files changed, 49 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Martin Sivák: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/46632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id99a2a8514fd828e634e14ad85a433a6eeb0b045 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: instance types need to have only the subset of temp...
by tjelinek＠redhat.com 25 Sep '15

25 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: instance types need to have only the subset of template fields ...................................................................... restapi: instance types need to have only the subset of template fields InstanceTypeMapper was using the TemlpateMapper which was giving more fields to instance type than it was supposed to. Fixed by splitting out the mapCommon* from mapVmBase* and used this from instance type mapper. Change-Id: Ice3af5199d8f31aa175719743479c0aba89b4f2a Bug-Url: https://bugzilla.redhat.com/1241279 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DisplayMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/InstanceTypeMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 155 insertions(+), 91 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice3af5199d8f31aa175719743479c0aba89b4f2a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernández Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Don't disconnect while importing hosted engine storage...
by tnisan＠redhat.com 25 Sep '15

25 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Don't disconnect while importing hosted engine storage domains ...................................................................... core: Don't disconnect while importing hosted engine storage domains Avoid the disconnect part when querying for attached storage pool. Disconnecting the hosted engine domain while its running means the hosted engine VM will crash. Change-Id: I29487b05873edfd9075bc09d35a3c23aa6734ed6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261996 Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29487b05873edfd9075bc09d35a3c23aa6734ed6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix condition in "IconHelper"
by tnisan＠redhat.com 25 Sep '15

25 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix condition in "IconHelper" ...................................................................... restapi: Fix condition in "IconHelper" This is needed in order to avoid the following findbugs warning, but it also looks like a real bug: Repeated conditional tests The code contains a conditional test is performed twice, one right after the other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to be something else (e.g., x == 0 || y == 0). Bug kind and pattern: RpC - RpC_REPEATED_CONDITIONAL_TEST Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1265716 --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/IconHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: added memory_policy to tempalte and instance type
by tjelinek＠redhat.com 25 Sep '15

25 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: added memory_policy to tempalte and instance type ...................................................................... restapi: added memory_policy to tempalte and instance type It was present only on the VM and has to be present also on template and instance type. For consistency reasons with the VM also added to deprecatedPopulate so it will be presnet all the time. Change-Id: Ia7f1f6950d1433a1634c27d4cd933c8734bcb504 Bug-Url: https://bugzilla.redhat.com/1241279 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/MemoryPolicyHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 17 files changed, 177 insertions(+), 94 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7f1f6950d1433a1634c27d4cd933c8734bcb504 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernández Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Avoid NPE when engine VM isn't imported already
by rgolan＠redhat.com 25 Sep '15

25 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: core: Avoid NPE when engine VM isn't imported already ...................................................................... core: Avoid NPE when engine VM isn't imported already Change-Id: I1a11191968763a56b2eb55f7442dfd42694dac1d Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java 1 file changed, 13 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a11191968763a56b2eb55f7442dfd42694dac1d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Don't disconnect while importing hosted engine storage...
by mperina＠redhat.com 25 Sep '15

25 Sep '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Don't disconnect while importing hosted engine storage domains ...................................................................... core: Don't disconnect while importing hosted engine storage domains Avoid the disconnect part when querying for attached storage pool. Disconnecting the hosted engine domain while its running means the hosted engine VM will crash. Change-Id: I29487b05873edfd9075bc09d35a3c23aa6734ed6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261996 Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Passed CI tests Martin Peřina: Looks good to me, approved Martin Sivák: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29487b05873edfd9075bc09d35a3c23aa6734ed6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: mock_runner: add fedora 23 support
by dcaroest＠redhat.com 25 Sep '15

25 Sep '15

David Caro has submitted this change and it was merged. Change subject: mock_runner: add fedora 23 support ...................................................................... mock_runner: add fedora 23 support Change-Id: Ia4ec6b969a1483328330f7dea86b06be52c86183 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A mock_configs/fedora-23-x86_64.cfg A mock_configs/fedora-23-x86_64_proxied.cfg M mock_configs/mock_runner.sh 3 files changed, 138 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me; Passed CI tests; Ready for merge Max Kovgan: Looks good to me -- To view, visit https://gerrit.ovirt.org/46353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4ec6b969a1483328330f7dea86b06be52c86183 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use "Integer.toString" in "HSMGetStorageDomainsListVDS...
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.toString" in "HSMGetStorageDomainsListVDSCommand" ...................................................................... core: Use "Integer.toString" in "HSMGetStorageDomainsListVDSCommand" This is needed in order to avoid the following findbugs error: Method allocates a boxed primitive just to call toString A boxed primitive is allocated just to call toString(). It is more effective to just use the static form of toString which takes the primitive value. So, Replace... With this... new Integer(1).toString() Integer.toString(1) new Long(1).toString() Long.toString(1) new Float(1.0).toString() Float.toString(1.0) new Double(1.0).toString() Double.toString(1.0) new Byte(1).toString() Byte.toString(1) new Short(1).toString() Short.toString(1) new Boolean(true).toString() Boolean.toString(true) Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_TOSTRING Change-Id: I2612b3ed9f06f4a54e738e70ab133ce1bdda916c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainsListVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2612b3ed9f06f4a54e738e70ab133ce1bdda916c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "parseXXX" in "VdsBrokerObjectsBuilder"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "parseXXX" in "VdsBrokerObjectsBuilder" ...................................................................... core: Use "parseXXX" in "VdsBrokerObjectsBuilder" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: If551b1372c6cfba899fc3aecc03ed87313eb53db Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If551b1372c6cfba899fc3aecc03ed87313eb53db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0