- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Add methods to get boolean and integer matrix param...
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add methods to get boolean and integer matrix parameters ...................................................................... restapi: Add methods to get boolean and integer matrix parameters This patch adds two methods to the "QueryHelper" class to simplify access to boolean and integer matrix parameters. Change-Id: I87976ca26036577dddd0bf34a1eaff0773a9ea56 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java 1 file changed, 66 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87976ca26036577dddd0bf34a1eaff0773a9ea56 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Don't assume names in completeness assertor
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't assume names in completeness assertor ...................................................................... restapi: Don't assume names in completeness assertor Currently the completeness assertor assumes that access to a element of a list in the code generated by the XJC compiler is always done calling two methods with identical names. For example, it assumes that getting the slaves of a bonding works like this: Bonding bonding = ...; Slave slave = bonding.getSlaves().getSlaves().get(0); This kind of call isn't performed directly, but using reflection, but anyhow the completeness assertor assumes that there will be two consecutive calls to methods named "getSlaves" and "getSlaves". Internally this is used when checking validations like the following: validateParameters(bonding, "bonding.slaves.id|name"); This works fine in the current environment, but if the types are changed it breaks. For example, assume that the code is changed so that "Bonding.getSlaves()" returns an object of type "HostNics" instead of "Slaves". The way to get slaves will then be like this: Bonding bonding = ...; Slave slave = bonding.getSlaves().getHostNics().get(0); But the completeness assertor won't be able to do this via reflection, because the names of the method are now different, "getSlaves" and then "getHostNics". To avoid this limitation this patch changes the completeness assertor so instead of assuming the two method names it will only assume the first and will find the second method assuming that objects that represent lists have only one getter that returns a list object. Change-Id: I35badb0f5365a41a1d57ce7a99f81bbe32e5a451 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/CompletenessAssertor.java 1 file changed, 44 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35badb0f5365a41a1d57ce7a99f81bbe32e5a451 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename element "vmpool" to "vm_pool"
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename element "vmpool" to "vm_pool" ...................................................................... restapi: Rename element "vmpool" to "vm_pool" Currently the names of the elements that represent pools of virtual machines are "vmpool" and "vmpools". This patch renames them "vm_pool" and "vm_pools" in order to have a consistent correspondence between names of complex types ("VmPool" and "VmPools" in this case) and elements. Change-Id: I4988e97d4c81d4806b1cbb3da9930f80511dbe53 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermissionMapper.java 4 files changed, 40 insertions(+), 26 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4988e97d4c81d4806b1cbb3da9930f80511dbe53 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove complex type "BaseDevices"
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove complex type "BaseDevices" ...................................................................... restapi: Remove complex type "BaseDevices" This complex type doesn't add any thing and complicates the inheritance hierarchy. This patch removes it. Change-Id: If28141e72c6453ed7755e03801c9e46a14311efb Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DevicesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ReadOnlyDevicesResource.java M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDevicesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDeviceResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDeviceResource.java 7 files changed, 18 insertions(+), 26 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If28141e72c6453ed7755e03801c9e46a14311efb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Support mocking matrix parameter with value
by juan.hernandez＠redhat.com 28 Sep '15

28 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Support mocking matrix parameter with value ...................................................................... restapi: Support mocking matrix parameter with value Currently the mocking infrastructure of the RESTAPI doesn't easily support mocking a matrix parameter with a value. This patch adds that support. Change-Id: I88a649b3165d7d46ca4b6375d7910f4b40c8fc66 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88a649b3165d7d46ca4b6375d7910f4b40c8fc66 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: GetDeviceListQueryTest javadoc
by tnisan＠redhat.com 27 Sep '15

27 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: GetDeviceListQueryTest javadoc ...................................................................... core: GetDeviceListQueryTest javadoc Placed Javadoc in the correct place, above the methods' annotations. Change-Id: I9a8a4fb9c37ef72cfbe1c040ab1ace11d7c1891f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetDeviceListQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a8a4fb9c37ef72cfbe1c040ab1ace11d7c1891f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ConnectVdsToLun -> connectVdsToLun
by tnisan＠redhat.com 27 Sep '15

27 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: ConnectVdsToLun -> connectVdsToLun ...................................................................... core: ConnectVdsToLun -> connectVdsToLun Rename method to adhere to Java naming conventions. Change-Id: If132a8a0a978df5a5aa027629cf0db69a0cd5e0d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46436 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If132a8a0a978df5a5aa027629cf0db69a0cd5e0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ConnectAllHostsToLunCommand#validateConnectedLuns
by tnisan＠redhat.com 27 Sep '15

27 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: ConnectAllHostsToLunCommand#validateConnectedLuns ...................................................................... core: ConnectAllHostsToLunCommand#validateConnectedLuns Replaced fully qualified @throws definition with the simple class name, as EngineException is already imported. Change-Id: I5d31af8409f801b67bf5ddace925619b266396c9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d31af8409f801b67bf5ddace925619b266396c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ConnectAllHostsToLunCommand#createReturnValue
by tnisan＠redhat.com 27 Sep '15

27 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: ConnectAllHostsToLunCommand#createReturnValue ...................................................................... core: ConnectAllHostsToLunCommand#createReturnValue The whole point of overriding this method is using a different return value. This patch makes it explicit by specifying the return type accordingly, in order to improve the code's readability. Change-Id: Id73db450e19b6a9836df893693cd2bb125e08223 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id73db450e19b6a9836df893693cd2bb125e08223 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Add lock on Extend SD command
by tnisan＠redhat.com 27 Sep '15

27 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Add lock on Extend SD command ...................................................................... engine: Add lock on Extend SD command In order to prevent to run the Extend Storage Domain command twice at the same time, an exclusive lock is added to the command. Running this command twice will put the VG in a partial state, creating a PV twice on the same device. Change-Id: Ib9062ba235daa1d25298f1d295b17d15e1528c80 Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1265906 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/46657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9062ba235daa1d25298f1d295b17d15e1528c80 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0