- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Check result of "list" in "Tar"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Check result of "list" in "Tar" ...................................................................... core: Check result of "list" in "Tar" This is needed in order to avoid the following findbugs warning: Possible null pointer dereference due to return value of called method The return value from a method is dereferenced without a null check, and the return value of that method is one that should generally be checked for null. This may lead to a NullPointerException when the code is executed. Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE Change-Id: I942994dc5d9d5e4470a4a8f28903807c820c071d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/Tar.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I942994dc5d9d5e4470a4a8f28903807c820c071d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove server hooks correctly
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove server hooks correctly ...................................................................... core: Remove server hooks correctly According to findbugs the "deletedServerHooks" map used in the "GlusterHookSyncJob" class is useless, as it is populated but never queried: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed. This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT This patch changes the sync job so that the unused object is removed. Change-Id: Icb7de1c5a4bf38f641960baf4b6cf3dd86b0b850 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb7de1c5a4bf38f641960baf4b6cf3dd86b0b850 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Avoid potential NPE in "SSHDialog"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Avoid potential NPE in "SSHDialog" ...................................................................... core: Avoid potential NPE in "SSHDialog" This is needed in order to avoid the following findbugs warning: Possible null pointer dereference in method on exception path A reference value which is null on some exception control path is dereferenced here. This may lead to a NullPointerException when the code is executed. Note that because FindBugs currently does not prune infeasible exception paths, this may be a false warning. Also note that FindBugs considers the default case of a switch statement to be an exception path, since the default case is often infeasible. Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_EXCEPTION Change-Id: I598c3c490a9b6c152ac0245b7b89842081b16b01 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I598c3c490a9b6c152ac0245b7b89842081b16b01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Check result of "listFiles" in "ContextSensitiveHelpMa...
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Check result of "listFiles" in "ContextSensitiveHelpMappingServlet" ...................................................................... core: Check result of "listFiles" in "ContextSensitiveHelpMappingServlet" This is needed in order to avoid the following findbugs warning: Possible null pointer dereference due to return value of called method The return value from a method is dereferenced without a null check, and the return value of that method is one that should generally be checked for null. This may lead to a NullPointerException when the code is executed. Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE Change-Id: I6fa5bf732c459c7e1dad0f69033f199662899ebd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/ContextSensitiveHelpMappingServlet.java 1 file changed, 15 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46615 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fa5bf732c459c7e1dad0f69033f199662899ebd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Make "AlertPanel.Type" enum fields private
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Make "AlertPanel.Type" enum fields private ...................................................................... restapi: Make "AlertPanel.Type" enum fields private This is needed in order to avoid the following findbugs warning: Enum field is public and mutable A mutable public field is defined inside a public enum, thus can be changed by malicious code or by accident from another package. Though mutable enum fields may be used for lazy initialization, it's a bad practice to expose them to the outer world. Consider declaring this field final and/or package-private. Bug kind and pattern: ME - ME_MUTABLE_ENUM_FIELD Change-Id: Ic1d2ddf68985e020dd156900184ed8df2d1d1e15 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1d2ddf68985e020dd156900184ed8df2d1d1e15 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: not possible to edit blank template using REST API
by tjelinek＠redhat.com 25 Sep '15

25 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: not possible to edit blank template using REST API ...................................................................... restapi: not possible to edit blank template using REST API The problem was that when editing the template the cluster version needed to be loaded. It is not possible to do it in case of Blank template since it is not attached to the cluster and it's version is always the latest. Change-Id: I78cd46d8949dfe9eb3d7de207cc8646b7f1060ee Bug-Url: https://bugzilla.redhat.com/1262287 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 15 files changed, 48 insertions(+), 225 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78cd46d8949dfe9eb3d7de207cc8646b7f1060ee Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernández Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: exttool: do not modify map keySet()
by piotr.kliczewski＠gmail.com 25 Sep '15

25 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: exttool: do not modify map keySet() ...................................................................... exttool: do not modify map keySet() Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177762 Change-Id: Idbe9f4eccc6f7ff37bc2bbdd1633a4b4556e424b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> (cherry picked from commit ef159429829ddd76cf8517695dc46577bdaaa893) --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbe9f4eccc6f7ff37bc2bbdd1633a4b4556e424b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: jsonrpc: version bump
by piotr.kliczewski＠gmail.com 25 Sep '15

25 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump We removed dependency on log4j so it is not needed in module.xml anymore. Bug-Url: https://bugzilla.redhat.com/1265965 Change-Id: Idfcaf7e9cd54bf811b3d906110e9fc084bb7b047 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/dependencies/common/src/main/modules/org/ovirt/vdsm-jsonrpc-java/main/module.xml M ovirt-engine.spec.in M pom.xml 3 files changed, 3 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Verified Sandro Bonazzola: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfcaf7e9cd54bf811b3d906110e9fc084bb7b047 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: engine: revet ActivateDeactivateVmNicCommand to use the old ...
by piotr.kliczewski＠gmail.com 25 Sep '15

25 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: revet ActivateDeactivateVmNicCommand to use the old macAvailable ...................................................................... engine: revet ActivateDeactivateVmNicCommand to use the old macAvailable Revert the change in- https://gerrit.ovirt.org/#/c/40052 Bug-Url: https://bugzilla.redhat.com/1266172 Change-Id: I10d2d2f0ee2f5293308ea4bc2b9ddbd6d6b93988 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit bf701283555a6a545137ad99d681c6cc8a4b387d) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 2 files changed, 27 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10d2d2f0ee2f5293308ea4bc2b9ddbd6d6b93988 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: fix gerrit hook scripts
by piotr.kliczewski＠gmail.com 25 Sep '15

25 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: fix gerrit hook scripts ...................................................................... fix gerrit hook scripts - ensure /etc/maven folder exists before writing files to it - add missing packages.el6 files Change-Id: Ib73deb2ae985363fe077644e9f3761b68724c249 Signed-off-by: Max Kovgan <mvk(a)redhat.com> Bug-Url: https://ovirt-jira.atlassian.net/browse/OVIRT-351 (cherry picked from commit 6bafc67d1b615920b81305ac610f1a03ac615f6e) --- M automation/build-artifacts.sh A automation/check-merged.packages.el6 M automation/check-merged.sh A automation/check-patch.packages.el6 M automation/check-patch.sh 5 files changed, 19 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib73deb2ae985363fe077644e9f3761b68724c249 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0