- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Use "parseXXX" in "GlusterVolumeTaskReturnForXmlRpc"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "parseXXX" in "GlusterVolumeTaskReturnForXmlRpc" ...................................................................... core: Use "parseXXX" in "GlusterVolumeTaskReturnForXmlRpc" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Ie340965808981fa5f27225f9bd8b957cebafff01 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeTaskReturnForXmlRpc.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie340965808981fa5f27225f9bd8b957cebafff01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "parseXXX" in "GlusterVolumeStatusReturnForXmlRpc"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "parseXXX" in "GlusterVolumeStatusReturnForXmlRpc" ...................................................................... core: Use "parseXXX" in "GlusterVolumeStatusReturnForXmlRpc" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Icdf19dfa81769ae752967590171e55d457ba93c2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java 1 file changed, 26 insertions(+), 26 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdf19dfa81769ae752967590171e55d457ba93c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "parseInt" and "parseLong" in "GlusterVolumeProfil...
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "parseInt" and "parseLong" in "GlusterVolumeProfileInfoReturnForXmlRpc" ...................................................................... core: Use "parseInt" and "parseLong" in "GlusterVolumeProfileInfoReturnForXmlRpc" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Ia924318483fe1315fc4794c768d1fa7a9a995ffd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeProfileInfoReturnForXmlRpc.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46599 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia924318483fe1315fc4794c768d1fa7a9a995ffd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "Integer.parseInt" in "OvfReader"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.parseInt" in "OvfReader" ...................................................................... core: Use "Integer.parseInt" in "OvfReader" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Ic40a4a6769a5c532977c3ca75e30ed4a4c7b87d3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic40a4a6769a5c532977c3ca75e30ed4a4c7b87d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "Integer.parseInt" in "VmDeviceType"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.parseInt" in "VmDeviceType" ...................................................................... core: Use "Integer.parseInt" in "VmDeviceType" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: I214defcc26e08353e1aa4d414302cca214fce688 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I214defcc26e08353e1aa4d414302cca214fce688 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "Long.valueOf" in "StorageHandlingCommandBase"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Long.valueOf" in "StorageHandlingCommandBase" ...................................................................... core: Use "Long.valueOf" in "StorageHandlingCommandBase" This is needed in order to avoid the following findbugs warning: Method invokes inefficient Number constructor; use static valueOf instead Using new Integer(int) is guaranteed to always result in a new object whereas Integer.valueOf(int) allows caching of values to be done by the compiler, class library, or JVM. Using of cached values avoids object allocation and the code will be faster. Values between -128 and 127 are guaranteed to have corresponding cached instances and using valueOf is approximately 3.5 times faster than using constructor. For values outside the constant range the performance of both styles is the same. Unless the class must be compatible with JVMs predating Java 1.5, use either autoboxing or the valueOf() method when creating instances of Long, Integer, Short, Character, and Byte. Bug kind and pattern: Bx - DM_NUMBER_CTOR Change-Id: I59e2c93b6e9ad26e3ca345483e9cc0b863a0ecbf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e2c93b6e9ad26e3ca345483e9cc0b863a0ecbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "Integer.parseInt" in "VmHandler"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.parseInt" in "VmHandler" ...................................................................... core: Use "Integer.parseInt" in "VmHandler" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Ibccaea79c32522aa1c08398565b552b4aa69974e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibccaea79c32522aa1c08398565b552b4aa69974e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "Integer.parseInt" in "AbstractDiskVmCommand"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.parseInt" in "AbstractDiskVmCommand" ...................................................................... core: Use "Integer.parseInt" in "AbstractDiskVmCommand" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: I2828c0d7ae4130697d510a35d83333195bb8bf25 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2828c0d7ae4130697d510a35d83333195bb8bf25 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "Integer.compare" in "InitDictinoaries"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.compare" in "InitDictinoaries" ...................................................................... core: Use "Integer.compare" in "InitDictinoaries" This is needed in order to avoid the following findbugs error: Boxing a primitive to compare A boxed primitive is created just to call compareTo method. It's more efficient to use static compare method (for double and float since Java 1.4, for other primitive types since Java 1.7) which works on primitives directly. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_COMPARE Change-Id: I8111481cf815abc0aa4da66a0cf47b8cb72b3a9b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8111481cf815abc0aa4da66a0cf47b8cb72b3a9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make "Version.ALL" unmodifiable
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Make "Version.ALL" unmodifiable ...................................................................... core: Make "Version.ALL" unmodifiable This is needed in order to avoid the following findbugs warning: Field is a mutable collection which should be package protected A mutable collection instance is assigned to a final static field, thus can be changed by malicious code or by accident from another package. The field could be made package protected to avoid this vulnerability. Alternatively you may wrap this field into Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability. Bug kind and pattern: MS - MS_MUTABLE_COLLECTION_PKGPROTECT Change-Id: If185a4e600c1e893229b3d7e72bf0cbed76ff58a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If185a4e600c1e893229b3d7e72bf0cbed76ff58a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0