- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: scheduler: Let AffinityGroup always return empty lists
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: scheduler: Let AffinityGroup always return empty lists ...................................................................... scheduler: Let AffinityGroup always return empty lists Sometimes an AffinityGroup is created without VMs in it. Make sure that all lists it returns are never null for safer usage. Bug-Url: https://bugzilla.redhat.com/1251742 Change-Id: I0b504d99ab0cbe0f37b2eb3429d871aa207584ad Signed-off-by: Roman Mohr <rmohr(a)redhat.com> (cherry picked from commit 0bc6473e435804c1eff10eb7ee512db3c204d447) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/AffinityGroup.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AffinityGroupDaoTest.java 3 files changed, 10 insertions(+), 9 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b504d99ab0cbe0f37b2eb3429d871aa207584ad Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: old SetupNetworks, NPE when attaching network to hos...
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: old SetupNetworks, NPE when attaching network to host NIC ...................................................................... engine: old SetupNetworks, NPE when attaching network to host NIC NPE in the follwing cases- 1. Just the name of the attached network is passed (not the id). 2. Just the name of the nic is passed. 3. The 'vdsId' is not set on the passed host nic. Change-Id: I1242f13a34df4bbdd7eee1e094cc02f28105585d Bug-Url: https://bugzilla.redhat.com/1260430 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 3 files changed, 51 insertions(+), 17 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1242f13a34df4bbdd7eee1e094cc02f28105585d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: new host prefilter dc.
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: new host prefilter dc. ...................................................................... webadmin: new host prefilter dc. - When selecting a Data Center in the system tree the available datacenters in the drop down were not being properly filtered. This patch applies the filtering. Change-Id: Iab8929ada6590d1d22e9c01f9391889728840892 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248674 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 20 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab8929ada6590d1d22e9c01f9391889728840892 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: fixing script to properly parse params with email and dry-run
by eedri＠redhat.com 08 Sep '15

08 Sep '15

Eyal Edri has submitted this change and it was merged. Change subject: fixing script to properly parse params with email and dry-run ...................................................................... fixing script to properly parse params with email and dry-run Change-Id: I74dd2607844344d7ba45727f1abc0f59f6456ec1 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/45883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74dd2607844344d7ba45727f1abc0f59f6456ec1 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI

1 0

Change in jenkins[master]: aligning to new git scm template, requiring new param
by eedri＠redhat.com 08 Sep '15

08 Sep '15

Eyal Edri has submitted this change and it was merged. Change subject: aligning to new git scm template, requiring new param ...................................................................... aligning to new git scm template, requiring new param - added 'git-server' param Change-Id: I74cc2de89d1e2d55a1541d5bb1bd7f8af8b6a1df Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74cc2de89d1e2d55a1541d5bb1bd7f8af8b6a1df Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI

1 0

Change in jenkins[master]: Various Updates to yaml file for abandoning old patches
by eedri＠redhat.com 08 Sep '15

08 Sep '15

Eyal Edri has submitted this change and it was merged. Change subject: Various Updates to yaml file for abandoning old patches ...................................................................... Various Updates to yaml file for abandoning old patches Fixed hanging indentation. Updated the job name. Connect to gerrit server as user jenkins_ro. Use ssh-agent-credentials wrapper for authentication. Added scm for jenkins repo inside job defenition. Fixed syntax errors in scm defenition. Updated the schedule to run at random minutes after 00:00. Email dcaro, eedir , iheim and vissree on build failure. Use 600 days warning and 300 days abandon limits by default. Pass warning limit and abandon limit as strings. Add warning limit, abandon limit, test email and dry-run as parameters to the job. Signed-off-by: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com> Change-Id: I8fc6ac30b1865e7c389bf5929c73dcb6ba8954ea Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- A jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/39357 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fc6ac30b1865e7c389bf5929c73dcb6ba8954ea Gerrit-PatchSet: 18 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com>

1 0

Change in ovirt-engine[master]: webadmin: Fence agent duplicate ip
by awels＠redhat.com 08 Sep '15

08 Sep '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fence agent duplicate ip ...................................................................... webadmin: Fence agent duplicate ip - The code was allowing the user to enter a duplicate management ip, compared to the existing fence agents. This would allow one to create duplicate entries that a lot of the code was not able to handle. This patch now checks if the management ip address of a new fence agent is already there. - Also check the list of existing fence agents when loading and will remove duplicate management ips from the list. Change-Id: I419d7acdf98c1cbeec3c18b0c0eb339e9cf25ba7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257575 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 47 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I419d7acdf98c1cbeec3c18b0c0eb339e9cf25ba7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: listener: correctly handling isTimed=False
by msivak＠redhat.com 08 Sep '15

08 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: listener: correctly handling isTimed=False ...................................................................... listener: correctly handling isTimed=False Due to bad handling of False value the listener was infinitely looping over the select() Change-Id: I3a5a5a1919d220c34783b670a07de4fb9a523851 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/util.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a5a5a1919d220c34783b670a07de4fb9a523851 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: encode non-ASCII disk alias/description
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: encode non-ASCII disk alias/description ...................................................................... core: encode non-ASCII disk alias/description Patch Ie2642ae7 causes the disk alias and description to be stored in the disk's metadata. Since vdsm expects for ASCII characters only, and since both fields can contain non-ASCII characters, the operation fails on vdsm. This patch encodes these fields if they contain non-ASCII characters using HEX encoding (and decodes when reading them), so that vdsm can handle these fields even if they contain non-ASCII characters. Change-Id: I3180ea2458ca9bd426513108e741dd0f56c8b96e Bug-Url: https://bugzilla.redhat.com/1249130 Bug-Url: https://bugzilla.redhat.com/1219680 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java 3 files changed, 205 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Maor Lipchuk: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/45374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3180ea2458ca9bd426513108e741dd0f56c8b96e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: limit disk alias and description for disk metadata
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: limit disk alias and description for disk metadata ...................................................................... core: limit disk alias and description for disk metadata On block storage, the disk metadata is limited to 512 bytes. Since we store its alias and description in the metadata, we should limit their size or else they will be truncated by vdsm and we won't be able to read them. This patch limits the value of the metadata description field size to a maximum of 210 bytes. We do it also for file storage in order to prevent a truncation of the description field when moving a disk from file to block storage. Change-Id: I74d04291bbaacb5e642d8658ab752b1a8d32c0ac Bug-Url: https://bugzilla.redhat.com/1258547 Related-To: https://bugzilla.redhat.com/1249130 Related-To: https://bugzilla.redhat.com/1219680 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 6 files changed, 218 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Maor Lipchuk: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/45551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74d04291bbaacb5e642d8658ab752b1a8d32c0ac Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0