- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: Avoid NPE when validating non-LUN disks
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Avoid NPE when validating non-LUN disks ...................................................................... core: Avoid NPE when validating non-LUN disks In some scenarios, such as import a non-existing VM, a validation may be applied to a non-existing disk. These cases are legal and don't need the verification. The validation is sometimes needed in an internal command, hence the best way is to ignore it when it's not needed. Change-Id: I0024da114c56e0520421a5e138c6c9e49cf278b9 Bug-Url: https://bugzilla.redhat.com/1147860 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/45855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0024da114c56e0520421a5e138c6c9e49cf278b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix events handling after host reboot
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fix events handling after host reboot ...................................................................... core: fix events handling after host reboot The engine filters events if it processed newer events already. It compares the timestamp on each events with the timestamp of the latest event that came from the same host and has been processed. VDSM uses monotonic time for the timestamp on the status events. The engine relay on the timestamp being monotonic. However, the timestamp is not monotonic after the host reboots. The solution is to clear the last host-id that the latest event that has been processed came from if that host has been rebooted. That way, we won't use timestamp that has been received before the host has been rebooted and the next event will be processed. Change-Id: Iba99b28312e1b729cd48dda80bac464f32ba7828 Bug-Url: https://bugzilla.redhat.com/1255033 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java 3 files changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/45860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba99b28312e1b729cd48dda80bac464f32ba7828 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: old SetupNetworks, NPE when attaching network to ho...
by masayag＠redhat.com 08 Sep '15

08 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: old SetupNetworks, NPE when attaching network to host NIC ...................................................................... engine: old SetupNetworks, NPE when attaching network to host NIC NPE in the follwing cases- 1. Just the name of the attached network is passed (not the id). 2. Just the name of the nic is passed. 3. The 'vdsId' is not set on the passed host nic. Change-Id: I1242f13a34df4bbdd7eee1e094cc02f28105585d Bug-Url: https://bugzilla.redhat.com/1260430 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 3 files changed, 51 insertions(+), 17 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45814 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1242f13a34df4bbdd7eee1e094cc02f28105585d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: setup: relying on heconflib from ovirt-hosted-engine-ha
by sbonazzo＠redhat.com 08 Sep '15

08 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: relying on heconflib from ovirt-hosted-engine-ha ...................................................................... setup: relying on heconflib from ovirt-hosted-engine-ha Since https://gerrit.ovirt.org/#/c/44836/ HAConfLib has been moved to ovirt-hosted-engine-ha package cause it's needed also on the 3.5 -> 3.6 upgrade path which doesn't involve ovirt-hosted-engine-setup. Relying just on that copy to makes maintenance easier. Change-Id: I00f14453aadd803bfb05800dd922a03d46d08336 Bug-Url: https://bugzilla.redhat.com/1254671 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/Makefile.am D src/ovirt_hosted_engine_setup/heconflib.py M src/ovirt_hosted_engine_setup/util.py M src/plugins/ovirt-hosted-engine-setup/storage/heconf.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py M src/plugins/ovirt-hosted-engine-setup/vm/image.py 7 files changed, 14 insertions(+), 369 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45815 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00f14453aadd803bfb05800dd922a03d46d08336 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: new host prefilter dc.
by awels＠redhat.com 08 Sep '15

08 Sep '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: new host prefilter dc. ...................................................................... webadmin: new host prefilter dc. - When selecting a Data Center in the system tree the available datacenters in the drop down were not being properly filtered. This patch applies the filtering. Change-Id: Iab8929ada6590d1d22e9c01f9391889728840892 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248674 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 20 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab8929ada6590d1d22e9c01f9391889728840892 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: network: always passing defaultRoute attribute
by sbonazzo＠redhat.com 08 Sep '15

08 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: network: always passing defaultRoute attribute ...................................................................... network: always passing defaultRoute attribute Always passing defRoute attribute creating a new bride. Evaluating it according to defroute, dhcp, gateway Change-Id: I13e14374cd3f06c2372d49249b88df5b25ff9302 Bug-Url: https://bugzilla.redhat.com/1253939 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vds_info.py 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13e14374cd3f06c2372d49249b88df5b25ff9302 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: network: always passing defaultRoute attribute
by sbonazzo＠redhat.com 08 Sep '15

08 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: network: always passing defaultRoute attribute ...................................................................... network: always passing defaultRoute attribute Always passing defRoute attribute creating a new bride. Evaluating it according to defroute, dhcp, gateway Change-Id: I13e14374cd3f06c2372d49249b88df5b25ff9302 Bug-Url: https://bugzilla.redhat.com/1253939 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vds_info.py 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13e14374cd3f06c2372d49249b88df5b25ff9302 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Initial task handlers in CommandBase c'tor
by masayag＠redhat.com 08 Sep '15

08 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Initial task handlers in CommandBase c'tor ...................................................................... engine: Initial task handlers in CommandBase c'tor The commands relies on tasks handlers to be initialized at c'tor execution, hence it is being shifted from the postConstruct() back to the c'tor. Change-Id: I475c737d7d2b912799556dc239578542a1900fa9 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/45841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I475c737d7d2b912799556dc239578542a1900fa9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Avoid NPE when validating non-LUN disks
by derez＠redhat.com 08 Sep '15

08 Sep '15

Daniel Erez has submitted this change and it was merged. Change subject: core: Avoid NPE when validating non-LUN disks ...................................................................... core: Avoid NPE when validating non-LUN disks In some scenarios, such as import a non-existing VM, a validation may be applied to a non-existing disk. These cases are legal and don't need the verification. The validation is sometimes needed in an internal command, hence the best way is to ignore it when it's not needed. Change-Id: I0024da114c56e0520421a5e138c6c9e49cf278b9 Bug-Url: https://bugzilla.redhat.com/1147860 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/45854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0024da114c56e0520421a5e138c6c9e49cf278b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: packaging: Distribution specific RPM spec files
by juan.hernandez＠redhat.com 08 Sep '15

08 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Distribution specific RPM spec files ...................................................................... packaging: Distribution specific RPM spec files Currently we use a single .spec file template for all the supported distributions. To support all the distributions it should contain many "%if" statements that change behaviour, for example to build or not the Python 3 support packages. This would make it convoluted and difficult to maintain. To avoid this issue this patch introduces different spec file templates, one for each supported distribution. Change-Id: Id9d733bdfcafab4e07325695ff395a40a9b27bd2 Bug-Url: https://bugzilla.redhat.com/1260865 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M .gitignore M Makefile C spec.el6.in A spec.el7.centos.in C spec.el7.in R spec.fc21.in C spec.fc22.in 7 files changed, 21 insertions(+), 83 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Juan Hernandez: Verified; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9d733bdfcafab4e07325695ff395a40a9b27bd2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0