- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core:fix NPE on edit empty cluster version
by masayag＠redhat.com 07 Sep '15

07 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: core:fix NPE on edit empty cluster version ...................................................................... core:fix NPE on edit empty cluster version This patch fixes a NPE when the compatibility version of an empty cluster is changed Change-Id: I87434bc41621d8bbf338c28ba5803a3197600e43 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EmulatedMachineClusterEditChecker.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87434bc41621d8bbf338c28ba5803a3197600e43 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Avoid NPEs on illegal LUN disk operations
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Avoid NPEs on illegal LUN disk operations ...................................................................... core: Avoid NPEs on illegal LUN disk operations Move, copy and export of LUN disks, either attached to a VM or not is not possible. Using REST, lack of image id and source storage domain resulted in NPEs. These are now checked before being sent to the engine, while the appropriate commands check that the disk is not of type LUN (which applies for all above null scenarios). Change-Id: I6de6615cd8f154b9c348055e65d153c9da0f12e8 Bug-Url: https://bugzilla.redhat.com/1147861 Bug-Url: https://bugzilla.redhat.com/1147863 Bug-Url: https://bugzilla.redhat.com/1147870 Bug-Url: https://bugzilla.redhat.com/1147873 Bug-Url: https://bugzilla.redhat.com/1147874 Bug-Url: https://bugzilla.redhat.com/1126425 Bug-Url: https://bugzilla.redhat.com/1147860 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 16 files changed, 195 insertions(+), 41 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/45776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6de6615cd8f154b9c348055e65d153c9da0f12e8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: frontend: Localize ArchitectureType.undefined
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Localize ArchitectureType.undefined ...................................................................... frontend: Localize ArchitectureType.undefined Change-Id: Ib0ab3ed150e4a09f8f96e204e7ea43c4a418a124 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1089607 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 3 files changed, 14 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/45798 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0ab3ed150e4a09f8f96e204e7ea43c4a418a124 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Added sorting to AREM
by rgolan＠redhat.com 07 Sep '15

07 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: core: Added sorting to AREM ...................................................................... core: Added sorting to AREM - Affinity Rules Enforcement manager need to make sure that affinity groups are sorted first by affinity group's size (From largest to smallest) and then by first VM's Guid. That's why we use GuidComparator to sort the affinity groups. - Added unit tests to check correct sorting. Change-Id: Id9908810a7f373a8098a6765e1c8f95e53af1a0a Bug-Url: https://bugzilla.redhat.com/1254627 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java 3 files changed, 69 insertions(+), 9 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9908810a7f373a8098a6765e1c8f95e53af1a0a Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: scheduler: Refactor AffinityRulesEnforcementManager
by rgolan＠redhat.com 07 Sep '15

07 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: scheduler: Refactor AffinityRulesEnforcementManager ...................................................................... scheduler: Refactor AffinityRulesEnforcementManager * Fix check if a VM is still migrating. * Trigger one migration per cluster instead of one migration per datacenter. * Split unit tests in AffinityRulesEnforcementManager tests and AffinityRulesEnforcementPerCluster tests. * Remove old tests and added more new ones. * Remove not fully implemented features: - lower wakeup frequency when everything is satisfied - temporary suspension of clusters when too many migration failures occur They will be added later. Bug-Url: https://bugzilla.redhat.com/1251742 Change-Id: I8921baa3b5335103d8dc0cd31eed094eb025cba1 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/MigrationEntryDS.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java 5 files changed, 332 insertions(+), 575 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8921baa3b5335103d8dc0cd31eed094eb025cba1 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: imageGroupId passed to parameters
by derez＠redhat.com 07 Sep '15

07 Sep '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: imageGroupId passed to parameters ...................................................................... webadmin: imageGroupId passed to parameters Up-til now this was not needed, but is now checked in MoveDisksCommand and should thus be passed. Change-Id: I52c88a6c1dd9079cee80edb28d71ebea2e6292cc Bug-Url: https://bugzilla.redhat.com/1147861 Bug-Url: https://bugzilla.redhat.com/1147863 Bug-Url: https://bugzilla.redhat.com/1147870 Bug-Url: https://bugzilla.redhat.com/1147873 Bug-Url: https://bugzilla.redhat.com/1147874 Bug-Url: https://bugzilla.redhat.com/1126425 Bug-Url: https://bugzilla.redhat.com/1147860 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/45805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52c88a6c1dd9079cee80edb28d71ebea2e6292cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: not possible to create a VM from userportal
by tjelinek＠redhat.com 07 Sep '15

07 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: not possible to create a VM from userportal ...................................................................... webadmin: not possible to create a VM from userportal The problem was that the MaxIoThreadsPerVm was not a user query but was needed in user portal Change-Id: Ieaf6bb391eb9a0248f6a31bc75ec8d417d05f23a Bug-Url: https://bugzilla.redhat.com/1259776 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieaf6bb391eb9a0248f6a31bc75ec8d417d05f23a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: encoding issue in vv file
by tjelinek＠redhat.com 07 Sep '15

07 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: encoding issue in vv file ...................................................................... webadmin: encoding issue in vv file If some part of the .vv file contains some national chars, it will be incorrectly encoded. Fixed by sending them as URL encoded and decode them on server. Change-Id: I178249bbd779787b02545e40c1c0d0d4137a75df Bug-Url: https://bugzilla.redhat.com/1258759 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetAttachmentServlet.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45718 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I178249bbd779787b02545e40c1c0d0d4137a75df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6_beta4
by sbonazzo＠redhat.com 07 Sep '15

07 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6_beta4 ...................................................................... build: ovirt-live-3.6_beta4 Change-Id: Ic63b94dcc0559d920986fedc6b0bab02a67aea5f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic63b94dcc0559d920986fedc6b0bab02a67aea5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: utils: allow spaces within encrypted fields
by masayag＠redhat.com 07 Sep '15

07 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: utils: allow spaces within encrypted fields ...................................................................... utils: allow spaces within encrypted fields Ever since 3.0 (probably even before) the encryption of database fields that was used is invalid, it uses RSA to encrypt blobs instead of using ciphers within envelope. It also stores null and empty strings as plain, and to make it even better it trims spaces out of the input for some reason. To conclude security... if decryption fails it falls back to use the blob as plain text. This logic was untouched, under the hope that we slowly remove usages of it. AAA does not use it any more, we should remove all. For now, we remove the trim() as if the password of trim() actually works so far it will keep working, new passwords with leading/trailing spaces will be rejected. The risk is if for some reason we have " "* in database field it will be rejected as valid password, fixing it will be re-set password by user to empty one. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258867 Change-Id: I2ca15519ec245efd82e71f2ec39abd4ca1fe81c2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ca15519ec245efd82e71f2ec39abd4ca1fe81c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0