- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: RandomUtils line breaks
by amureini＠redhat.com 03 Sep '15

03 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RandomUtils line breaks ...................................................................... core: RandomUtils line breaks Remove redundant line breaks that only hinder readability instead of improving it. Change-Id: I4cd18b94cb602b933143a79dda7f31931586ca26 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 7 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/45679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cd18b94cb602b933143a79dda7f31931586ca26 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: RandomUtils super calls
by amureini＠redhat.com 03 Sep '15

03 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RandomUtils super calls ...................................................................... core: RandomUtils super calls Removed redundant calls to super. Using this modifier has no meaning in the context that was removed, as these method are polymorphic anyway. Change-Id: Idec45495f52865451b70e65f7379f20d6c1bf99d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/45678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idec45495f52865451b70e65f7379f20d6c1bf99d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: RandomUtils main javadoc
by amureini＠redhat.com 03 Sep '15

03 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RandomUtils main javadoc ...................................................................... core: RandomUtils main javadoc Fixed comment regarding pickRandom's functionality. Change-Id: Id4056fafc8ab70c2ae458fca1e63a14dc57ee12e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/45677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4056fafc8ab70c2ae458fca1e63a14dc57ee12e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: RandomUtils {@code}
by amureini＠redhat.com 03 Sep '15

03 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RandomUtils {@code} ...................................................................... core: RandomUtils {@code} Clean up the javadoc by using proper javadoc {@code} annotations instead of inlining HTML <code> tags. Change-Id: Ie60eeae26f1cfdad24b527b0882ad7206a15a175 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 26 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/45676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie60eeae26f1cfdad24b527b0882ad7206a15a175 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix RandomUtils#nextPropertyString
by amureini＠redhat.com 03 Sep '15

03 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix RandomUtils#nextPropertyString ...................................................................... core: Fix RandomUtils#nextPropertyString nextPropertyString was implemented incorrectly, with a misunderstanding of how RandomStringUtils works, in a way that may have returned illegal characters such as '[', ']' and ' '. This patch fixes it so it really returns strings that only contain alpha-numeric characters, underscores ('_') and periods ('.'). Change-Id: Ia98c6b78e3ca958779d413e06ced650f9740589d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 18 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/45675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia98c6b78e3ca958779d413e06ced650f9740589d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: chain icon moves the rest of the widgets
by tjelinek＠redhat.com 03 Sep '15

03 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: chain icon moves the rest of the widgets ...................................................................... webadmin: chain icon moves the rest of the widgets Made some amendments making the right side of the widgets consistently sized across VM based dialogs Change-Id: I903e6bf99d42cadc88cd89680953acba6fe9a2d5 Bug-Url: https://bugzilla.redhat.com/1166059 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelDetachableWidgetWithInfo.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidgetWithLabel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 6 files changed, 29 insertions(+), 26 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I903e6bf99d42cadc88cd89680953acba6fe9a2d5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: remove power8e cpu type
by tnisan＠redhat.com 03 Sep '15

03 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: remove power8e cpu type ...................................................................... core: remove power8e cpu type Change-Id: Ic0571268a139afd4b99620b9ec4a0427dfcd9b78 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254098 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1800_remove_power8e_cpu_type.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0571268a139afd4b99620b9ec4a0427dfcd9b78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: hosted-engine: hosted-engine client, with storage connection...
by msivak＠redhat.com 03 Sep '15

03 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: hosted-engine: hosted-engine client, with storage connection timeout ...................................................................... hosted-engine: hosted-engine client, with storage connection timeout When a hosted-engine client (cli or broker) is requesting status from hosted engine vm and there is no connection to storage domain. The client is hanging indefinalty, waiting for response. The fix is 1. Added timeout using socket's select, In lib.util.socket_readline 2. Modified lib.brokerlink._communicate() to use timed read requestes. 3. Add OSError exception trap on storage connection. Trapping mounting errors. Assuring the broker caller recieves applicative errors response. Change-Id: I3be8d3cff0912c7a88ebb00145a17fa6dd2d892d Bug-Url: http://bugzilla.redhat.com/1208489 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/storage_broker.py M ovirt_hosted_engine_ha/env/constants.py.in M ovirt_hosted_engine_ha/lib/brokerlink.py M ovirt_hosted_engine_ha/lib/brokerlink_test.py M ovirt_hosted_engine_ha/lib/util.py 5 files changed, 33 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Dudi Maroshi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/40392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3be8d3cff0912c7a88ebb00145a17fa6dd2d892d Gerrit-PatchSet: 16 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: update power8 model name to correct one
by tnisan＠redhat.com 03 Sep '15

03 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: update power8 model name to correct one ...................................................................... core: update power8 model name to correct one libvirt expects model_POWER8 instead of model_power8 Change-Id: I4df9d697e086511822e34d1a250528e1e0ec9734 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1256021 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4df9d697e086511822e34d1a250528e1e0ec9734 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Introduce PersistentHostSetupNetworksParameters
by tnisan＠redhat.com 03 Sep '15

03 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Introduce PersistentHostSetupNetworksParameters ...................................................................... engine: Introduce PersistentHostSetupNetworksParameters Needed for proper logging of the modified networks. Change-Id: I0387b64f89e02f2e0e3561e6322c0a5cdbbdba5e Bug-Url: https://bugzilla.redhat.com/1194297 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SyncAllHostNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PersistentHostSetupNetworksParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 85 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0387b64f89e02f2e0e3561e6322c0a5cdbbdba5e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0