- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix getUnderUtilizedCPUHosts function to get correct h...
by rgolan＠redhat.com 07 Sep '15

07 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: core: fix getUnderUtilizedCPUHosts function to get correct hosts ...................................................................... core: fix getUnderUtilizedCPUHosts function to get correct hosts power_saving balance module ignore CPU under utilizied hosts, because incorrect timestamp condition Change-Id: Ia104faadff453a179a6e0f9496d55e964a117c24 Bug-Url: https://bugzilla.redhat.com/1258739 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Artyom Lukianov: Verified -- To view, visit https://gerrit.ovirt.org/45558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia104faadff453a179a6e0f9496d55e964a117c24 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: setup: During cleanup drop only engine schemas
by sbonazzo＠redhat.com 07 Sep '15

07 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: During cleanup drop only engine schemas ...................................................................... setup: During cleanup drop only engine schemas During engine-cleanup execution drop only schemas owned by engine database user. Change-Id: I07698c5f23fd7ebda09d348c5dfdbf3acfda5509 Bug-Url: https://bugzilla.redhat.com/1259345 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07698c5f23fd7ebda09d348c5dfdbf3acfda5509 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Do not monitor bookmarks actions as tasks
by oourfali＠redhat.com 06 Sep '15

06 Sep '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Do not monitor bookmarks actions as tasks ...................................................................... engine: Do not monitor bookmarks actions as tasks The Bookmarks actions are short and simple and has no added value if monitored as tasks in the system. Change-Id: I9fa466053967ca77e7f5b67e1f2b2b9db8646fac Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fa466053967ca77e7f5b67e1f2b2b9db8646fac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: no need to calculate readonly and preallocated disk ...
by ofrenkel＠redhat.com 06 Sep '15

06 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: engine: no need to calculate readonly and preallocated disk size on running vm from suspend ...................................................................... engine: no need to calculate readonly and preallocated disk size on running vm from suspend When we run vm from suspend we check if the storage have enough space to run. Disks that are readonly or preallocated no need to take into this account. Change-Id: I79cb594b698dd66733b0b051284e74c8258bcb58 Bug-Url: https://bugzilla.redhat.com/1130163 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79cb594b698dd66733b0b051284e74c8258bcb58 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: block Glance domain removal if tasks are running
by derez＠redhat.com 06 Sep '15

06 Sep '15

Daniel Erez has submitted this change and it was merged. Change subject: core: block Glance domain removal if tasks are running ...................................................................... core: block Glance domain removal if tasks are running Introduced GlanceProviderValidator and overridden validateRemoveProvider method to block removal when there are related running tasks. Change-Id: Ic25eb1bd61fb33248f3eb4893443d705a6a9bb6d Bug-Url: https://bugzilla.redhat.com/1213763 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/GlanceProviderValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java 3 files changed, 51 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic25eb1bd61fb33248f3eb4893443d705a6a9bb6d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: no need to calculate readonly and preallocated disk ...
by shavivi＠redhat.com 06 Sep '15

06 Sep '15

Shahar Havivi has submitted this change and it was merged. Change subject: engine: no need to calculate readonly and preallocated disk size on running vm ...................................................................... engine: no need to calculate readonly and preallocated disk size on running vm When we run vm we check if the storage have enough space to run. Disks that are readonly or preallocated no need to take into this account. Change-Id: I691b7c79ce54e889ed20f4239f8ae25148b3ce4d Bug-Url: https://bugzilla.redhat.com/1130163 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I691b7c79ce54e889ed20f4239f8ae25148b3ce4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Avoid NPEs on illegal LUN disk operations
by derez＠redhat.com 06 Sep '15

06 Sep '15

Daniel Erez has submitted this change and it was merged. Change subject: core: Avoid NPEs on illegal LUN disk operations ...................................................................... core: Avoid NPEs on illegal LUN disk operations Move, copy and export of LUN disks, either attached to a VM or not is not possible. Using REST, lack of image id and source storage domain resulted in NPEs. These are now checked before being sent to the engine, while the appropriate commands check that the disk is not of type LUN (which applies for all above null scenarios). Change-Id: I6de6615cd8f154b9c348055e65d153c9da0f12e8 Bug-Url: https://bugzilla.redhat.com/1147861 Bug-Url: https://bugzilla.redhat.com/1147863 Bug-Url: https://bugzilla.redhat.com/1147870 Bug-Url: https://bugzilla.redhat.com/1147873 Bug-Url: https://bugzilla.redhat.com/1147874 Bug-Url: https://bugzilla.redhat.com/1126425 Bug-Url: https://bugzilla.redhat.com/1147860 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 15 files changed, 192 insertions(+), 40 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/45361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6de6615cd8f154b9c348055e65d153c9da0f12e8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Enable ConfigureConsoleOptionsQuery for paused VMs
by ofrenkel＠redhat.com 06 Sep '15

06 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Enable ConfigureConsoleOptionsQuery for paused VMs ...................................................................... core: Enable ConfigureConsoleOptionsQuery for paused VMs ConfigureConsoleOptionsQuery had too strict VM status requirements that allowed to open console only for VMs in Running state. Added VMStatus.isQualifiedForConsoleConnect() method that returns true for any VM status that is qualified for opening console connection. This method is used in both frontend and backend. Change-Id: I56e0c0e1230fa7dc7fdb1722299672dbb8ab5eaa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234932 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java 4 files changed, 16 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56e0c0e1230fa7dc7fdb1722299672dbb8ab5eaa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Move instance initialization into @PostConstruct
by masayag＠redhat.com 05 Sep '15

05 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Move instance initialization into @PostConstruct ...................................................................... core: Move instance initialization into @PostConstruct Moves instance initialization which uses instances of external classes outside constructor into @PostConstruct method so those external instances can be made CDI beans and injected into CommandBase in later patches. Change-Id: Ia8ed25364e0fcef82d01465b91eba243cbbe610c Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQueryTest.java 6 files changed, 41 insertions(+), 21 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8ed25364e0fcef82d01465b91eba243cbbe610c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: acting on cluster specific management network
by sbonazzo＠redhat.com 04 Sep '15

04 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: acting on cluster specific management network ...................................................................... packaging: setup: acting on cluster specific management network Network are datacenter specific. If more than one dacenter is in the engine, the same name could be used for more than one network so trying to fetch the managemnt network via its name only could result in ovirtsdk.infrastructure.errors.AmbiguousQueryError Acting just on the selected cluster avoids it Change-Id: Ib8b6d2f121fb383f97e293b678aa8791a7115ed5 Bug-Url: https://bugzilla.redhat.com/1260143 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 22 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8b6d2f121fb383f97e293b678aa8791a7115ed5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0