- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Move "current" to the implementation package
by juan.hernandez＠redhat.com 07 Sep '15

07 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Move "current" to the implementation package ...................................................................... restapi: Move "current" to the implementation package The classes that manage the "current" request scope object should be part of the implementation package. This patch moves it there. Change-Id: I26c70cc8cb05f89dc3508e697e7e7cded5d0a0da Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/Current.java R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/CurrentFilter.java R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/CurrentManager.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 7 files changed, 10 insertions(+), 10 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26c70cc8cb05f89dc3508e697e7e7cded5d0a0da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add RESTEasy version to the "dependencyManagement" ...
by juan.hernandez＠redhat.com 07 Sep '15

07 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add RESTEasy version to the "dependencyManagement" section ...................................................................... restapi: Add RESTEasy version to the "dependencyManagement" section This patch adds the RESTEasy dependency to the "dependencyManagement" section of the parent POM of the RESTAPI, so that there is no need for the property that specifies its version. Change-Id: I0101e59127720c4bb089c9e9778b0f2bc586c7a5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml 4 files changed, 6 insertions(+), 7 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0101e59127720c4bb089c9e9778b0f2bc586c7a5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add EasyMock version to the "dependencyManagement" ...
by juan.hernandez＠redhat.com 07 Sep '15

07 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add EasyMock version to the "dependencyManagement" section ...................................................................... restapi: Add EasyMock version to the "dependencyManagement" section This patch adds the EasyMock dependency to the "dependencyManagement" section of the parent POM of the RESTAPI, so that there is no need for the property that specifies its version. Change-Id: I3ac1a9edc52a26c29fda88aa9c969bdb547ceb81 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml 4 files changed, 12 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ac1a9edc52a26c29fda88aa9c969bdb547ceb81 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Don't use PowerMock
by juan.hernandez＠redhat.com 07 Sep '15

07 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't use PowerMock ...................................................................... restapi: Don't use PowerMock There isn't anything currently in our tests that can't be handled directly by EasyMock, so we can remove the dependency on PowerMock. Change-Id: Id99a5aec191105b6f21341307e6e4927d8bf9a2f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/pom.xml M pom.xml 4 files changed, 19 insertions(+), 50 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id99a5aec191105b6f21341307e6e4927d8bf9a2f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Populate correctly host.spm
by juan.hernandez＠redhat.com 07 Sep '15

07 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Populate correctly host.spm ...................................................................... restapi: Populate correctly host.spm The "host.spm" element isn't correctly populated when a host representation is generated. This patch fixes that. Change-Id: Iacb694abdc709b0a166b23cdbc95e12799ea91dd Bug-Url: https://bugzilla.redhat.com/1136061 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacb694abdc709b0a166b23cdbc95e12799ea91dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fixed Total Cpus in "NUMA Topology".
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fixed Total Cpus in "NUMA Topology". ...................................................................... webadmin: Fixed Total Cpus in "NUMA Topology". In the NUMA Topology windows, The Total Cpus was calculated without taking into account the number of sockets. So now it is multiplied with the number of sockets. Change-Id: I616a31182fb8cccdfa946e51ea92f0196ae388aa Bug-Url: https://bugzilla.redhat.com/1226896 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/numa/NumaSupportPopupPresenterWidget.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I616a31182fb8cccdfa946e51ea92f0196ae388aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove the property for the JAXB plugin version
by juan.hernandez＠redhat.com 07 Sep '15

07 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove the property for the JAXB plugin version ...................................................................... restapi: Remove the property for the JAXB plugin version This patch removes the property used for the version of the JAXB plugin, as it is used only once. Change-Id: Id90c0027e56f2d164f233dd5b7d9612ac166bed6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/pom.xml 2 files changed, 1 insertion(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id90c0027e56f2d164f233dd5b7d9612ac166bed6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Enable ConfigureConsoleOptionsQuery for paused VMs
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Enable ConfigureConsoleOptionsQuery for paused VMs ...................................................................... core: Enable ConfigureConsoleOptionsQuery for paused VMs ConfigureConsoleOptionsQuery had too strict VM status requirements that allowed to open console only for VMs in Running state. Added VMStatus.isQualifiedForConsoleConnect() method that returns true for any VM status that is qualified for opening console connection. This method is used in both frontend and backend. Change-Id: I56e0c0e1230fa7dc7fdb1722299672dbb8ab5eaa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234932 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java 4 files changed, 16 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56e0c0e1230fa7dc7fdb1722299672dbb8ab5eaa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: no need to calculate readonly and preallocated disk ...
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: no need to calculate readonly and preallocated disk size on running vm from suspend ...................................................................... engine: no need to calculate readonly and preallocated disk size on running vm from suspend When we run vm from suspend we check if the storage have enough space to run. Disks that are readonly or preallocated no need to take into this account. Change-Id: I79cb594b698dd66733b0b051284e74c8258bcb58 Bug-Url: https://bugzilla.redhat.com/1130163 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79cb594b698dd66733b0b051284e74c8258bcb58 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: no need to calculate readonly and preallocated disk ...
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: no need to calculate readonly and preallocated disk size on running vm ...................................................................... engine: no need to calculate readonly and preallocated disk size on running vm When we run vm we check if the storage have enough space to run. Disks that are readonly or preallocated no need to take into this account. Change-Id: I691b7c79ce54e889ed20f4239f8ae25148b3ce4d Bug-Url: https://bugzilla.redhat.com/1130163 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I691b7c79ce54e889ed20f4239f8ae25148b3ce4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0