- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: minor refactor in handleVmOnDown
by ofrenkel＠redhat.com 26 Jul '15

26 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor refactor in handleVmOnDown ...................................................................... core: minor refactor in handleVmOnDown Currently handleVmOnDown get VmStatistics object as parameter and only use its id, which is already passed in other params, so removed. Change-Id: Ife943dde06565b2cb40f9c54efc60a5061b15cc6 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife943dde06565b2cb40f9c54efc60a5061b15cc6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix vmDynamic copy ctor
by ofrenkel＠redhat.com 26 Jul '15

26 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix vmDynamic copy ctor ...................................................................... core: fix vmDynamic copy ctor Change-Id: I869867a9fa2a9b88c9e5b994211ac5a68ddbbe55 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I869867a9fa2a9b88c9e5b994211ac5a68ddbbe55 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: changing NULL in sort behaviour
by oourfali＠redhat.com 26 Jul '15

26 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: changing NULL in sort behaviour ...................................................................... core: changing NULL in sort behaviour Modifying the search engine code to put NULLS first in case that order was ASC NULLS last in case that order was DESC Change-Id: I249f341007f84ed0fca49179598f19b87ff43045 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1243444 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Liran Zelkha: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I249f341007f84ed0fca49179598f19b87ff43045 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: use updateVMDynamicData also for events
by ofrenkel＠redhat.com 26 Jul '15

26 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: use updateVMDynamicData also for events ...................................................................... core: use updateVMDynamicData also for events currently there is a special vm dynamic builder for event data, since it is planed that events will provide more information, it is better to use the 'full' builder that is used for stats cycle. this reuired 2 changes: * cleaning field initialization if field is missing on xmlStruct - this was not needed since all the fields already null by default, or set with the same value in the default ctor. * move post-processing of display ip inside this flow, it anyway makes sense, and a bug it was called only on stats, thus required passing the host as parameter from all callers. Change-Id: Id4331b019fc48fe62d35b6f0b8e68e0765348dcf Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ChangeDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ChangeFloppyVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PauseVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java 9 files changed, 67 insertions(+), 109 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4331b019fc48fe62d35b6f0b8e68e0765348dcf Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: dbscript: fix dbfunc_psql_statement_parse_line
by emesika＠redhat.com 26 Jul '15

26 Jul '15

Eli Mesika has submitted this change and it was merged. Change subject: dbscript: fix dbfunc_psql_statement_parse_line ...................................................................... dbscript: fix dbfunc_psql_statement_parse_line it probably worked so far because we do not use special characters. either we echo each character or we accumulate into variable, we cannot do both. Change-Id: Ifbb05141eca393adc1f3b68fe397f7259d40cd55 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/dbfunc-base.sh M packaging/setup/dbutils/dbfunc-base.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbb05141eca393adc1f3b68fe397f7259d40cd55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix entity manager scope
by oourfali＠redhat.com 26 Jul '15

26 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix entity manager scope ...................................................................... core: Fix entity manager scope EntityManager had a too large scope when using it through DbFacade. Change-Id: I1e4962a0dbb7ae585181a0a9b390f86679ba07ac Bug-Url: https://bugzilla.redhat.com/1159621 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineBackupLogDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/AbstractJpaDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/EntityManagerHolder.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/TransactionalInterceptor.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/EntityManagerTestListener.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseHibernateDaoTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DaoCdiIntegrationTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java M backend/manager/modules/dal/src/test/resources/test-beans.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/Transactional.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/TransactionalInterceptor.java 19 files changed, 280 insertions(+), 141 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Liran Zelkha: Verified Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e4962a0dbb7ae585181a0a9b390f86679ba07ac Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: pki: ca: enforce utf-8 subject
by oourfali＠redhat.com 26 Jul '15

26 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: pki: ca: enforce utf-8 subject ...................................................................... pki: ca: enforce utf-8 subject Yet another legacy issue. By default openssl ca use ANSI and not UTF-8 to encode subject name. The result is UTF8STRING in both cases, but the actual character encoding differs. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1246494 Change-Id: I3ea89735e0bdb3c61faa91ed813a3b8b8a25028c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/pki-create-ca.sh M packaging/bin/pki-enroll-request.sh 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43965 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ea89735e0bdb3c61faa91ed813a3b8b8a25028c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: pki: ca: enforce utf-8 subject
by oourfali＠redhat.com 26 Jul '15

26 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: pki: ca: enforce utf-8 subject ...................................................................... pki: ca: enforce utf-8 subject Yet another legacy issue. By default openssl ca use ANSI and not UTF-8 to encode subject name. The result is UTF8STRING in both cases, but the actual character encoding differs. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1246494 Change-Id: I3ea89735e0bdb3c61faa91ed813a3b8b8a25028c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/pki-create-ca.sh M packaging/bin/pki-enroll-request.sh 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ea89735e0bdb3c61faa91ed813a3b8b8a25028c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: made GetAllHosts to be a user query
by ofrenkel＠redhat.com 26 Jul '15

26 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: made GetAllHosts to be a user query ...................................................................... core: made GetAllHosts to be a user query This query already supports filtering and on the REST it is expected that this query will be a user query (BackendHostsResource.listAll()). Change-Id: Ia3ce1a94852982a377fce674a4c42e25decbce16 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3ce1a94852982a377fce674a4c42e25decbce16 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Added missing java timezone mapping and added test
by ofrenkel＠redhat.com 26 Jul '15

26 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Added missing java timezone mapping and added test ...................................................................... core: Added missing java timezone mapping and added test The mapping for the 'Central Standard Time (Mexico)' to the corresponding java timezone name was missing and results in VMs being created with that VM assigned, to end up having a UTC timezone. The test verifies, that all Windows timezones, do have a mapping target. Change-Id: I6ecf3b69e18e42808303861f39363f93d5b72269 Bug-Url: https://bugzilla.redhat.com/1245801 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/TimeZoneTypeTest.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/WindowsJavaTimezoneMapping.java 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ecf3b69e18e42808303861f39363f93d5b72269 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0