- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Remove the "selectedItem" terminology from Storage...
by derez＠redhat.com 23 Jul '15

23 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Remove the "selectedItem" terminology from StorageModel. ...................................................................... webadmin: Remove the "selectedItem" terminology from StorageModel. privateAvailableiStorageItems List now appears only behind the scenes. We have StorageType and StorageDomainType lists seperatly now, which *are* displayed. Though this list is no longer displayed, it plays a great logical part. This patch removes the list. This is the first setp in making StorageModel inherit from Model instead of ListModel<IStorageModel> . Change-Id: I5d16972f8155ccea4505fd268683cbe92b079a84 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java 7 files changed, 145 insertions(+), 131 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/43317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d16972f8155ccea4505fd268683cbe92b079a84 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Branding warning message
by awels＠redhat.com 23 Jul '15

23 Jul '15

Alexander Wels has submitted this change and it was merged. Change subject: engine: Branding warning message ...................................................................... engine: Branding warning message - Branding was generating a repeating warning message when logged into the web admin. This was due to a forward to the services path without the services having the locale filter configured. Change-Id: Ia3ff42bcd884e23635facbc8763f9071ee79493e Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified; Passed CI tests Einav Cohen: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Omer Frenkel: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3ff42bcd884e23635facbc8763f9071ee79493e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Set VDS status to down after ssh shutdown
by rgolan＠redhat.com 23 Jul '15

23 Jul '15

Roy Golan has submitted this change and it was merged. Change subject: core: Set VDS status to down after ssh shutdown ...................................................................... core: Set VDS status to down after ssh shutdown Fix that the state was only set to down for the VDS instance which was passed into the command. When querying for the VDS in the database it still showed that the VDS was up. Further the audit log did not show that the ssh shutdown was executed. Now it logs USER_VDS_STOP on success and USER_FAILED_VDS_STOP otherwise. Change-Id: I7f837e5d179a3ed0090fa76eef965a7df673940d Bug-Url: https://bugzilla.redhat.com/1062228 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsPowerDownCommand.java 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f837e5d179a3ed0090fa76eef965a7df673940d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Small fixes in TimeZone display values
by shavivi＠redhat.com 23 Jul '15

23 Jul '15

Shahar Havivi has submitted this change and it was merged. Change subject: core: Small fixes in TimeZone display values ...................................................................... core: Small fixes in TimeZone display values Renamed display values of time zones mapped to 'GMT' to help users differentiate between them. Change-Id: I1ef9e1a3f1e459b6a4513a608a650ede1b6a6570 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232695 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/43603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ef9e1a3f1e459b6a4513a608a650ede1b6a6570 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: OvfManager handles Vm Icons
by ofrenkel＠redhat.com 23 Jul '15

23 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: OvfManager handles Vm Icons ...................................................................... core: OvfManager handles Vm Icons Vm Icons are not serialized to OVF format. OvfManager now can set icon properties according to operating system id and fallback to default icons which prevents null values in icon columns of vm_static table. Change-Id: I30bfb275885ba673743cd700b0389ded9e038f40 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1243029 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmIconDefaultsQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveImageCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmIconDefaultsProvider.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 12 files changed, 132 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30bfb275885ba673743cd700b0389ded9e038f40 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Avoid having leftovers when adding NFS SD.
by mlipchuk＠redhat.com 23 Jul '15

23 Jul '15

Maor Lipchuk has submitted this change and it was merged. Change subject: restapi: Avoid having leftovers when adding NFS SD. ...................................................................... restapi: Avoid having leftovers when adding NFS SD. If the process, of adding/importing NFS Storage Domain, fails while validating the storage domain name, the storage server connection data, which was added in the process, does not gets deleted from the DB. The proposed fix validates the name inside the try catch clause. Change-Id: I7b001468fbbb3a30c08f8efdf0db74db946874d5 Bug-Url: https://bugzilla.redhat.com/1208057 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/43923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b001468fbbb3a30c08f8efdf0db74db946874d5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernández Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove redundant comment.
by mlipchuk＠redhat.com 23 Jul '15

23 Jul '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant comment. ...................................................................... core: Remove redundant comment. Change-Id: Ic6833ef6139746f706e3a26226592da71fab0c8a Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcCommandBase.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/43922 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6833ef6139746f706e3a26226592da71fab0c8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: build: reduce usage of sjf4j-jdk14 spring-test
by masayag＠redhat.com 23 Jul '15

23 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: build: reduce usage of sjf4j-jdk14 spring-test ...................................................................... build: reduce usage of sjf4j-jdk14 spring-test move some of the usages to test scope. also reorder the effected pom.xmls so that format will match others and test scope will follow the common scope. Change-Id: I9f89fbb9af76a0712ade2862f42ad0d1beeb0010 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/extensions-manager/pom.xml 5 files changed, 68 insertions(+), 85 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f89fbb9af76a0712ade2862f42ad0d1beeb0010 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Remove redundant assignment
by oourfali＠redhat.com 23 Jul '15

23 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Remove redundant assignment ...................................................................... engine: Remove redundant assignment Change-Id: Iccb5f3ae94b66dd166d91c770816cd7b416d8b20 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccb5f3ae94b66dd166d91c770816cd7b416d8b20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Postpone certs validity check service start
by oourfali＠redhat.com 23 Jul '15

23 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Postpone certs validity check service start ...................................................................... engine: Postpone certs validity check service start Due to race between the host broker initialization and the attempt to obtain host certificates, there is a need to delay the certification check service, to allow the engine to obtain connectivity to the host and properly restart the brokers. Change-Id: I350fb5a68992b1de7af20bcb3b4c816eabafc80f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I350fb5a68992b1de7af20bcb3b4c816eabafc80f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0