- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: sdk: Register only relevant auth schemes
by juan.hernandez＠redhat.com 24 Jul '15

24 Jul '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Register only relevant auth schemes ...................................................................... sdk: Register only relevant auth schemes Currently the SDK uses the default set of authentication scheme factories, but some of them can't be used even if the server supports them because the SDK may not have the required credentials. For example, the caller may have initialized the SDK activating Kerberos but without providing a user name and password: Api api = new ApiBuilder() .url("https://...") .kerberos(true) .build(); This is completely normal. But the server may support both Kerberos and Basic authentication, responding with the following headers: WWW-Authenticate: Negotiate WWW-Authenticate: Basic realm="My realm" In this case the underying HTTP library will first try to use the Negotiate authentication scheme, and if it fails (there is no TGT in the Kerberos credentials cache, for example) it will try Basic. But basic will not work because the SDK doesn't have any valid credentials, and will actually generate a NPE. To avoid this issue this patch changes the SDK so that it only registers the authentication schemes it has credentials for. Change-Id: Iaafc13d9128a6e6072dbf02e85f7a3eedc1af838 Bug-Url: https://bugzilla.redhat.com/1243337 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/Makefile M sdk/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPoolBuilder.java 2 files changed, 19 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaafc13d9128a6e6072dbf02e85f7a3eedc1af838 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-host-deploy[master]: plugins: split pki into common group
by Alon Bar-Lev 23 Jul '15

23 Jul '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: plugins: split pki into common group ...................................................................... plugins: split pki into common group modify default of vdsm to enrollment none as engine enforced this since started to use host-deploy. Change-Id: Ia165e1c3be5e7cc6daeeb195c3fe419e208237a1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M configure.ac M ovirt-host-deploy.spec.in M po/POTFILES.in M src/bin/executor.in M src/interface-3/Makefile.am M src/plugins/Makefile.am A src/plugins/ovirt-host-common/Makefile.am A src/plugins/ovirt-host-common/vdsm/Makefile.am A src/plugins/ovirt-host-common/vdsm/__init__.py R src/plugins/ovirt-host-common/vdsm/pki.py A src/plugins/ovirt-host-common/vmconsole/Makefile.am A src/plugins/ovirt-host-common/vmconsole/__init__.py R src/plugins/ovirt-host-common/vmconsole/pki.py M src/plugins/ovirt-host-deploy/vdsm/Makefile.am M src/plugins/ovirt-host-deploy/vdsm/__init__.py M src/plugins/ovirt-host-deploy/vmconsole/Makefile.am M src/plugins/ovirt-host-deploy/vmconsole/__init__.py 17 files changed, 193 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, approved; Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/43151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia165e1c3be5e7cc6daeeb195c3fe419e208237a1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: slf4j: require only specific rpms not entire repo
by dcaroest＠redhat.com 23 Jul '15

23 Jul '15

David Caro has submitted this change and it was merged. Change subject: slf4j: require only specific rpms not entire repo ...................................................................... slf4j: require only specific rpms not entire repo Change-Id: I023bb4d34a4995fe11f5e45b1cc8fdd3ce264791 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M jobs/confs/yaml/jobs/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/43933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I023bb4d34a4995fe11f5e45b1cc8fdd3ce264791 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: Calling vdsm-tool configure after touching its conf files
by sbonazzo＠redhat.com 23 Jul '15

23 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Calling vdsm-tool configure after touching its conf files ...................................................................... Calling vdsm-tool configure after touching its conf files After changing vdsm configuration we explicitly have to call vdsm-tool configure to make it effective cause simply reloading the service is not enough. Change-Id: I8c6f1efd71926c59082f20d841eeea2957dad656 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1235591 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py 1 file changed, 33 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c6f1efd71926c59082f20d841eeea2957dad656 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: Calling vdsm-tool configure after touching its conf files
by sbonazzo＠redhat.com 23 Jul '15

23 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Calling vdsm-tool configure after touching its conf files ...................................................................... Calling vdsm-tool configure after touching its conf files After changing vdsm configuration we explicitly have to call vdsm-tool configure to make it effective cause simply reloading the service is not enough. Change-Id: I8c6f1efd71926c59082f20d841eeea2957dad656 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1235591 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py 1 file changed, 33 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c6f1efd71926c59082f20d841eeea2957dad656 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: bug fix in ImportVmFromExportDomainModel
by derez＠redhat.com 23 Jul '15

23 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: bug fix in ImportVmFromExportDomainModel ...................................................................... webadmin: bug fix in ImportVmFromExportDomainModel In the "Import Virtual Machine(s)" view, under the Disks sub tab, one couldn't change a disk's destination storage domain since the drop down list won't accept his selection. This patch fixes this bug, so now one can change the storage domain. Change-Id: I4f4cbb1128ff0032e48cfa7df99870f7dd757da6 Bug-Url: https://bugzilla.redhat.com/1217379 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/43943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f4cbb1128ff0032e48cfa7df99870f7dd757da6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Disallow ISO on local host in a non-local DC
by derez＠redhat.com 23 Jul '15

23 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disallow ISO on local host in a non-local DC ...................................................................... webadmin: Disallow ISO on local host in a non-local DC Change-Id: I5af17652bcfa5b1adb511fed316d320ba9431d3b Bug-Url: https://bugzilla.redhat.com/1243876 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved; Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/43805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5af17652bcfa5b1adb511fed316d320ba9431d3b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Removed local SD option for shared/none DCs
by derez＠redhat.com 23 Jul '15

23 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Removed local SD option for shared/none DCs ...................................................................... webadmin: Removed local SD option for shared/none DCs Change-Id: I775f9ca1ee4ed1b5e808aa28a64825cf34d3d30e Bug-Url: https://bugzilla.redhat.com/1244479 Bug-Url: https://bugzilla.redhat.com/1243882 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java 4 files changed, 44 insertions(+), 25 deletions(-) Approvals: Daniel Erez: Looks good to me, approved; Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/43751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I775f9ca1ee4ed1b5e808aa28a64825cf34d3d30e Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: StorageModel to inherit from Model
by derez＠redhat.com 23 Jul '15

23 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: StorageModel to inherit from Model ...................................................................... webadmin: StorageModel to inherit from Model Removed the inheritance from ListModel<IStorageModel> . A list of IStorageModels is now a data member of the class. Change-Id: If443951bcd21e1e0130b4141d808659060591155 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java 7 files changed, 34 insertions(+), 22 deletions(-) Approvals: Daniel Erez: Looks good to me, approved; Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/43439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If443951bcd21e1e0130b4141d808659060591155 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Align domain function items in import and new domain
by derez＠redhat.com 23 Jul '15

23 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Align domain function items in import and new domain ...................................................................... webadmin: Align domain function items in import and new domain The order of domain function item in the import view was wrong. It is now the same as in the New Domain view. Change-Id: I04e157754cc7be872898f0f1c0ba5708b820e64e Bug-Url: https://bugzilla.redhat.com/1241576 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved; Passed CI tests Maor Lipchuk: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/43438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04e157754cc7be872898f0f1c0ba5708b820e64e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0